Revert "SWDEV-332606 - SWDEV-333585 - Fix hipMemcpySymbol* and hipGetSymbol* APIs"

This reverts commit 1ab7f22334 due to QMCPack test failure (SWDEV-335826)

Change-Id: I40397b345aa60f43afc17853bc72426daf385cf7


[ROCm/clr commit: 84c46047e5]

projects/clr/hipamd/src/hip_memory.cpp

@@ -1125,11 +1125,6 @@ inline hipError_t ihipMemcpySymbol_validate(const void* symbol, size_t sizeBytes
 hipError_t hipMemcpyToSymbol_common(const void* symbol, const void* src, size_t sizeBytes,
                              size_t offset, hipMemcpyKind kind, hipStream_t stream=nullptr) {
   CHECK_STREAM_CAPTURING();
-
-  if (kind != hipMemcpyHostToDevice) {
-    HIP_RETURN(hipErrorInvalidMemcpyDirection);
-  }
-
   size_t sym_size = 0;
   hipDeviceptr_t device_ptr = nullptr;
 
@@ -1158,11 +1153,6 @@ hipError_t hipMemcpyToSymbol_spt(const void* symbol, const void* src, size_t siz
 hipError_t hipMemcpyFromSymbol_common(void* dst, const void* symbol, size_t sizeBytes,
                                size_t offset, hipMemcpyKind kind, hipStream_t stream=nullptr) {
   CHECK_STREAM_CAPTURING();
-
-  if (kind != hipMemcpyDeviceToHost) {
-    HIP_RETURN(hipErrorInvalidMemcpyDirection);
-  }
-
   size_t sym_size = 0;
   hipDeviceptr_t device_ptr = nullptr;
 
@@ -1194,10 +1184,6 @@ hipError_t hipMemcpyToSymbolAsync(const void* symbol, const void* src, size_t si
 
   STREAM_CAPTURE(hipMemcpyToSymbolAsync, stream, symbol, src, sizeBytes, offset, kind);
 
-  if (kind != hipMemcpyHostToDevice) {
-    HIP_RETURN(hipErrorInvalidMemcpyDirection);
-  }
-
   size_t sym_size = 0;
   hipDeviceptr_t device_ptr = nullptr;
 
@@ -1215,10 +1201,6 @@ hipError_t hipMemcpyFromSymbolAsync(void* dst, const void* symbol, size_t sizeBy
 
   STREAM_CAPTURE(hipMemcpyFromSymbolAsync, stream, dst, symbol, sizeBytes, offset, kind);
 
-  if (kind != hipMemcpyDeviceToHost) {
-    HIP_RETURN(hipErrorInvalidMemcpyDirection);
-  }
-
   size_t sym_size = 0;
   hipDeviceptr_t device_ptr = nullptr;
 

projects/clr/hipamd/src/hip_platform.cpp

@@ -278,9 +278,6 @@ hipError_t hipGetSymbolAddress(void** devPtr, const void* symbol) {
   HIP_INIT_API(hipGetSymbolAddress, devPtr, symbol);
 
   hipError_t hip_error = hipSuccess;
-  if (devPtr == nullptr) {
-    HIP_RETURN(hipErrorInvalidValue);
-  }
   size_t sym_size = 0;
 
   HIP_RETURN_ONFAIL(PlatformState::instance().getStatGlobalVar(symbol, ihipGetDevice(), devPtr, &sym_size));
@@ -291,9 +288,6 @@ hipError_t hipGetSymbolAddress(void** devPtr, const void* symbol) {
 hipError_t hipGetSymbolSize(size_t* sizePtr, const void* symbol) {
   HIP_INIT_API(hipGetSymbolSize, sizePtr, symbol);
 
-  if (sizePtr == nullptr) {
-    HIP_RETURN(hipErrorInvalidValue);
-  }
   hipDeviceptr_t device_ptr = nullptr;
   HIP_RETURN_ONFAIL(PlatformState::instance().getStatGlobalVar(symbol, ihipGetDevice(), &device_ptr, sizePtr));