AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MSCCL++ fix split path null deref (#1959)

Browse Source 
* Add speriaswamy-amd to CODEOWNERS
* MSCCL++: fix split path null deref; key maps by parent ncclUniqueId
* removed no-op
This commit is contained in:
Surya Periaswamy
2025-10-09 14:08:38 -05:00
committed by GitHub
parent 6b200ee6c5
commit 5bd5079de1
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/init.cc
+4 -4
View File
@@ -2043,10 +2043,10 @@ static ncclResult_t ncclCommInitRankFunc(struct ncclAsyncJob* job_) {
comm->mscclppCompatible = true;
comm->mscclpp_threshold = job->parent->mscclpp_threshold;
comm->mscclpp_comm = job->parent->mscclpp_comm;
auto& mscclppUniqueId = mscclpp_uniqueIdMap[*job->commId];
mscclpp_uniqueIdMap[*job->commId] = mscclppUniqueId;
mscclpp_uniqueIdReverseMap[mscclppUniqueId].insert(*job->commId);
ncclCommToUniqueIdMap[comm] = *job->commId;
const ncclUniqueId& parentUniqueId = ncclCommToUniqueIdMap[job->parent];
auto& mscclppUniqueId = mscclpp_uniqueIdMap[parentUniqueId];
mscclpp_uniqueIdReverseMap[mscclppUniqueId].insert(parentUniqueId);
ncclCommToUniqueIdMap[comm] = parentUniqueId;
}
}
else