Add option to skip barrier marker events in traces (#320)
* Add option to skip barrier marker events in traces
* Formatting
* Apply review suggestions
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
* clang-format
* Formatting
---------
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
[ROCm/rocprofiler-systems commit: 82cbe3f306]
This commit is contained in:
committed by
GitHub
orang tua
e0ed9a6e52
melakukan
5e4d7f7f84
@@ -629,6 +629,10 @@ configure_settings(bool _init)
|
||||
"HSA API type to collect", "", "roctracer", "rocm",
|
||||
"advanced");
|
||||
|
||||
OMNITRACE_CONFIG_SETTING(bool, "OMNITRACE_ROCTRACER_DISCARD_BARRIERS",
|
||||
"Skip barrier marker events in traces", false, "roctracer",
|
||||
"rocm", "advanced");
|
||||
|
||||
OMNITRACE_CONFIG_SETTING(
|
||||
std::string, "OMNITRACE_ROCM_EVENTS",
|
||||
"ROCm hardware counters. Use ':device=N' syntax to specify collection on device "
|
||||
|
||||
@@ -928,8 +928,11 @@ hip_activity_callback(const char* begin, const char* end, void* arg)
|
||||
using Phase = critical_trace::Phase;
|
||||
|
||||
if(!trait::runtime_enabled<comp::roctracer>::get()) return;
|
||||
static auto _kernel_names = std::unordered_map<const char*, std::string>{};
|
||||
static auto _indexes = std::unordered_map<uint64_t, int>{};
|
||||
static auto _kernel_names = std::unordered_map<const char*, std::string>{};
|
||||
static auto _indexes = std::unordered_map<uint64_t, int>{};
|
||||
static auto _skip_barrier_packets =
|
||||
config::get_setting_value<bool>("OMNITRACE_ROCTRACER_DISCARD_BARRIERS")
|
||||
.value_or(false);
|
||||
const roctracer_record_t* record = reinterpret_cast<const roctracer_record_t*>(begin);
|
||||
const roctracer_record_t* end_record =
|
||||
reinterpret_cast<const roctracer_record_t*>(end);
|
||||
@@ -956,6 +959,7 @@ hip_activity_callback(const char* begin, const char* end, void* arg)
|
||||
}
|
||||
if(record->domain != ACTIVITY_DOMAIN_HIP_OPS) continue;
|
||||
if(record->op > HIP_OP_ID_BARRIER) continue;
|
||||
if(_skip_barrier_packets && record->op == HIP_OP_ID_BARRIER) continue;
|
||||
|
||||
const char* op_name =
|
||||
roctracer_op_string(record->domain, record->op, record->kind);
|
||||
|
||||
Reference in New Issue
Block a user