AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-335490: Unused variables

Browse Source 
Compilers doesn't see assert as a usage of the variables, I added [[maybe_unused]] to the variables that are used only in assert to make sure that the compiler is skipping them in the check. Note: [[maybe_unused]] is introduced in C++17

Change-Id: I96bb53cb2ab55ee7120681c2d279271c0075095d


[ROCm/roctracer commit: 78869032ad]
This commit is contained in:
Ammar ELWazir
2022-05-04 09:11:29 -05:00
committed by Ammar Elwazir
parent e0aaaf4636
commit 5f2a988464
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/roctracer/src/core/roctracer.cpp
+2 -2
View File
@@ -294,7 +294,7 @@ static thread_local std::stack<activity_correlation_id_t> external_id_stack;
static inline void CorrelationIdRegistr(const activity_correlation_id_t& correlation_id) {
std::lock_guard<correlation_id_mutex_t> lck(correlation_id_mutex);
const auto ret = correlation_id_map.insert({correlation_id, correlation_id_tls});
[[maybe_unused]] const auto ret = correlation_id_map.insert({correlation_id, correlation_id_tls});
assert(ret.second && "HIP activity id is not unique");
DEBUG_TRACE("CorrelationIdRegistr id(%lu) id_tls(%lu)\n", correlation_id, correlation_id_tls);
@@ -1229,7 +1229,7 @@ PUBLIC_API roctracer_status_t roctracer_set_properties(roctracer_domain_t domain
#endif
// HSA async-copy tracing
hsa_status_t status = hsa_amd_profiling_async_copy_enable(true);
[[maybe_unused]] hsa_status_t status = hsa_amd_profiling_async_copy_enable(true);
assert(status == HSA_STATUS_SUCCESS && "hsa_amd_profiling_async_copy_enable failed");
roctracer::hsa_amd_memory_async_copy_fn = table->amd_ext_->hsa_amd_memory_async_copy_fn;
roctracer::hsa_amd_memory_async_copy_rect_fn =
projects/roctracer/src/core/tracker.h
+1 -1
View File
@@ -141,7 +141,7 @@ class Tracker {
orig_signal_ptr->start_ts = prof_signal_ptr->start_ts;
orig_signal_ptr->end_ts = prof_signal_ptr->end_ts;
const hsa_signal_value_t new_value = hsa_signal_load_relaxed(orig) - 1;
[[maybe_unused]] const hsa_signal_value_t new_value = hsa_signal_load_relaxed(orig) - 1;
assert(signal_value == new_value && "Tracker::Complete bad signal value");
hsa_signal_store_screlease(orig, signal_value);
}