EXSWHTEC-3 - Implement tests for hipDeviceReset (#2873)
* Implement tests for hipDeviceReset - Basic test for behaviour validation - Multithreaded test similar to basic test. * Update license boilerplate. Signed-off-by: Dino Music <dino.music@htecgroup.com> * EXSWHTEC-3 - Add stream and memory checks to hipDeviceReset tests. * EXSWHTEC-3 - Corrected expected error code for hipStreamDestroy * EXSWHTEC-3 - Corrected check ordering in Unit_hipDeviceReset_Positive_Threaded test. * EXSWHTEC-3 - Exclude hipDeviceSetGetCacheConfig checks for AMD * EXSWHTEC-3 - Corrected merge error in device/CMakeLists.txt * EXSWHTEC-3 - Remove NVIDIA guards from tests and relax the code. * EXSWHTEC-3 - Update tests to take into account unsupported operations on AMD * EXSWHTEC-3 - Fix bug in Unit_hipDeviceReset_Positive_Threaded test. * EXSWHTEC-3 - Disable hipDeviceReset tests for AMD.
This commit is contained in:
Mirza Halilčević
zatwierdzone przez
GitHub
GitHub
rodzic
bcdb3a7ece
commit
65ba7da607
@@ -12,6 +12,8 @@
|
||||
"Unit_hipIpcOpenMemHandle_Negative_Open_In_Creating_Process",
|
||||
"Unit_hipDeviceGetPCIBusId_Negative_PartialFill",
|
||||
"Unit_hipInit_Negative",
|
||||
"Unit_hipMemset_Negative_OutOfBoundsPtr"
|
||||
"Unit_hipMemset_Negative_OutOfBoundsPtr",
|
||||
"Unit_hipDeviceReset_Positive_Basic",
|
||||
"Unit_hipDeviceReset_Positive_Threaded"
|
||||
]
|
||||
}
|
||||
|
||||
@@ -80,6 +80,8 @@
|
||||
"Unit_hipDeviceGetPCIBusId_Negative_PartialFill",
|
||||
"Unit_hipDeviceGetSharedMemConfig_Positive_Basic",
|
||||
"Unit_hipDeviceGetSharedMemConfig_Positive_Threaded",
|
||||
"Unit_hipDeviceReset_Positive_Basic",
|
||||
"Unit_hipDeviceReset_Positive_Threaded",
|
||||
"Unit_hipInit_Negative",
|
||||
"Unit_hipGraphMemcpyNodeSetParams_Functional",
|
||||
"Unit_hipGraphNodeGetDependentNodes_Functional",
|
||||
|
||||
@@ -23,6 +23,7 @@ set(TEST_SRC
|
||||
hipExtGetLinkTypeAndHopCount.cc
|
||||
hipDeviceSetLimit.cc
|
||||
hipDeviceSetGetSharedMemConfig.cc
|
||||
hipDeviceReset.cc
|
||||
hipDeviceSetGetMemPool.cc
|
||||
hipInit.cc
|
||||
hipDriverGetVersion.cc
|
||||
|
||||
@@ -0,0 +1,131 @@
|
||||
/*
|
||||
Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
|
||||
Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
of this software and associated documentation files (the "Software"), to deal
|
||||
in the Software without restriction, including without limitation the rights
|
||||
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
copies of the Software, and to permit persons to whom the Software is
|
||||
furnished to do so, subject to the following conditions:
|
||||
|
||||
The above copyright notice and this permission notice shall be included in
|
||||
all copies or substantial portions of the Software.
|
||||
|
||||
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||
THE SOFTWARE.
|
||||
*/
|
||||
|
||||
#include <hip_test_common.hh>
|
||||
#include <hip/hip_runtime_api.h>
|
||||
|
||||
TEST_CASE("Unit_hipDeviceReset_Positive_Basic") {
|
||||
const auto device = GENERATE(range(0, HipTest::getDeviceCount()));
|
||||
HIP_CHECK(hipSetDevice(device));
|
||||
INFO("Current device is: " << device);
|
||||
|
||||
unsigned int flags_before = 0u;
|
||||
HIP_CHECK(hipGetDeviceFlags(&flags_before));
|
||||
hipSharedMemConfig mem_config_before;
|
||||
HIP_CHECK(hipDeviceGetSharedMemConfig(&mem_config_before));
|
||||
|
||||
void* ptr = nullptr;
|
||||
HIP_CHECK(hipMalloc(&ptr, 500));
|
||||
hipStream_t stream = nullptr;
|
||||
HIP_CHECK(hipStreamCreate(&stream));
|
||||
|
||||
const auto cache_config_ret = hipDeviceSetCacheConfig(hipFuncCachePreferL1);
|
||||
REQUIRE((cache_config_ret == hipSuccess || cache_config_ret == hipErrorNotSupported));
|
||||
|
||||
const auto shared_mem_config_ret = hipDeviceSetSharedMemConfig(
|
||||
mem_config_before == hipSharedMemBankSizeFourByte ? hipSharedMemBankSizeEightByte
|
||||
: hipSharedMemBankSizeFourByte);
|
||||
REQUIRE((shared_mem_config_ret == hipSuccess || shared_mem_config_ret == hipErrorNotSupported));
|
||||
|
||||
HIP_CHECK(hipSetDeviceFlags(flags_before ^ (1u << 2)));
|
||||
|
||||
HIP_CHECK(hipDeviceReset());
|
||||
|
||||
unsigned int flags_after = 0u;
|
||||
CHECK(hipGetDeviceFlags(&flags_after) == hipSuccess);
|
||||
CHECK(flags_after == flags_before);
|
||||
|
||||
CHECK(hipFree(ptr) == hipErrorInvalidValue);
|
||||
|
||||
// Inconsistent behavior in CUDA, sometimes segfaults, sometimes works
|
||||
// Return value mismatch on AMD - EXSWHTEC-124
|
||||
#if HT_NVIDIA
|
||||
CHECK(hipStreamDestroy(stream) == hipErrorInvalidHandle);
|
||||
#endif
|
||||
|
||||
if (cache_config_ret == hipSuccess) {
|
||||
hipFuncCache_t cache_config;
|
||||
CHECK(hipDeviceGetCacheConfig(&cache_config) == hipSuccess);
|
||||
CHECK(cache_config == hipFuncCachePreferNone);
|
||||
}
|
||||
|
||||
if (shared_mem_config_ret == hipSuccess) {
|
||||
hipSharedMemConfig mem_config_after;
|
||||
CHECK(hipDeviceGetSharedMemConfig(&mem_config_after) == hipSuccess);
|
||||
CHECK(mem_config_after == mem_config_before);
|
||||
}
|
||||
}
|
||||
|
||||
TEST_CASE("Unit_hipDeviceReset_Positive_Threaded") {
|
||||
HIP_CHECK(hipSetDevice(0));
|
||||
INFO("Current device is: " << 0);
|
||||
|
||||
unsigned int flags_before = 0u;
|
||||
HIP_CHECK(hipGetDeviceFlags(&flags_before));
|
||||
hipSharedMemConfig mem_config_before;
|
||||
HIP_CHECK(hipDeviceGetSharedMemConfig(&mem_config_before));
|
||||
|
||||
void* ptr = nullptr;
|
||||
HIP_CHECK(hipMalloc(&ptr, 500));
|
||||
hipStream_t stream = nullptr;
|
||||
HIP_CHECK(hipStreamCreate(&stream));
|
||||
|
||||
const auto cache_config_ret = hipDeviceSetCacheConfig(hipFuncCachePreferL1);
|
||||
REQUIRE((cache_config_ret == hipSuccess || cache_config_ret == hipErrorNotSupported));
|
||||
|
||||
const auto shared_mem_config_ret = hipDeviceSetSharedMemConfig(
|
||||
mem_config_before == hipSharedMemBankSizeFourByte ? hipSharedMemBankSizeEightByte
|
||||
: hipSharedMemBankSizeFourByte);
|
||||
REQUIRE((shared_mem_config_ret == hipSuccess || shared_mem_config_ret == hipErrorNotSupported));
|
||||
|
||||
|
||||
HIP_CHECK(hipSetDeviceFlags(flags_before ^ (1u << 2)));
|
||||
|
||||
std::thread([] {
|
||||
HIP_CHECK_THREAD(hipSetDevice(0));
|
||||
HIP_CHECK_THREAD(hipDeviceReset());
|
||||
}).join();
|
||||
HIP_CHECK_THREAD_FINALIZE();
|
||||
|
||||
unsigned int flags_after = 0u;
|
||||
CHECK(hipGetDeviceFlags(&flags_after) == hipSuccess);
|
||||
CHECK(flags_after == flags_before);
|
||||
|
||||
CHECK(hipFree(ptr) == hipErrorInvalidValue);
|
||||
|
||||
// Inconsistent behavior in CUDA, sometimes segfaults, sometimes works
|
||||
// Return value mismatch on AMD - EXSWHTEC-124
|
||||
#if HT_NVIDIA
|
||||
CHECK(hipStreamDestroy(stream) == hipErrorInvalidHandle);
|
||||
#endif
|
||||
|
||||
if (cache_config_ret == hipSuccess) {
|
||||
hipFuncCache_t cache_config;
|
||||
CHECK(hipDeviceGetCacheConfig(&cache_config) == hipSuccess);
|
||||
CHECK(cache_config == hipFuncCachePreferNone);
|
||||
}
|
||||
|
||||
if (shared_mem_config_ret == hipSuccess) {
|
||||
hipSharedMemConfig mem_config_after;
|
||||
CHECK(hipDeviceGetSharedMemConfig(&mem_config_after) == hipSuccess);
|
||||
CHECK(mem_config_after == mem_config_before);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user