AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "SWDEV-403995 - uniform_work_group_size is interger type is 1 for true and 0 for false. Lighting kernel's init sets uniform work group flag and hence not need to set it from options."

Browse Source 
This reverts commit 063b3d4e51.

Change-Id: I077135a726320eb109888f0e7442120dc852ad3e


[ROCm/clr commit: 90f53925a3]
This commit is contained in:
Jaydeep Patel
2023-07-05 04:40:54 +00:00
parent c2b7aa6b73
commit 6fa299f3a3
3 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/clr/rocclr/device/devkernel.cpp
+1 -1
View File
@@ -570,7 +570,7 @@ static amd_comgr_status_t populateKernelMetaV3(const amd_comgr_metadata_node_t k
kernel->SetWGPMode(buf.compare("true") == 0);
break;
case KernelField::UniformWrokGroupSize:
kernel->setUniformWorkGroupSize(buf.compare("1") == 0);
kernel->setUniformWorkGroupSize(buf.compare("true") == 0);
break;
default:
return AMD_COMGR_STATUS_ERROR;
projects/clr/rocclr/device/pal/palprogram.cpp
+2 -3
View File
@@ -748,9 +748,8 @@ bool LightningProgram::createKernels(void* binary, size_t binSize, bool useUnifo
return false;
}
kernels()[kernelName] = kernel;
if (codeObjectVer() < 5) {
kernel->setUniformWorkGroupSize(useUniformWorkGroupSize);
}
kernel->setUniformWorkGroupSize(useUniformWorkGroupSize);
}
executable_ = loader_->CreateExecutable(HSA_PROFILE_FULL, nullptr);
projects/clr/rocclr/device/rocm/rocprogram.cpp
+1 -3
View File
@@ -274,9 +274,7 @@ bool LightningProgram::createKernels(void* binary, size_t binSize, bool useUnifo
if (!aKernel->init()) {
return false;
}
if (codeObjectVer() < 5) {
aKernel->setUniformWorkGroupSize(useUniformWorkGroupSize);
}
aKernel->setUniformWorkGroupSize(useUniformWorkGroupSize);
aKernel->setInternalKernelFlag(internalKernel);
kernels()[kernelName] = aKernel;
}