AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a memory leak for rocJpegNegativeTests (#177)

Browse Source
This commit is contained in:
Aryan Salmanpour
2025-09-04 09:22:56 -07:00
committed by GitHub
parent b59a6e60a2
commit 6fc7c634f6
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/rocjpeg_negative_api_tests/rocjpeg_api_negative_tests.cpp
+20
View File
@@ -226,6 +226,11 @@ int RocJpegApiNegativeTests::TestInvalidCreate() {
std::cerr << "Expected ROCJPEG_STATUS_EXECUTION_FAILED but got " << rocJpegGetErrorName(rocjpeg_status) << std::endl;
return EXIT_FAILURE;
}
rocjpeg_status = rocJpegDestroy(rocjpeg_handle_);
if (rocjpeg_status != ROCJPEG_STATUS_SUCCESS) {
std::cerr << "Expected ROCJPEG_STATUS_SUCCESS but got " << rocJpegGetErrorName(rocjpeg_status) << std::endl;
return EXIT_FAILURE;
}
// Scenario 3: Pass valid pointer for handle but invalid device_id
device_id = 255; // Invalid device ID
@@ -234,6 +239,11 @@ int RocJpegApiNegativeTests::TestInvalidCreate() {
std::cerr << "Expected ROCJPEG_STATUS_INVALID_PARAMETER but got " << rocJpegGetErrorName(rocjpeg_status) << std::endl;
return EXIT_FAILURE;
}
rocjpeg_status = rocJpegDestroy(rocjpeg_handle_);
if (rocjpeg_status != ROCJPEG_STATUS_SUCCESS) {
std::cerr << "Expected ROCJPEG_STATUS_SUCCESS but got " << rocJpegGetErrorName(rocjpeg_status) << std::endl;
return EXIT_FAILURE;
}
// Scenario 4: Pass valid pointer for handle but unsupported backend
device_id = 0;
@@ -242,6 +252,11 @@ int RocJpegApiNegativeTests::TestInvalidCreate() {
std::cerr << "Expected ROCJPEG_STATUS_NOT_IMPLEMENTED but got " << rocJpegGetErrorName(rocjpeg_status) << std::endl;
return EXIT_FAILURE;
}
rocjpeg_status = rocJpegDestroy(rocjpeg_handle_);
if (rocjpeg_status != ROCJPEG_STATUS_SUCCESS) {
std::cerr << "Expected ROCJPEG_STATUS_SUCCESS but got " << rocJpegGetErrorName(rocjpeg_status) << std::endl;
return EXIT_FAILURE;
}
// Scenario 5: Use an unsupported backend
RocJpegBackend backend = static_cast<RocJpegBackend>(-1);
@@ -250,6 +265,11 @@ int RocJpegApiNegativeTests::TestInvalidCreate() {
std::cerr << "Expected ROCJPEG_STATUS_INVALID_PARAMETER but got " << rocJpegGetErrorName(rocjpeg_status) << std::endl;
return EXIT_FAILURE;
}
rocjpeg_status = rocJpegDestroy(rocjpeg_handle_);
if (rocjpeg_status != ROCJPEG_STATUS_SUCCESS) {
std::cerr << "Expected ROCJPEG_STATUS_SUCCESS but got " << rocJpegGetErrorName(rocjpeg_status) << std::endl;
return EXIT_FAILURE;
}
// Create a valid rocJPEG handle - This step ensures a valid rocjpeg_handle_ is available for subsequent negative testing of other rocJPEG APIs.
rocjpeg_status = rocJpegCreate(ROCJPEG_BACKEND_HARDWARE, device_id, &rocjpeg_handle_);