AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rocrtst: Remove extra clear_code_object() calls

Browse Source 
A patch was made in gfx940 npi branch to move the kernel object file
loading to outside the rocrtstNeg.Queue_Validation_* main queue creation
and submission loops, and added a clear_code_object() after the loop.

Another patch was made to the non-npi branch which adds a
clear_code_object() inside the loop. When the npi branch patch was
merged, this was causing the code object to be cleared at the end of
the first loop. Remove these clear_code_object() calls.

Signed-off-by: Graham Sider <Graham.Sider@amd.com>
Change-Id: Id4188e78411e81c5071bf715c1f02491f571ab79


[ROCm/ROCR-Runtime commit: dbe2a82e35]
This commit is contained in:
Graham Sider
2023-06-01 12:00:23 -04:00
committed by David Yat Sin
parent 381ea164ba
commit 74f9ba24e0
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rocr-runtime/rocrtst/suites/negative/queue_validation.cc
-5
View File
@@ -240,7 +240,6 @@ void QueueValidation::QueueValidationForInvalidDimension(hsa_agent_t cpuAgent,
ASSERT_EQ(completion, 1);
hsa_signal_store_relaxed(aql().completion_signal, 1);
clear_code_object();
}
sleep(1);
for (ii = 0; ii < kMaxQueue; ++ii) {
@@ -328,7 +327,6 @@ void QueueValidation::QueueValidationInvalidGroupMemory(hsa_agent_t cpuAgent,
ASSERT_EQ(completion, 1);
hsa_signal_store_relaxed(aql().completion_signal, 1);
clear_code_object();
}
sleep(1);
for (ii = 0; ii < kMaxQueue; ++ii) {
@@ -414,7 +412,6 @@ void QueueValidation::QueueValidationForInvalidKernelObject(hsa_agent_t cpuAgent
ASSERT_EQ(completion, 1);
hsa_signal_store_relaxed(aql().completion_signal, 1);
clear_code_object();
}
sleep(1);
for (ii = 0; ii < kMaxQueue; ++ii) {
@@ -494,7 +491,6 @@ void QueueValidation::QueueValidationForInvalidPacket(hsa_agent_t cpuAgent,
ASSERT_EQ(completion, 1);
hsa_signal_store_relaxed(aql().completion_signal, 1);
clear_code_object();
}
sleep(1);
for (ii = 0; ii < kMaxQueue; ++ii) {
@@ -585,7 +581,6 @@ void QueueValidation::QueueValidationForInvalidWorkGroupSize(hsa_agent_t cpuAgen
hsa_signal_store_relaxed(aql().completion_signal, 1);
if (queue[ii]) { hsa_queue_destroy(queue[ii]); }
clear_code_object();
}
}
sleep(1);