AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hsakmt: Only set exec flag when requested

Browse Source 
Previous code would blindly set executable bit on all allocations.

Change-Id: Id1154f08f6ba21c633905fd46b06053994d6f3cc
This commit is contained in:
Joseph Greathouse
2024-08-29 13:56:16 +00:00
committed by David Yat Sin
parent 8fd1b14a42
commit 75143555fa
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libhsakmt/src/fmm.c
+2 -5
View File
@@ -1385,11 +1385,8 @@ static uint32_t fmm_translate_hsa_to_ioc_flags(HsaMemFlags flags)
KFD_IOC_ALLOC_MEM_FLAGS_UNCACHED);
if (!flags.ui32.ReadOnly)
ioc_flags |= KFD_IOC_ALLOC_MEM_FLAGS_WRITABLE;
/* TODO: Since, ROCr interfaces doesn't allow caller to set page
* permissions, mark all user allocations with exec permission.
* Check for flags.ui32.ExecuteAccess once ROCr is ready.
*/
ioc_flags |= KFD_IOC_ALLOC_MEM_FLAGS_EXECUTABLE;
if (flags.ui32.ExecuteAccess)
ioc_flags |= KFD_IOC_ALLOC_MEM_FLAGS_EXECUTABLE;
return ioc_flags;
}