AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-435702 - the functions in bf16 header need to be static

Browse Source 
If the compiler decides not to inline these functions, we might break ODR (one definition rule) due to this file being included in multiple files and being linked together

Change-Id: Iacbfdabb53f5b4e5db8c690b23f3730ec9af16c0
This commit is contained in:
Jatin Chaudhary
2023-12-04 17:21:39 +00:00
committed by Jatin Jaikishan Chaudhary
parent 7febad13be
commit 77c581a3eb
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hipamd/include/hip/amd_detail/amd_hip_bf16.h
+2 -2
View File
@@ -94,12 +94,12 @@
#include "math_fwd.h" // ocml device functions
#if defined(__HIPCC_RTC__)
#define __HOST_DEVICE__ __device__
#define __HOST_DEVICE__ __device__ static
#else
#include <algorithm>
#include <climits>
#include <cmath>
#define __HOST_DEVICE__ __host__ __device__ inline
#define __HOST_DEVICE__ __host__ __device__ static inline
#endif
#define HIPRT_ONE_BF16 __float2bfloat16(1.0f)