Remove obsolete terminate() method

Change-Id: I66b4a74f17977f1af320f402402a2f1b602e9911


[ROCm/clr commit: 08b846ae12]

projects/clr/rocclr/device/device.hpp

@@ -1151,9 +1151,6 @@ class VirtualDevice : public amd::HeapObject {
   //! Destroy this virtual device.
   virtual ~VirtualDevice() {}
 
-  //! Prepare this virtual device for destruction.
-  virtual bool terminate() = 0;
-
   //! Return the physical device for this virtual device.
   const amd::Device& device() const { return device_(); }
 

projects/clr/rocclr/device/gpu/gpuvirtual.hpp

@@ -248,7 +248,6 @@ class VirtualGPU : public device::VirtualDevice, public CALGSLContext {
   void releaseKernel(CALimage calImage);
 
   void flush(amd::Command* list = NULL, bool wait = false);
-  bool terminate() { return true; }
 
   //! Returns GPU device object associated with this kernel
   const Device& dev() const { return gpuDevice_; }

projects/clr/rocclr/device/pal/palvirtual.hpp

@@ -351,7 +351,6 @@ class VirtualGPU : public device::VirtualDevice {
   void releaseMemory(GpuMemoryReference* mem);
 
   void flush(amd::Command* list = nullptr, bool wait = false);
-  bool terminate() { return true; }
 
   //! Returns GPU device object associated with this kernel
   const Device& dev() const { return gpuDevice_; }

projects/clr/rocclr/device/rocm/rocdevice.cpp

@@ -235,15 +235,9 @@ Device::~Device() {
   delete xferWrite_;
 
   // Destroy transfer queue
-  if (xferQueue_ && xferQueue_->terminate()) {
-    delete xferQueue_;
-    xferQueue_ = nullptr;
-  }
+  delete xferQueue_;
 
-  if (blitProgram_) {
-    delete blitProgram_;
-    blitProgram_ = nullptr;
-  }
+  delete blitProgram_;
 
   if (context_ != nullptr) {
     context_->release();

projects/clr/rocclr/device/rocm/rocvirtual.hpp

@@ -199,7 +199,6 @@ class VirtualGPU : public device::VirtualDevice {
   ~VirtualGPU();
 
   bool create();
-  bool terminate() { return true; }
   const Device& dev() const { return roc_device_; }
 
   void profilingBegin(amd::Command& command, bool drmProfiling = false);

projects/clr/rocclr/platform/commandqueue.hpp

@@ -167,9 +167,7 @@ class HostQueue : public CommandQueue {
       virtualDevice_ = queue->device().createVirtualDevice(queue);
       if (virtualDevice_ != NULL) {
         queue->loop(virtualDevice_);
-        if (virtualDevice_->terminate()) {
-          delete virtualDevice_;
-        }
+        delete virtualDevice_;
       } else {
         acceptingCommands_ = false;
         queue->flush();