AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deprecate HIP Markers (#1622)

Browse Source 
* Deprecate HIP markers

* Deprecate profiler start/stop
This commit is contained in:
Rahul Garg
2019-11-04 23:02:59 -08:00
committed by Maneesh Gupta
parent 7a3d592ed0
commit 8b3fce8069
3 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hipamd/CMakeLists.txt
+3
View File
@@ -184,7 +184,10 @@ if(NOT DEFINED COMPILE_HIP_ATP_MARKER)
set(COMPILE_HIP_ATP_MARKER 0)
else()
set(COMPILE_HIP_ATP_MARKER $ENV{COMPILE_HIP_ATP_MARKER})
message(WARNING "HIP Markers are deprecated, please use roctracer/rocTX marker APIs.")
endif()
else()
message(WARNING "HIP Markers are deprecated, please use roctracer/rocTX marker APIs.")
endif()
add_to_config(_buildInfo COMPILE_HIP_ATP_MARKER)
hipamd/include/hip/hcc_detail/hip_runtime_api.h
+2 -2
View File
@@ -2994,7 +2994,7 @@ hipError_t hipExtLaunchMultiKernelMultiDevice(hipLaunchParams* launchParamsList,
* When using this API, start the profiler with profiling disabled. (--startdisabled)
* @warning : hipProfilerStart API is under development.
*/
hipError_t hipProfilerStart();
hipError_t hipProfilerStart() __attribute__((deprecated("use roctracer/rocTX instead")));
/**
@@ -3002,7 +3002,7 @@ hipError_t hipProfilerStart();
* When using this API, start the profiler with profiling disabled. (--startdisabled)
* @warning : hipProfilerStop API is under development.
*/
hipError_t hipProfilerStop();
hipError_t hipProfilerStop() __attribute__((deprecated("use roctracer/rocTX instead")));
/**
hipamd/include/hip/hip_profile.h
+3
View File
@@ -23,11 +23,14 @@ THE SOFTWARE.
#ifndef HIP_INCLUDE_HIP_HIP_PROFILE_H
#define HIP_INCLUDE_HIP_HIP_PROFILE_H
#warning "HIP Profiling through markers is deprecated, please check roctrace/rocTX support."
#if not defined(ENABLE_HIP_PROFILE)
#define ENABLE_HIP_PROFILE 1
#endif
#if defined(__HIP_PLATFORM_HCC__) and (ENABLE_HIP_PROFILE == 1)
#warning "HIP Markers are deprecated and would be removed soon."
#include <CXLActivityLogger.h>
#define HIP_SCOPED_MARKER(markerName, group) \
amdtScopedMarker __scopedMarker(markerName, group, nullptr);