rocr: Fix compile warning when using clang

runtime/hsa-runtime/core/runtime/amd_aql_queue.cpp

@@ -98,8 +98,6 @@ AqlQueue::AqlQueue(core::SharedQueue* shared_queue, GpuAgent* agent, size_t req_
       priority_(HSA_QUEUE_PRIORITY_NORMAL),
       exception_signal_(nullptr) {
 
-  const core::Isa* isa = agent_->supported_isas()[0];
-
   // Queue size is a function of several restrictions.
   const uint32_t min_pkts = ComputeRingBufferMinPkts();
   const uint32_t max_pkts = ComputeRingBufferMaxPkts();

runtime/hsa-runtime/core/runtime/amd_blit_kernel.cpp

@@ -52,7 +52,6 @@
 
 namespace rocr {
 namespace AMD {
-static const uint16_t kInvalidPacketHeader = HSA_PACKET_TYPE_INVALID;
 
 static std::string& kBlitKernelSource() {
   static std::string kBlitKernelSource_(R"(
@@ -862,7 +861,7 @@ void BlitKernel::PopulateQueue(uint64_t index, uint64_t code_handle, void* args,
                                hsa_signal_t completion_signal) {
   assert(IsMultipleOf(args, 16));
 
-  hsa_kernel_dispatch_packet_t packet = {0};
+  hsa_kernel_dispatch_packet_t packet = { };
 
   static const uint16_t kDispatchPacketHeader =
       (HSA_PACKET_TYPE_KERNEL_DISPATCH << HSA_PACKET_HEADER_TYPE) |

runtime/hsa-runtime/core/runtime/amd_blit_sdma.cpp

@@ -287,7 +287,7 @@ hsa_status_t BlitSdma<RingIndexTy, HwIndexMonotonic, SizeToCountOffset, useGCR>:
   uint32_t num_poll_command = 0;
 
   // Cached copy of dep_signals[i]->LoadRelaxed
-  uint64_t dep_signals_value[dep_signals.size()];
+  uint64_t dep_signals_value[HSA_MAX_DEP_SIGNALS];
 
   for (size_t i = 0; i < dep_signals.size(); ++i) {
     // The signal is 64 bit value, and poll checks for 32 bit value.

runtime/hsa-runtime/core/runtime/amd_gpu_agent.cpp

@@ -800,7 +800,7 @@ void GpuAgent::InitDma() {
   // Dedicated compute queue for PC Sampling CP-DMA commands. We need a dedicated queue that runs at
   // highest priority because we do not want the CP-DMA commands to be delayed/blocked due to
   // other dispatches/barriers that could be in the other AQL queues.
-  queues_[QueuePCSampling].reset([queue_lambda, this]() { return queue_lambda(HSA_QUEUE_PRIORITY_MAXIMUM); });
+  queues_[QueuePCSampling].reset([queue_lambda]() { return queue_lambda(HSA_QUEUE_PRIORITY_MAXIMUM); });
 
   // Decide which engine to use for blits.
   auto blit_lambda = [this](bool use_xgmi, lazy_ptr<core::Queue>& queue, bool isHostToDev, uint32_t rec_eng) {