AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Updated tests based on NCCL 2.27.3-1 sync (#1892)

Browse Source
This commit is contained in:
Atul Kulkarni
2025-09-18 09:56:09 -05:00
committed by GitHub
parent 0cc896910e
commit 9839d1c7c8
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/EnqueueTests.cpp
+2 -2
View File
@@ -59,8 +59,8 @@ protected:
comm->workFifoBytes = 1024; // Power of 2
comm->workFifoBuf = nullptr;
comm->workFifoBufDev = nullptr;
comm->workFifoConsumed = nullptr;
comm->workFifoConsumedLeast = 0;
comm->workFifoConsumed = 0;
comm->workFifoProducedLastRecorded = 0;
comm->workFifoProduced = 0;
// Initialize planner
test/P2pTests.cpp
+5 -5
View File
@@ -1050,7 +1050,7 @@ TEST_F(P2pTests, P2pCanConnectWithIntermediateRankForkTest) {
}
TEST_F(P2pTests, IpcRegisterBufferFailures) {
const size_t TEST_BUFFER_ELEMENTS = 32;
struct ncclComm comm;
struct ncclTopoSystem system;
setupCommAndPeers(&comm, &system, gethostid(), 0, 0, 0, true);
@@ -1061,13 +1061,13 @@ TEST_F(P2pTests, IpcRegisterBufferFailures) {
void *dptr = nullptr;
ASSERT_EQ(hipSetDevice(0), hipSuccess);
hipError_t err = hipMalloc(&dptr, 32 * sizeof(float));
hipError_t err = hipMalloc(&dptr, TEST_BUFFER_ELEMENTS * sizeof(float));
ASSERT_EQ(err, hipSuccess);
struct ncclReg regRecord;
memset(&regRecord, 0, sizeof(regRecord));
regRecord.addr = (uintptr_t)dptr;
regRecord.pages = 1;
regRecord.begAddr = (uintptr_t)dptr;
regRecord.endAddr = regRecord.begAddr + (TEST_BUFFER_ELEMENTS * sizeof(float)); // Calculate end address based on size
for (int i = 0; i < 2; ++i)
regRecord.ipcInfos[i] = nullptr;
@@ -1080,7 +1080,7 @@ TEST_F(P2pTests, IpcRegisterBufferFailures) {
// Test 1: HIP_POINTER_ATTRIBUTE_IS_LEGACY_HIP_IPC_CAPABLE is not supported
ncclResult_t result = ipcRegisterBuffer(
&comm, dptr, 32 * sizeof(float), peerRanks, 1, type, &regRecord,
&comm, dptr, TEST_BUFFER_ELEMENTS * sizeof(float), peerRanks, 1, type, &regRecord,
&regBufFlag, &offsetOut, &peerRmtAddrsOut, &isLegacyIpc);
EXPECT_EQ(result, ncclUnhandledCudaError);