AI/rocm-systems
2
0
Bifurcation 0
Code Tickets Demandes d'ajout Actions Paquets Projets Publications Wiki Activité

Remove active-set-based broadcast test from the functional tests suite

Parcourir la source
Cette révision appartient à :
avinashkethineedi
2024-10-29 16:18:46 +00:00
Parent abec29bd6a
révision 9a524046fe
5 fichiers modifiés avec 4 ajouts et 264 suppressions
Télécharger le Fichier Patch Télécharger le Fichier des Différences Développer tous les fichiers Réduire tous les fichiers
tests/functional_tests/broadcast_tester.cpp
-159
Voir le fichier
@@ -1,159 +0,0 @@
/******************************************************************************
* Copyright (c) 2024 Advanced Micro Devices, Inc. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to
* deal in the Software without restriction, including without limitation the
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
* sell copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
* IN THE SOFTWARE.
*****************************************************************************/
using namespace rocshmem;
/* Declare the template with a generic implementation */
template <typename T>
__device__ void wg_broadcast(roc_shmem_ctx_t ctx, T *dest, const T *source,
int nelem, int pe_root, int pe_start,
int log_pe_stride, int pe_size, long *p_sync) {
return;
}
/* Define templates to call ROC_SHMEM */
#define BROADCAST_DEF_GEN(T, TNAME) \
template <> \
__device__ void wg_broadcast<T>( \
roc_shmem_ctx_t ctx, T * dest, const T *source, int nelem, int pe_root, \
int pe_start, int log_pe_stride, int pe_size, long *p_sync) { \
roc_shmem_ctx_##TNAME##_wg_broadcast(ctx, dest, source, nelem, pe_root, \
pe_start, log_pe_stride, pe_size, \
p_sync); \
}
BROADCAST_DEF_GEN(float, float)
BROADCAST_DEF_GEN(double, double)
BROADCAST_DEF_GEN(char, char)
// BROADCAST_DEF_GEN(long double, longdouble)
BROADCAST_DEF_GEN(signed char, schar)
BROADCAST_DEF_GEN(short, short)
BROADCAST_DEF_GEN(int, int)
BROADCAST_DEF_GEN(long, long)
BROADCAST_DEF_GEN(long long, longlong)
BROADCAST_DEF_GEN(unsigned char, uchar)
BROADCAST_DEF_GEN(unsigned short, ushort)
BROADCAST_DEF_GEN(unsigned int, uint)
BROADCAST_DEF_GEN(unsigned long, ulong)
BROADCAST_DEF_GEN(unsigned long long, ulonglong)
/******************************************************************************
* DEVICE TEST KERNEL
*****************************************************************************/
template <typename T1>
__global__ void BroadcastTest(int loop, int skip, uint64_t *timer,
T1 *source_buf, T1 *dest_buf, long *pSync,
int size, ShmemContextType ctx_type) {
__shared__ roc_shmem_ctx_t ctx;
roc_shmem_wg_init();
roc_shmem_wg_ctx_create(ctx_type, &ctx);
int n_pes = roc_shmem_ctx_n_pes(ctx);
__syncthreads();
uint64_t start;
for (int i = 0; i < loop; i++) {
if (i == skip && hipThreadIdx_x == 0) {
start = roc_shmem_timer();
}
wg_broadcast<T1>(ctx,
dest_buf, // T* dest
source_buf, // const T* source
size, // int nelement
0, // int PE_root
0, // int PE_start
0, // int logPE_stride
n_pes, // int PE_size
pSync); // long *pSync
roc_shmem_ctx_wg_barrier_all(ctx);
}
__syncthreads();
if (hipThreadIdx_x == 0) {
timer[hipBlockIdx_x] = roc_shmem_timer() - start;
}
roc_shmem_wg_ctx_destroy(&ctx);
roc_shmem_wg_finalize();
}
/******************************************************************************
* HOST TESTER CLASS METHODS
*****************************************************************************/
template <typename T1>
BroadcastTester<T1>::BroadcastTester(
TesterArguments args, std::function<void(T1 &, T1 &)> f1,
std::function<std::pair<bool, std::string>(const T1 &)> f2)
: Tester(args), init_buf{f1}, verify_buf{f2} {
source_buf = (T1 *)roc_shmem_malloc(args.max_msg_size * sizeof(T1));
dest_buf = (T1 *)roc_shmem_malloc(args.max_msg_size * sizeof(T1));
size_t p_sync_size = ROC_SHMEM_BCAST_SYNC_SIZE;
pSync = (long *)roc_shmem_malloc(p_sync_size * sizeof(long));
for (int i = 0; i < p_sync_size; i++) {
pSync[i] = ROC_SHMEM_SYNC_VALUE;
}
}
template <typename T1>
BroadcastTester<T1>::~BroadcastTester() {
roc_shmem_free(source_buf);
roc_shmem_free(dest_buf);
roc_shmem_free(pSync);
}
template <typename T1>
void BroadcastTester<T1>::launchKernel(dim3 gridSize, dim3 blockSize, int loop,
uint64_t size) {
size_t shared_bytes = 0;
hipLaunchKernelGGL(BroadcastTest<T1>, gridSize, blockSize, shared_bytes,
stream, loop, args.skip, timer, source_buf, dest_buf,
pSync, size, _shmem_context);
num_msgs = loop + args.skip;
num_timed_msgs = loop;
}
template <typename T1>
void BroadcastTester<T1>::resetBuffers(uint64_t size) {
for (int i = 0; i < args.max_msg_size; i++) {
init_buf(source_buf[i], dest_buf[i]);
}
}
template <typename T1>
void BroadcastTester<T1>::verifyResults(uint64_t size) {
for (int i = 0; i < size; i++) {
auto r = verify_buf(dest_buf[i]);
if (r.first == false) {
fprintf(stderr, "Data validation error at idx %d\n", i);
fprintf(stderr, "%s.\n", r.second.c_str());
exit(-1);
}
}
}
tests/functional_tests/broadcast_tester.hpp
-61
Voir le fichier
@@ -1,61 +0,0 @@
/******************************************************************************
* Copyright (c) 2024 Advanced Micro Devices, Inc. All rights reserved.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to
* deal in the Software without restriction, including without limitation the
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
* sell copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
* IN THE SOFTWARE.
*****************************************************************************/
#ifndef _BROADCAST_TESTER_HPP_
#define _BROADCAST_TESTER_HPP_
#include <functional>
#include <utility>
#include "tester.hpp"
/******************************************************************************
* HOST TESTER CLASS
*****************************************************************************/
template <typename T1>
class BroadcastTester : public Tester {
public:
explicit BroadcastTester(
TesterArguments args, std::function<void(T1 &, T1 &)> f1,
std::function<std::pair<bool, std::string>(const T1 &)> f2);
virtual ~BroadcastTester();
protected:
virtual void resetBuffers(uint64_t size) override;
virtual void launchKernel(dim3 gridSize, dim3 blockSize, int loop,
uint64_t size) override;
virtual void verifyResults(uint64_t size) override;
T1 *source_buf;
T1 *dest_buf;
long *pSync;
private:
std::function<void(T1 &, T1 &)> init_buf;
std::function<std::pair<bool, std::string>(const T1 &)> verify_buf;
};
#include "broadcast_tester.cpp"
#endif
tests/functional_tests/tester.cpp
-39
Voir le fichier
@@ -35,7 +35,6 @@
#include "amo_extended_tester.hpp"
#include "amo_standard_tester.hpp"
#include "barrier_all_tester.hpp"
#include "broadcast_tester.hpp"
#include "empty_tester.hpp"
#include "extended_primitives.hpp"
#include "fcollect_tester.hpp"
@@ -155,43 +154,6 @@ std::vector<Tester*> Tester::create(TesterArguments args) {
std::to_string(n_pes));
}));
return testers;
case BroadcastTestType:
if (rank == 0) {
std::cout << "Broadcast Test ###" << std::endl;
}
testers.push_back(new BroadcastTester<long>(
args,
[](long& f1, long& f2) {
f1 = 1;
f2 = 2;
},
[rank](long v) {
long expected_val;
/**
* The verification routine here requires that the
* PE_root value is 0 which denotes that the
* sending processing element is rank 0.
*
* The difference in expected values arises from
* the specification for broadcast where the
* PE_root processing element does not copy the
* contents from its own source to dest during
* the broadcast.
*/
if (rank == 0) {
expected_val = 2;
} else {
expected_val = 1;
}
return (v == expected_val)
? std::make_pair(true, "")
: std::make_pair(
false, "Rank " + std::to_string(rank) + ", Got " +
std::to_string(v) + ", Expect " +
std::to_string(expected_val));
}));
return testers;
case TeamBroadcastTestType:
if (rank == 0) {
std::cout << "Team Broadcast Test ###" << std::endl;
@@ -571,7 +533,6 @@ bool Tester::peLaunchesKernel() {
* Some test types are active on both sides.
*/
is_launcher = is_launcher || (_type == TeamReductionTestType) ||
(_type == BroadcastTestType) ||
(_type == TeamBroadcastTestType) ||
(_type == AllToAllTestType) || (_type == FCollectTestType) ||
(_type == PingPongTestType) || (_type == BarrierAllTestType) ||
tests/functional_tests/tester.hpp
+1 -1
Voir le fichier
@@ -52,7 +52,7 @@ enum TestType {
BarrierAllTestType = 17,
SyncAllTestType = 18,
SyncTestType = 19,
BroadcastTestType = 20,
// BroadcastTestType = 20,
CollectTestType = 21,
FCollectTestType = 22,
AllToAllTestType = 23,
tests/functional_tests/tester_arguments.cpp
+3 -4
Voir le fichier
@@ -137,10 +137,9 @@ void TesterArguments::get_rocshmem_arguments() {
TestType type = (TestType)algorithm;
if ((type != BarrierAllTestType) && (type != SyncAllTestType) &&
(type != SyncTestType) && (type != BroadcastTestType) &&
(type != AllToAllTestType) && (type != FCollectTestType) &&
(type != TeamReductionTestType) && (type != TeamBroadcastTestType) &&
(type != PingAllTestType)) {
(type != SyncTestType) && (type != AllToAllTestType) &&
(type != FCollectTestType) && (type != TeamReductionTestType) &&
(type != TeamBroadcastTestType) && (type != PingAllTestType)) {
if (numprocs != 2) {
if (myid == 0) {
std::cerr << "This test requires exactly two processes, we have "