AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent stack buffer overflow

Browse Source 
readlink() does not append a null byte to buffer. Initialize the
tpath to prevent stack buffer overflow.

Change-Id: I17895dc3576b080a0c35bd0528a5b83223ec1c1b


[ROCm/rocm_smi_lib commit: 4b65b0307f]
This commit is contained in:
Bill(Shuzhou) Liu
2022-02-28 15:29:23 -05:00
committed by Shuzhou Liu
parent 913986f721
commit 9b2017de0c
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rocm-smi-lib/src/rocm_smi_main.cc
+1
View File
@@ -183,6 +183,7 @@ static uint32_t ConstructBDFID(std::string path, uint64_t *bdfid) {
assert(bdfid != nullptr);
char tpath[256];
ssize_t ret;
memset(tpath,0,256);
ret = readlink(path.c_str(), tpath, 256);