2
0

Per review comments

Change-Id: I44585a6dcf3c4f0ce10f0e895270c113790e0652


[ROCm/ROCR-Runtime commit: 935c1b0ba9]
Este cometimento está contido em:
Ramesh Errabolu
2016-11-28 12:02:08 -06:00
ascendente e3d8eac639
cometimento a4c8e0fdca
2 ficheiros modificados com 8 adições e 6 eliminações
@@ -399,8 +399,8 @@ public:
hsa_ven_amd_loader_segment_descriptor_t *segment_descriptors,
size_t *num_segment_descriptors) = 0;
/// @brief Finds the handle of @p executable to which the device
/// address belongs. Return NULL handle if device address is invalid
/// @brief Finds the handle of executable to which @p device_address
/// belongs. Return NULL handle if device address is invalid.
virtual hsa_executable_t FindExecutable(uint64_t device_address) = 0;
/// @brief Returns host address given @p device_address. If @p device_address
@@ -226,14 +226,16 @@ hsa_status_t HSA_API hsa_ven_amd_loader_query_segment_descriptors(
/**
* @brief Obtains the handle of executable to which the device address belongs.
* This method should not be used to obtain executable handle by using a host
* address.
*
* @details This method should not be used to obtain executable handle by using
* a host address. The executable returned is expected to be alive until its
* destroyed by the user.
*
* @retval HSA_STATUS_SUCCESS Function is executed successfully.
*
* @retval HSA_STATUS_ERROR_NOT_INITIALIZED Runtime is not initialized.
*
* @retval HSA_STATUS_ERROR_INVALID_ARGUMENT the input is invalid or there
* @retval HSA_STATUS_ERROR_INVALID_ARGUMENT The input is invalid or there
* is no exectuable found for this kernel code object.
*/
hsa_status_t hsa_ven_amd_loader_query_executable(
@@ -256,7 +258,7 @@ typedef struct hsa_ven_amd_loader_1_00_pfn_s {
hsa_status_t (*hsa_ven_amd_loader_query_segment_descriptors)(
hsa_ven_amd_loader_segment_descriptor_t *segment_descriptors,
size_t *num_segment_descriptors);
hsa_status_t (*hsa_ven_amd_loader_query_executable)(
const void *device_address,
hsa_executable_t *executable);