Change-Id: Ib8d8da4c3897d157aeb26eb2e99718d66fd260b1


[ROCm/hip commit: b1d8f9d00d]
Αυτή η υποβολή περιλαμβάνεται σε:
Ben Sander
2016-08-08 13:12:22 -05:00
γονέας e8757f8154
υποβολή a671758882
@@ -94,10 +94,13 @@ Differences or limitations of HIP APIs as compared to CUDA APIs should be clearl
- Code Indentation:
- Tabs should be expanded to spaces.
- Use 4 spaces indendation.
- Capitilziation and Separators:
- Capitaliziation and Naming
- Prefer camelCase for HIP interfaces and internal symbols. Note HCC uses _ for separator.
This guideline is not yet consistently followed in HIP code - eventual compliance is aspirational.
- { placement
- Member variables should begin with a leading "_". This allows them to be easily distinguished from other variables or functions.
- {} placement
- For functions, the opening { should be placed on a new line.
- For if/else blocks, the opening { is placed on same line as the if/else. Use a space to separate {/" from if/else. Example
'''
@@ -109,10 +112,10 @@ Differences or limitations of HIP APIs as compared to CUDA APIs should be clearl
'''
- Single-line if statement should still use {/} pair (even though C++ does not require).
- Miscellaneous
- All references in function parameter lists should be const.
- "ihip" = internal hip structures. These should not be exposed through the HIP API.
- Keyword TODO refers to a note that should be addressed in long-term. Could be style issue, software architecture, or known bugs.
- FIXME refers to a short-term bug that needs to be addressed.
- All references in function parameter lists should be const.
- "ihip" = internal hip structures. These should not be exposed through the HIP API.
- Keyword TODO refers to a note that should be addressed in long-term. Could be style issue, software architecture, or known bugs.
- FIXME refers to a short-term bug that needs to be addressed.
#### Presubmit Testing: