Update error codes for hipGetDevice for doxygen and move up null check (#1668)

* [docs] Update error codes for hipGetDevice

* Move up out ptr check

include/hip/hcc_detail/hip_runtime_api.h

@@ -391,7 +391,7 @@ hipError_t hipSetDevice(int deviceId);
  * This device is used implicitly for HIP runtime APIs called by this thread.
  * hipGetDevice returns in * @p device the default device for the calling host thread.
  *
- * @returns #hipSuccess
+ * @returns #hipSuccess, #hipErrorInvalidDevice, #hipErrorInvalidValue
  *
  * @see hipSetDevice, hipGetDevicesizeBytes
  */

src/hip_device.cpp

@@ -33,18 +33,16 @@ hipError_t hipGetDevice(int* deviceId) {
     HIP_INIT_API(hipGetDevice, deviceId);
 
     hipError_t e = hipSuccess;
+    if (deviceId == nullptr)
+        return ihipLogStatus(hipErrorInvalidValue);
 
     auto ctx = ihipGetTlsDefaultCtx();
 
-    if (deviceId != nullptr) {
-        if (ctx == nullptr) {
-            e = hipErrorInvalidDevice;  // TODO, check error code.
-            *deviceId = -1;
-        } else {
-            *deviceId = ctx->getDevice()->_deviceId;
-        }
+    if (ctx == nullptr) {
+        e = hipErrorInvalidDevice;  // TODO, check error code.
+        *deviceId = -1;
     } else {
-        e = hipErrorInvalidValue;
+        *deviceId = ctx->getDevice()->_deviceId;
     }
 
     return ihipLogStatus(e);