[cmake] Added target static_check for static code analysis

- Added static code analysis using cppcheck
- Fixed couple of warnings reported by cppcheck

Change-Id: Ie3b9b06e95ada322e7dc2ce3d6b91831e870198d


[ROCm/clr commit: 379cbfedcf]

projects/clr/hipamd/CMakeLists.txt

@@ -361,6 +361,12 @@ if(POLICY CMP0037)
     cmake_policy(POP)
 endif()
 
+#############################
+# Code analysis
+#############################
+# Target: static_check
+add_custom_target(static_check COMMAND cppcheck --force --quiet --enable=warning,performance,portability,information,missingInclude src include -I /opt/rocm/include/hcc -I /opt/rocm/include --suppress=*:/opt/rocm/include/hcc/hc.hpp WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR})
+
 #############################
 # Testing steps
 #############################
@@ -388,5 +394,4 @@ else()
     message(STATUS "Testing targets will not be available. To enable them please ensure that the HIP installation directory is writeable. Use -DCMAKE_INSTALL_PREFIX to specify a suitable location")
 endif()
 
-
 # vim: ts=4:sw=4:expandtab:smartindent

projects/clr/hipamd/src/hip_fp16.cpp

@@ -448,7 +448,7 @@ __device__  __half2 __lowhigh2highlow(const __half2 a) {
 
 __device__  __half2 __lows2half2(const __half2 a, const __half2 b) {
   __half2 c;
-  c.y = a.x;
+  c.x = a.x;
   c.y = b.x;
   return c;
 }

projects/clr/hipamd/src/macro_based_grid_launch.inl

@@ -89,9 +89,8 @@ namespace hip_impl
         stream->lockclose_postKernelCommand(kernel_name, acc_v);
 
         delete static_cast<L*>(locked_stream);
-        locked_stream = nullptr;
         if(HIP_PROFILE_API) {
             MARKER_END();
         }
     }
-}
+}