AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed duplicate keys in analysis_configs yamls (#707)

Browse Source 
* fixed duplicate keys in analysis_configs yamls

* Fix: removed TODO comment

Signed-off-by: James Siddeley <james.siddeley@amd.com>

---------

Signed-off-by: James Siddeley <james.siddeley@amd.com>

[ROCm/rocprofiler-compute commit: 09b6ef4508]
This commit is contained in:
jamessiddeley-amd
2025-05-20 13:12:46 -04:00
committed by GitHub
parent 4899cfa160
commit ba61cc36f5
3 changed files with 2 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/rocprofiler-compute/src/rocprof_compute_soc/analysis_configs/gfx906/1000_compute-unit-instruction-mix.yaml
+2 -8
View File
@@ -218,12 +218,6 @@ Panel Config:
max: MAX((TA_BUFFER_WAVEFRONTS_sum / $denom))
unit: (instr + $normUnit)
tips:
Spill/Stack Coalesceable Instr:
avg: None # No perf counter
min: None # No perf counter
max: None # No perf counter
unit: (instr + $normUnit)
tips:
Spill/Stack Read:
avg: AVG((TA_BUFFER_READ_WAVEFRONTS_sum / $denom))
min: MIN((TA_BUFFER_READ_WAVEFRONTS_sum / $denom))
@@ -290,10 +284,10 @@ Panel Config:
max: None # No HW module
unit: (instr + $normUnit)
tips:
# TODO: Fix baseline comparision logic to handle non existent metrics, then
# TODO: Fix baseline comparision logic to handle non existent metrics, then
MFMA-F6F4:
avg: None
min: None
max: None
unit: (instr + $normUnit)
tips:
tips:
projects/rocprofiler-compute/src/rocprof_compute_soc/analysis_configs/gfx940/1000_compute-unit-instruction-mix.yaml
-2
View File
@@ -281,11 +281,9 @@ Panel Config:
min: MIN((SQ_INSTS_VALU_MFMA_F64 / $denom))
max: MAX((SQ_INSTS_VALU_MFMA_F64 / $denom))
unit: (instr + $normUnit)
# TODO: Fix baseline comparision logic to handle non existent metrics, then
MFMA-F6F4:
avg: None
min: None
max: None
unit: (instr + $normUnit)
tips:
tips:
projects/rocprofiler-compute/src/rocprof_compute_soc/analysis_configs/gfx950/1700_L2_cache.yaml
-9
View File
@@ -52,15 +52,6 @@ Panel Config:
unit: Unit
tips: Tips
metric:
Read BW:
avg: AVG((((TCC_EA0_RDREQ_32B_sum * 32) + ((TCC_EA0_RDREQ_sum - TCC_EA0_RDREQ_32B_sum)
* 64)) / $denom))
min: MIN((((TCC_EA0_RDREQ_32B_sum * 32) + ((TCC_EA0_RDREQ_sum - TCC_EA0_RDREQ_32B_sum)
* 64)) / $denom))
max: MAX((((TCC_EA0_RDREQ_32B_sum * 32) + ((TCC_EA0_RDREQ_sum - TCC_EA0_RDREQ_32B_sum)
* 64)) / $denom))
unit: (Bytes + $normUnit)
tips:
Read BW:
avg: AVG((((TCC_EA0_RDREQ_32B_sum * 32) + (TCC_EA0_RDREQ_64B_sum * 64) + (TCC_EA0_RDREQ_128B_sum * 128)) / $denom))
min: MIN((((TCC_EA0_RDREQ_32B_sum * 32) + (TCC_EA0_RDREQ_64B_sum * 64) + (TCC_EA0_RDREQ_128B_sum * 128)) / $denom))