AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only set minNchannels if we are actually using MSCCL, checked using comm->mscclCompatible. (#1337)

Browse Source
This commit is contained in:
corey-derochie-amd
2024-10-08 10:20:55 -06:00
committed by GitHub
parent bc519fd733
commit c11f6b1531
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/graph/connect.cc
+3 -1
View File
@@ -691,7 +691,9 @@ ncclResult_t ncclTopoPostset(struct ncclComm* comm, int* firstRanks, int* treePa
if (mscclEnabled() && (comm->topo->mscclEnabled || mscclForceEnabled())) {
int mscclNumChannelsRequired = maxNchannels;
mscclSchedulerInit(comm, &mscclNumChannelsRequired);
minNchannels = std::max(minNchannels, mscclNumChannelsRequired);
if (comm->mscclCompatible) {
minNchannels = std::max(minNchannels, mscclNumChannelsRequired);
}
}
// Honor NCCL_MIN_NRINGS/NCCL_MAX_NRINGS.