Only set minNchannels if we are actually using MSCCL, checked using comm->mscclCompatible. (#1337)

Tento commit je obsažen v:
corey-derochie-amd
2024-10-08 10:20:55 -06:00
odevzdal GitHub
rodič bc519fd733
revize c11f6b1531
+3 -1
Zobrazit soubor
@@ -691,7 +691,9 @@ ncclResult_t ncclTopoPostset(struct ncclComm* comm, int* firstRanks, int* treePa
if (mscclEnabled() && (comm->topo->mscclEnabled || mscclForceEnabled())) {
int mscclNumChannelsRequired = maxNchannels;
mscclSchedulerInit(comm, &mscclNumChannelsRequired);
minNchannels = std::max(minNchannels, mscclNumChannelsRequired);
if (comm->mscclCompatible) {
minNchannels = std::max(minNchannels, mscclNumChannelsRequired);
}
}
// Honor NCCL_MIN_NRINGS/NCCL_MAX_NRINGS.