AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-448279: Workaround for UB24 compiler errors

Browse Source 
Change-Id: I01e880502edac8e8b941d199e08bc8f1eded0a89


[ROCm/roctracer commit: 4bc8dbd029]
This commit is contained in:
Giovanni LB
2024-02-28 23:56:14 -03:00
parent 4afc8625e6
commit c53b6ff6f7
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/roctracer/src/roctracer/registration_table.h
+10 -8
View File
@@ -54,9 +54,15 @@ struct False {
// Generic callbacks table
template <typename T, uint32_t N, typename IsStopped = detail::False> class RegistrationTable {
public:
struct table_element_t {
std::atomic<bool> enabled{false};
mutable std::shared_mutex mutex;
T data;
};
template <typename... Args> void Register(uint32_t operation_id, Args... args) {
assert(operation_id < N && "operation_id is out of range");
auto& entry = table_[operation_id];
table_element_t& entry = table_.at(operation_id);
std::unique_lock lock(entry.mutex);
if (!entry.enabled.exchange(true, std::memory_order_relaxed))
registered_count_.fetch_add(1, std::memory_order_relaxed);
@@ -65,7 +71,7 @@ template <typename T, uint32_t N, typename IsStopped = detail::False> class Regi
void Unregister(uint32_t operation_id) {
assert(operation_id < N && "id is out of range");
auto& entry = table_[operation_id];
table_element_t& entry = table_.at(operation_id);
std::unique_lock lock(entry.mutex);
if (entry.enabled.exchange(false, std::memory_order_relaxed))
registered_count_.fetch_sub(1, std::memory_order_relaxed);
@@ -73,7 +79,7 @@ template <typename T, uint32_t N, typename IsStopped = detail::False> class Regi
std::optional<T> Get(uint32_t operation_id) const {
assert(operation_id < N && "id is out of range");
auto& entry = table_[operation_id];
const table_element_t& entry = table_.at(operation_id);
if (!entry.enabled.load(std::memory_order_relaxed) || IsStopped{}()) return std::nullopt;
std::shared_lock lock(entry.mutex);
return entry.enabled.load(std::memory_order_relaxed) ? std::make_optional(entry.data)
@@ -84,11 +90,7 @@ template <typename T, uint32_t N, typename IsStopped = detail::False> class Regi
private:
std::atomic<size_t> registered_count_{0};
struct {
std::atomic<bool> enabled{false};
mutable std::shared_mutex mutex;
T data;
} table_[N]{};
std::array<table_element_t, N> table_{};
};
#if IGNORE_GCC_ARRAY_BOUNDS_ERROR