Fix miscellaneous warnings flagged by Clang

Change-Id: I85a45cb3b44e4379b31bcc56af061fd1571f2af5


[ROCm/ROCR-Runtime commit: c30c25bd30]

projects/rocr-runtime/runtime/hsa-runtime/loader/executable.hpp

@@ -112,7 +112,7 @@ protected:
     , is_definition(_is_definition)
     , address(_address) {}
 
-  virtual bool GetInfo(hsa_symbol_info32_t symbol_info, void *value);
+  virtual bool GetInfo(hsa_symbol_info32_t symbol_info, void *value) override;
 
 private:
   SymbolImpl(const SymbolImpl &s);
@@ -361,23 +361,23 @@ public:
 
   ~ExecutableImpl();
 
-  hsa_status_t GetInfo(hsa_executable_info_t executable_info, void *value);
+  hsa_status_t GetInfo(hsa_executable_info_t executable_info, void *value) override;
 
   hsa_status_t DefineProgramExternalVariable(
-    const char *name, void *address);
+    const char *name, void *address) override;
 
   hsa_status_t DefineAgentExternalVariable(
     const char *name,
     hsa_agent_t agent,
     hsa_variable_segment_t segment,
-    void *address);
+    void *address) override;
 
   hsa_status_t LoadCodeObject(
     hsa_agent_t agent,
     hsa_code_object_t code_object,
     const char *options,
     hsa_loaded_code_object_t *loaded_code_object,
-    bool load_legacy = true);
+    bool load_legacy = true) override;
 
   hsa_status_t LoadCodeObject(
     hsa_agent_t agent,
@@ -385,11 +385,11 @@ public:
     size_t code_object_size,
     const char *options,
     hsa_loaded_code_object_t *loaded_code_object,
-    bool load_legacy = true);
+    bool load_legacy = true) override;
 
-  hsa_status_t Freeze(const char *options);
+  hsa_status_t Freeze(const char *options) override;
 
-  hsa_status_t Validate(uint32_t *result) {
+  hsa_status_t Validate(uint32_t *result) override {
     amd::hsa::common::ReaderLockGuard<amd::hsa::common::ReaderWriterLock> reader_lock(rw_lock_);
     assert(result);
     *result = 0;
@@ -405,7 +405,7 @@ public:
     const hsa_agent_t *agent) override;
 
   hsa_status_t IterateSymbols(
-    iterate_symbols_f callback, void *data);
+    iterate_symbols_f callback, void *data) override;
 
   /// @since hsa v1.1.
   hsa_status_t IterateAgentSymbols(
@@ -427,7 +427,7 @@ public:
     hsa_status_t (*callback)(
       hsa_loaded_code_object_t loaded_code_object,
       void *data),
-    void *data);
+    void *data) override;
 
   size_t GetNumSegmentDescriptors() override;
 
@@ -501,7 +501,7 @@ public:
   AmdHsaCodeLoader(Context* context_)
     : context(context_) { assert(context); }
 
-  Context* GetContext() const { return context; }
+  Context* GetContext() const override { return context; }
 
   Executable* CreateExecutable(
       hsa_profile_t profile,

projects/rocr-runtime/runtime/hsa-runtime/loader/loaders.hpp

@@ -83,25 +83,25 @@ namespace loader {
 
     bool SegmentFreeze(amdgpu_hsa_elf_segment_t segment, hsa_agent_t agent, void* seg, size_t size) override;
 
-    bool ImageExtensionSupported();
+    bool ImageExtensionSupported() override;
 
     hsa_status_t ImageCreate(
       hsa_agent_t agent,
       hsa_access_permission_t image_permission,
       const hsa_ext_image_descriptor_t *image_descriptor,
       const void *image_data,
-      hsa_ext_image_t *image_handle);
+      hsa_ext_image_t *image_handle) override;
 
     hsa_status_t ImageDestroy(
-      hsa_agent_t agent, hsa_ext_image_t image_handle);
+      hsa_agent_t agent, hsa_ext_image_t image_handle) override;
 
     hsa_status_t SamplerCreate(
       hsa_agent_t agent,
       const hsa_ext_sampler_descriptor_t *sampler_descriptor,
-      hsa_ext_sampler_t *sampler_handle);
+      hsa_ext_sampler_t *sampler_handle) override;
 
     hsa_status_t SamplerDestroy(
-      hsa_agent_t agent, hsa_ext_sampler_t sampler_handle);
+      hsa_agent_t agent, hsa_ext_sampler_t sampler_handle) override;
   };
 }
 }