Dedicated logging function for each log level
Signed-off-by: colramos-amd <colramos@amd.com>
[ROCm/rocprofiler-compute commit: 233905071c]
This commit is contained in:
colramos-amd
committed by
Karl W. Schulz
Karl W. Schulz
parent
39a9961060
commit
cfdf288cba
@@ -47,13 +47,27 @@ def demarcate(function):
|
||||
|
||||
return wrap_function
|
||||
|
||||
|
||||
def error(message):
|
||||
logging.error("")
|
||||
logging.error("[ERROR]: " + message)
|
||||
logging.error("")
|
||||
def console_error(*argv):
|
||||
if len(argv) > 1:
|
||||
logging.error(f"[{argv[0]}]: {argv[1]}")
|
||||
else:
|
||||
logging.error(f"{argv[0]}")
|
||||
sys.exit(1)
|
||||
|
||||
def console_log(*argv):
|
||||
if len(argv) > 1:
|
||||
logging.info(f"[{argv[0]}]: {argv[1]}")
|
||||
else:
|
||||
logging.info(f"{argv[0]}")
|
||||
|
||||
def console_debug(*argv):
|
||||
if len(argv) > 1:
|
||||
logging.debug(f"[{argv[0]}]: {argv[1]}")
|
||||
else:
|
||||
logging.debug(f"{argv[0]}")
|
||||
|
||||
def console_warning(msg:str):
|
||||
logging.warning(msg)
|
||||
|
||||
def trace_logger(message, *args, **kwargs):
|
||||
logging.log(logging.TRACE, message, *args, **kwargs)
|
||||
@@ -90,7 +104,7 @@ def get_version(omniperf_home) -> dict:
|
||||
with open(shaFile, "r") as file:
|
||||
SHA = file.read().replace("\n", "")
|
||||
except EnvironmentError:
|
||||
error("Cannot find VERSION.sha file at {}".format(shaFile))
|
||||
console_error("Cannot find VERSION.sha file at {}".format(shaFile))
|
||||
sys.exit(1)
|
||||
|
||||
MODE = "release"
|
||||
@@ -123,21 +137,17 @@ def detect_rocprof():
|
||||
|
||||
if not rocprof_path:
|
||||
rocprof_cmd = "rocprof"
|
||||
logging.warning(
|
||||
"Warning: Unable to resolve path to %s binary. Reverting to default."
|
||||
% rocprof_cmd
|
||||
)
|
||||
console_warning("Unable to resolve path to %s binary. Reverting to default." % rocprof_cmd)
|
||||
rocprof_path = shutil.which(rocprof_cmd)
|
||||
if not rocprof_path:
|
||||
error(
|
||||
"Please verify installation or set ROCPROF environment variable with full path."
|
||||
)
|
||||
console_error("Please verify installation or set ROCPROF environment variable with full path.")
|
||||
else:
|
||||
# Resolve any sym links in file path
|
||||
rocprof_path = os.path.realpath(rocprof_path.rstrip("\n"))
|
||||
logging.info("ROC Profiler: " + str(rocprof_path))
|
||||
return rocprof_cmd # TODO: Do we still need to return this? It's not being used in the function call
|
||||
|
||||
console_log(
|
||||
"ROC Profiler: " + str(rocprof_path)
|
||||
)
|
||||
return rocprof_cmd #TODO: Do we still need to return this? It's not being used in the function call
|
||||
|
||||
def capture_subprocess_output(subprocess_args, new_env=None):
|
||||
# Start subprocess
|
||||
@@ -201,7 +211,7 @@ def run_prof(fname, profiler_options, workload_dir, mspec):
|
||||
|
||||
fbase = os.path.splitext(os.path.basename(fname))[0]
|
||||
|
||||
logging.debug("pmc file: %s" % str(os.path.basename(fname)))
|
||||
console_debug("pmc file: %s" % str(os.path.basename(fname)))
|
||||
|
||||
# standard rocprof options
|
||||
default_options = ["-i", fname]
|
||||
@@ -231,7 +241,7 @@ def run_prof(fname, profiler_options, workload_dir, mspec):
|
||||
success, output = capture_subprocess_output([rocprof_cmd] + options)
|
||||
|
||||
if not success:
|
||||
error(output)
|
||||
console_error(output)
|
||||
|
||||
if new_env:
|
||||
# flatten tcc for applicable mi300 input
|
||||
@@ -277,7 +287,7 @@ def run_prof(fname, profiler_options, workload_dir, mspec):
|
||||
df.to_csv(workload_dir + "/" + fbase + ".csv", index=False)
|
||||
|
||||
# write rocprof output to logging
|
||||
logging.info(output)
|
||||
console_log(output)
|
||||
|
||||
|
||||
def replace_timestamps(workload_dir):
|
||||
@@ -292,10 +302,7 @@ def replace_timestamps(workload_dir):
|
||||
df_pmc_perf["End_Timestamp"] = df_stamps["End_Timestamp"]
|
||||
df_pmc_perf.to_csv(fname, index=False)
|
||||
else:
|
||||
warning = (
|
||||
"WARNING: Incomplete profiling data detected. Unable to update timestamps."
|
||||
)
|
||||
logging.warning(warning + "\n")
|
||||
console_warning("Incomplete profiling data detected. Unable to update timestamps.\n")
|
||||
|
||||
|
||||
def gen_sysinfo(
|
||||
@@ -337,9 +344,9 @@ def detect_roofline(mspec):
|
||||
logging._SysExcInfoType("Detected user-supplied binary")
|
||||
return {"rocm_ver": "override", "distro": "override", "path": rooflineBinary}
|
||||
else:
|
||||
logging.error("ROOFLINE ERROR: user-supplied path to binary not accessible")
|
||||
logging.error("--> ROOFLINE_BIN = %s\n" % target_binary)
|
||||
sys.exit(1)
|
||||
msg = ("[roofline] user-supplied path to binary not accessible")
|
||||
msg += ("--> ROOFLINE_BIN = %s\n" % target_binary)
|
||||
console_error(msg)
|
||||
elif rhel_distro == "platform:el8" or rhel_distro == "platform:el9":
|
||||
# Must be a valid RHEL machine
|
||||
distro = "platform:el8"
|
||||
@@ -355,10 +362,10 @@ def detect_roofline(mspec):
|
||||
# Must be a valid Ubuntu machine
|
||||
distro = ubuntu_distro
|
||||
else:
|
||||
logging.error(
|
||||
"ROOFLINE ERROR: Cannot find a valid binary for your operating system"
|
||||
console_error(
|
||||
"roofline",
|
||||
"Cannot find a valid binary for your operating system"
|
||||
)
|
||||
sys.exit(1)
|
||||
|
||||
target_binary = {"rocm_ver": rocm_ver, "distro": distro}
|
||||
return target_binary
|
||||
@@ -382,16 +389,18 @@ def run_rocscope(args, fname):
|
||||
]
|
||||
for i in args.remaining.split():
|
||||
rs_cmd.append(i)
|
||||
logging.info(rs_cmd)
|
||||
success, output = capture_subprocess_output(rs_cmd)
|
||||
console_log(rs_cmd)
|
||||
success, output = capture_subprocess_output(
|
||||
rs_cmd
|
||||
)
|
||||
if not success:
|
||||
logging.error(result.stderr.decode("ascii"))
|
||||
sys.exit(1)
|
||||
console_error(result.stderr.decode("ascii"))
|
||||
|
||||
|
||||
def mibench(args, mspec):
|
||||
"""Run roofline microbenchmark to generate peek BW and FLOP measurements."""
|
||||
logging.info("[roofline] No roofline data found. Generating...")
|
||||
console_log("roofline", "No roofline data found. Generating...")
|
||||
|
||||
distro_map = {"platform:el8": "rhel8", "15.3": "sle15sp3", "20.04": "ubuntu20_04"}
|
||||
|
||||
target_binary = detect_roofline(mspec)
|
||||
@@ -411,10 +420,10 @@ def mibench(args, mspec):
|
||||
|
||||
# Distro is valid but cant find rocm ver
|
||||
if not os.path.exists(path_to_binary):
|
||||
logging.error(
|
||||
"ROOFLINE ERROR: Unable to locate expected binary (%s)." % path_to_binary
|
||||
console_error(
|
||||
"roofline",
|
||||
"Unable to locate expected binary (%s)." % path_to_binary
|
||||
)
|
||||
sys.exit(1)
|
||||
|
||||
subprocess.run(
|
||||
[
|
||||
@@ -508,8 +517,7 @@ def get_hbm_stack_num(gpu_name, memory_partition):
|
||||
elif memory_partition.lower() == "nps8":
|
||||
return 1
|
||||
else:
|
||||
print("Invalid MI300A memory partition mode!")
|
||||
sys.exit()
|
||||
console_error("Invalid MI300A memory partition mode!")
|
||||
elif gpu_name.lower() == "mi300x_a0" or gpu_name.lower() == "mi300x_a1":
|
||||
if memory_partition.lower() == "nps1":
|
||||
return 8
|
||||
@@ -520,8 +528,7 @@ def get_hbm_stack_num(gpu_name, memory_partition):
|
||||
elif memory_partition.lower() == "nps8":
|
||||
return 1
|
||||
else:
|
||||
print("Invalid MI300X memory partition mode!")
|
||||
sys.exit()
|
||||
console_error("Invalid MI300X memory partition mode!")
|
||||
else:
|
||||
# Fixme: add proper numbers for other archs
|
||||
return -1
|
||||
@@ -551,10 +558,23 @@ def is_workload_empty(path):
|
||||
if os.path.isfile(pmc_perf_path):
|
||||
temp_df = pd.read_csv(pmc_perf_path)
|
||||
if temp_df.dropna().empty:
|
||||
error(
|
||||
"[profiling] Error. Found empty cells in %s.\nProfiling data could be corrupt."
|
||||
% pmc_perf_path
|
||||
console_error(
|
||||
"profiling"
|
||||
"Found empty cells in %s.\nProfiling data could be corrupt." % pmc_perf_path
|
||||
)
|
||||
|
||||
else:
|
||||
error("[profiling] Error. Cannot find pmc_perf.csv in %s" % path)
|
||||
console_error(
|
||||
"profiling",
|
||||
"Cannot find pmc_perf.csv in %s" % path
|
||||
)
|
||||
|
||||
def print_status(msg):
|
||||
print("\n")
|
||||
print("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~")
|
||||
print("\n")
|
||||
print(msg)
|
||||
print("\n")
|
||||
print("~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~")
|
||||
print("\n")
|
||||
|
||||
|
||||
Reference in New Issue
Block a user