AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

EXSWCPHIPT-121 - hipGetSetDeviceFlags tests (#2747)

Browse Source 
[ROCm/hip commit: 166173e12d]
This commit is contained in:
Finlay
2022-06-28 04:31:55 +01:00
committed by GitHub
parent cc7ae07901
commit d1445ff49a
3 changed files with 150 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/hip/tests/catch/unit/device/CMakeLists.txt
+3 -2
View File
@@ -13,11 +13,12 @@ set(TEST_SRC
hipGetDeviceCount.cc
hipGetDeviceProperties.cc
hipRuntimeGetVersion.cc
hipSetDeviceFlags.cc
hipGetSetDeviceFlags.cc
hipSetGetDevice.cc
hipDeviceGetUuid.cc
)
hip_add_exe_to_target(NAME DeviceTest
TEST_SRC ${TEST_SRC}
TEST_TARGET_NAME build_tests)
TEST_TARGET_NAME build_tests
COMPILE_OPTIONS -std=c++14)
projects/hip/tests/catch/unit/device/hipGetSetDeviceFlags.cc
+147
View File
@@ -0,0 +1,147 @@
/*
Copyright (c) 2022 Advanced Micro Devices, Inc. All rights reserved.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
*/
#include <hip_test_common.hh>
#include <iterator>
#include <vector>
#include <mutex>
#include <condition_variable>
/**
* Conformance test for checking functionality of
* hipError_t hipGetDeviceFlags(unsigned int* flags);
* hipError_t hipSetDeviceFlags(unsigned flags);
*
*
* hipGetDeviceFlags and hipSetDeviceFlags tests.
* Scenario1: Validates if hipGetDeviceFlags returns hipErrorInvalidValue for flags = nullptr.
* Scenario2: Validates if hipSetDeviceFlags returns hipErrorInvalidValue for invalid flags.
* Scenario3: Validates if flags returned by hipGetDeviceFlags are valid.
* Scenario4: Validates that flags set with hipSetDeviceFlags can be retrieved with
* hipGetDeviceFlags.
* Scenario5: Validates that flags set with hipSetDeviceFlags can be retrieved on a seperate thread
* with hipGetDeviceFlags.
*/
TEST_CASE("Unit_hipGetSetDeviceFlags_NullptrFlag") {
// Scenario1
HIP_CHECK_ERROR(hipGetDeviceFlags(nullptr), hipErrorInvalidValue);
}
TEST_CASE("Unit_hipGetSetDeviceFlags_InvalidFlag") {
#if HT_AMD
HipTest::HIP_SKIP_TEST("EXSWCPHIPT-115");
return;
#endif
// Scenario2
const unsigned int invalidFlag = GENERATE(0b011, // schedule flags should not overlap
0b101, // schedule flags should not overlap
0b110, // schedule flags should not overlap
0b111, // schedule flags should not overlap
0b100000, // out of bounds
0xFFFF);
CAPTURE(invalidFlag);
HIP_CHECK_ERROR(hipSetDeviceFlags(invalidFlag), hipErrorInvalidValue);
}
std::array<unsigned int, 16> getValidFlags() {
constexpr std::array<unsigned int, 4> scheduleFlags{hipDeviceScheduleAuto, hipDeviceScheduleSpin,
hipDeviceScheduleYield,
hipDeviceScheduleBlockingSync};
constexpr std::array<unsigned int, 2> hostMapFlags{0, hipDeviceMapHost};
constexpr std::array<unsigned int, 2> localMemResizeFlags{0, 0x10}; // FIXME EXSWCPHIPT-110
constexpr size_t size = scheduleFlags.size() * hostMapFlags.size() * localMemResizeFlags.size();
std::array<unsigned int, size> validFlags;
int i = 0;
for (auto sf : scheduleFlags) {
for (auto hf : hostMapFlags) {
for (auto lf : localMemResizeFlags) {
validFlags[i] = sf | hf | lf;
i += 1;
}
}
}
return validFlags;
}
TEST_CASE("Unit_hipGetSetDeviceFlags_ValidFlag") {
// Scenario3
auto validFlags = getValidFlags();
unsigned int flag = 0;
HIP_CHECK(hipGetDeviceFlags(&flag));
REQUIRE(std::find(std::begin(validFlags), std::end(validFlags), flag) != std::end(validFlags));
}
TEST_CASE("Unit_hipGetSetDeviceFlags_SetThenGet") {
// Scenario4
auto validFlags = getValidFlags();
auto devNo = GENERATE(range(0, HipTest::getDeviceCount()));
HIP_CHECK(hipSetDevice(devNo));
const unsigned int flag = GENERATE_COPY(from_range(std::begin(validFlags), std::end(validFlags)));
HIP_CHECK(hipSetDeviceFlags(flag));
unsigned int getFlag;
HIP_CHECK(hipGetDeviceFlags(&getFlag));
// flags other than hipDeviceSchedule* are ignore on the ROCm backend
#if HT_NVIDIA
// CUDA backend will sometimes set other flags
getFlag = getFlag & hipDeviceScheduleMask;
#endif
REQUIRE((flag & hipDeviceScheduleMask) == getFlag);
}
TEST_CASE("Unit_hipGetSetDeviceFlags_Threaded") {
// Scenario5
auto validFlags = getValidFlags();
auto devNo = GENERATE(range(0, HipTest::getDeviceCount()));
HIP_CHECK(hipSetDevice(devNo));
std::mutex mut;
std::condition_variable cv;
bool ready = false; // required to avoid spurious wakeups
const unsigned int flag = GENERATE_COPY(from_range(std::begin(validFlags), std::end(validFlags)));
std::thread test_thread([&mut, &ready, &cv, devNo, flag]() {
std::unique_lock<std::mutex> lock(mut);
cv.wait(lock, [&ready] { return ready; });
unsigned int getFlag;
HIP_CHECK_THREAD(hipSetDevice(devNo));
HIP_CHECK_THREAD(hipGetDeviceFlags(&getFlag));
// flags other than hipDeviceSchedule* are ignore on the ROCm backend
#if HT_NVIDIA
// CUDA backend will set other flags we aren't concerned about
getFlag = getFlag & hipDeviceScheduleMask;
#endif
REQUIRE_THREAD((flag & hipDeviceScheduleMask) == getFlag);
});
{
std::lock_guard<std::mutex> lock(mut);
HIP_CHECK(hipSetDeviceFlags(flag));
ready = true;
}
cv.notify_one();
test_thread.join();
HIP_CHECK_THREAD_FINALIZE();
}
projects/hip/tests/catch/unit/device/hipSetDeviceFlags.cc
-73
View File
@@ -1,73 +0,0 @@
/*
Copyright (c) 2021 Advanced Micro Devices, Inc. All rights reserved.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
*/
#include <hip_test_common.hh>
/*
* Conformance test for checking functionality of
* hipError_t hipGetDeviceFlags(unsigned int* flags);
* hipError_t hipSetDeviceFlags(unsigned flags);
*/
/**
* hipGetDeviceFlags and hipSetDeviceFlags tests.
* Scenario1: Validates if hipGetDeviceFlags returns hip error code for
* flags = nullptr.
* Scenario2: Validates if hipSetDeviceFlags returns hip error code for
* invalid flag.
* Scenario3: Validates if flags = hipDeviceScheduleSpin|hipDeviceScheduleYield
* |hipDeviceScheduleBlockingSync|hipDeviceScheduleAuto|hipDeviceMapHost
* |hipDeviceLmemResizeToMax returned by hipGetDeviceFlags.
*/
TEST_CASE("Unit_hipGetDeviceFlags_NegTst") {
// Scenario1
SECTION("flags is nullptr") {
REQUIRE_FALSE(hipSuccess == hipGetDeviceFlags(nullptr));
}
// Scenario2
SECTION("flags value is invalid") {
REQUIRE_FALSE(hipSuccess == hipSetDeviceFlags(0xffff));
}
}
TEST_CASE("Unit_hipGetDeviceFlags_FuncTst") {
unsigned flag = 0;
// Scenario3
SECTION("Check flag value") {
HIP_CHECK(hipGetDeviceFlags(&flag));
bool checkFlg = false;
checkFlg = ((flag != hipDeviceScheduleSpin) &&
(flag != hipDeviceScheduleYield) &&
(flag != hipDeviceScheduleBlockingSync) &&
(flag != hipDeviceScheduleAuto) &&
(flag != hipDeviceMapHost) &&
(flag != hipDeviceLmemResizeToMax));
REQUIRE_FALSE(checkFlg);
}
SECTION("Set flag value") {
auto devNo = GENERATE(range(0, HipTest::getDeviceCount()));
flag = 0;
HIP_CHECK(hipSetDevice(devNo));
auto bitmap = GENERATE(range(0, 4));
flag = 1 << bitmap;
HIP_CHECK(hipSetDeviceFlags(flag));
}
}