Fix out-of-bounds read in ncclStrToCpuset (#233)
The affinityStr string was not null-terminated but was passed to strlen(3).
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
[ROCm/rccl commit: 37e4f8729e]
Tento commit je obsažen v:
odevzdal
Sylvain Jeaugey
rodič
1071f54eeb
revize
d2f579ba8b
@@ -879,10 +879,12 @@ static ncclResult_t getCpuGpuAffinity(int cudaDev, cpu_set_t* mask) {
|
||||
path[PATH_MAX-1] = '\0';
|
||||
int fd;
|
||||
SYSCHECKVAL(open(path, O_RDONLY), "open", fd);
|
||||
char affinityStr[sizeof(cpu_set_t)*2];
|
||||
char affinityStr[sizeof(cpu_set_t)*2 + 1];
|
||||
int r = read(fd, affinityStr, sizeof(cpu_set_t)*2);
|
||||
if (r > 0)
|
||||
if (r > 0) {
|
||||
affinityStr[r] = '\0';
|
||||
NCCLCHECK(ncclStrToCpuset(affinityStr, mask));
|
||||
}
|
||||
close(fd);
|
||||
free(cudaPath);
|
||||
return ncclSuccess;
|
||||
|
||||
Odkázat v novém úkolu
Zablokovat Uživatele