AI/rocm-systems
2
0
Fork 0
Koodi Ongelmat Pull-pyynnöt Actions Paketit Projektit Julkaisut Wiki Toiminta

SWDEV-379007 - fix bool check for fp8_fnuz

Selaa lähdekoodia 
for fnuz nums zero val is 0x00, -0 i.e. 0x80 would be a NaN

Change-Id: Ibdc4fb4b9fb307b5952434f08d45a8ddd6262db8
This commit is contained in:
Jatin Chaudhary
2024-04-16 16:10:54 +01:00
committed by Jatin Jaikishan Chaudhary
vanhempi 03562a2547
commit d7b0d78fad
1 muutettua tiedostoa jossa 6 lisäystä ja 6 poistoa
Download Patch File Download Diff File Expand all files Collapse all files
hipamd/include/hip/amd_detail/amd_hip_fp8.h
+6 -6
Näytä tiedosto
@@ -705,10 +705,10 @@ struct __hip_fp8_e4m3_fnuz {
return __hip_bfloat16(f);
}
/*! convert fp8 e4m3 to bool, return false if value is +0 or -0, true otherwise */
/*! convert fp8 e4m3 to bool, return false if value is 0, true otherwise */
__FP8_HOST_DEVICE__ operator bool() const {
// it can be 0x00 (+0.0) or 0x80 (-0.0)
return !((static_cast<unsigned char>(__x) | 0x80) == 0x80);
// it can be 0x00 (+0.0) since 0x80 will be nan
return !(static_cast<unsigned short>(__x) == 0);
}
/*! convert fp8 e4m3 to char, clamp number to CHAR_MIN/CHAR_MAX if its out of range */
@@ -1094,10 +1094,10 @@ struct __hip_fp8_e5m2_fnuz {
return __hip_bfloat16(f);
}
/*! convert fp8 e4m3 to bool, return false if value is +0 or -0, true otherwise */
/*! convert fp8 e4m3 to bool, return false if value is 0, true otherwise */
__FP8_HOST_DEVICE__ operator bool() const {
// it can be 0x00 (+0.0) or 0x80 (-0.0)
return !((static_cast<unsigned char>(__x) | 0x80) == 0x80);
// it can be 0x00 (+0.0) since 0x80 will be nan
return !(static_cast<unsigned short>(__x) == 0);
}
/*! convert fp8 e5m2 to char, clamp out of bound values, return 0 if value is NaN */