AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[SWDEV-467733] - Add Param checking for SetCacheConfig APIs

Browse Source 
Change-Id: I9e777fa0fae6791ebab539e49346e6956a6ff196


[ROCm/clr commit: 0d20383ef9]
This commit is contained in:
Rahul Manocha
2024-06-13 11:04:39 -07:00
committed by Rahul Manocha
parent 43a1d720d5
commit da48c3b185
3 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/clr/hipamd/src/hip_context.cpp
+5
View File
@@ -312,6 +312,11 @@ hipError_t hipCtxGetCacheConfig(hipFuncCache_t* cacheConfig) {
hipError_t hipCtxSetCacheConfig(hipFuncCache_t cacheConfig) {
HIP_INIT_API(hipCtxSetCacheConfig, cacheConfig);
if (cacheConfig != hipFuncCachePreferNone && cacheConfig != hipFuncCachePreferShared &&
cacheConfig != hipFuncCachePreferL1 && cacheConfig != hipFuncCachePreferEqual) {
HIP_RETURN(hipErrorInvalidValue);
}
assert(0 && "Unimplemented");
HIP_RETURN(hipErrorNotSupported);
projects/clr/hipamd/src/hip_device_runtime.cpp
+5
View File
@@ -574,6 +574,11 @@ hipError_t hipDeviceReset(void) {
hipError_t hipDeviceSetCacheConfig(hipFuncCache_t cacheConfig) {
HIP_INIT_API(hipDeviceSetCacheConfig, cacheConfig);
if (cacheConfig != hipFuncCachePreferNone && cacheConfig != hipFuncCachePreferShared &&
cacheConfig != hipFuncCachePreferL1 && cacheConfig != hipFuncCachePreferEqual) {
HIP_RETURN(hipErrorInvalidValue);
}
// No way to set cache config yet.
HIP_RETURN(hipSuccess);
projects/clr/hipamd/src/hip_module.cpp
+13 -2
View File
@@ -222,7 +222,12 @@ hipError_t hipFuncSetAttribute(const void* func, hipFuncAttribute attr, int valu
hipError_t hipFuncSetCacheConfig(const void* func, hipFuncCache_t cacheConfig) {
HIP_INIT_API(hipFuncSetCacheConfig, cacheConfig);
// No way to set cache config yet.
if (func == nullptr) { HIP_RETURN(hipErrorInvalidDeviceFunction); }
if (cacheConfig != hipFuncCachePreferNone && cacheConfig != hipFuncCachePreferShared &&
cacheConfig != hipFuncCachePreferL1 && cacheConfig != hipFuncCachePreferEqual) {
HIP_RETURN(hipErrorInvalidValue);
}
// No way to set cache config yet
HIP_RETURN(hipSuccess);
}
@@ -230,7 +235,13 @@ hipError_t hipFuncSetCacheConfig(const void* func, hipFuncCache_t cacheConfig) {
hipError_t hipFuncSetSharedMemConfig(const void* func, hipSharedMemConfig config) {
HIP_INIT_API(hipFuncSetSharedMemConfig, func, config);
// No way to set Shared Memory config function yet.
if (func == nullptr) { HIP_RETURN(hipErrorInvalidDeviceFunction); }
if (config != hipSharedMemBankSizeDefault && config != hipSharedMemBankSizeFourByte &&
config != hipSharedMemBankSizeEightByte) {
HIP_RETURN(hipErrorInvalidValue);
}
// No way to set shared memory config yet
HIP_RETURN(hipSuccess);
}