P4 to Git Change 1544858 by skudchad@skudchad_rocm on 2018/04/22 21:07:25

SWDEV-144570 - [HIP] - Fix a few APIs and typos.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#6 edit

hipamd/api/hip/hip_device_runtime.cpp

@@ -349,9 +349,9 @@ hipError_t hipDeviceGetStreamPriorityRange ( int* leastPriority, int* greatestPr
 hipError_t hipDeviceReset ( void ) {
   HIP_INIT_API();
 
-  assert(0 && "Unimplemented");
+  /* FIXME */
 
-  return hipErrorUnknown;
+  return hipSuccess;
 }
 
 hipError_t hipDeviceSetCacheConfig ( hipFuncCache_t cacheConfig ) {
@@ -429,13 +429,21 @@ hipError_t hipSetDevice ( int  device ) {
 
     return hipSuccess;
   }
-  return hipErrorInvalidValue;
+  return hipErrorInvalidDevice;
 }
 
 hipError_t hipSetDeviceFlags ( unsigned int  flags ) {
   HIP_INIT_API(flags);
 
-  assert(0 && "Unimplemented");
+  /* FIXME */
+  /* Not all of Ctx may be implemented */
+
+  unsigned supportedFlags =
+      hipDeviceScheduleMask | hipDeviceMapHost | hipDeviceLmemResizeToMax;
+
+  if (flags & (~supportedFlags)) {
+    return hipErrorInvalidValue;
+  }
 
   return hipSuccess;
 }

hipamd/api/hip/hip_platform.cpp

@@ -272,6 +272,8 @@ void hipLaunchKernelGGLImpl(
   uint32_t sharedMemBytes,
   hipStream_t stream,
   void** kernarg) {
+
+  assert(0 && "Unimplemented");
 }
 
 }