Clean up and add comments

Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: Id30c0ccb68918e109533593df7c360837bdfa002


[ROCm/amdsmi commit: 4e8ed1f3e3]

projects/amdsmi/amdsmi_cli/amdsmi_parser.py

@@ -1027,6 +1027,7 @@ class AMDSMIParser(argparse.ArgumentParser):
                 metric_parser.add_argument('-T', '--throttle', dest='throttle', action='store_true', required=False, help=argparse.SUPPRESS)
 
             # Options to only display to Hypervisors
+            # Need to resolve the -G for gaurd, but technically should never interset since it's VF only
             if self.helpers.is_hypervisor():
                 metric_parser.add_argument('-s', '--schedule', action='store_true', required=False, help=schedule_help)
                 metric_parser.add_argument('-G', '--guard', action='store_true', required=False, help=guard_help)

projects/amdsmi/src/amd_smi/amd_smi_drm.cc

@@ -113,7 +113,6 @@ amdsmi_status_t AMDSmiDrm::init() {
     amd::smi::RocmSMI& smi = amd::smi::RocmSMI::getInstance();
     auto devices = smi.devices();
 
-    bool has_valid_fds = false;
     for (uint32_t i=0; i < devices.size(); i++) {
         auto rocm_smi_device = devices[i];
         drmDevicePtr device;
@@ -139,7 +138,6 @@ amdsmi_status_t AMDSmiDrm::init() {
                 drm_free_device(&device);
             }
             drm_free_version(version);
-            has_valid_fds = true;
         }
 
         uint64_t bdf_rocm = 0;