[HIPIFY] rename variables as requested in review

hipify-clang/src/ArgParse.cpp

@@ -89,14 +89,14 @@ cl::opt<bool> DashDash("-",
   cl::value_desc("--"),
   cl::cat(ToolTemplateCategory));
 
-cl::list<std::string> I("I",
+cl::list<std::string> IncludeDirs("I",
   cl::desc("Add directory to include search path"),
   cl::value_desc("directory"),
   cl::ZeroOrMore,
   cl::Prefix,
   cl::cat(ToolTemplateCategory));
 
-cl::list<std::string> D("D",
+cl::list<std::string> MacroNames("D",
   cl::desc("Define <macro> to <value> or 1 if <value> omitted"),
   cl::value_desc("macro>=<value"),
   cl::ZeroOrMore,

hipify-clang/src/ArgParse.h

@@ -33,8 +33,8 @@ extern cl::opt<std::string> OutputFilename;
 extern cl::opt<std::string> OutputDir;
 extern cl::opt<std::string> TemporaryDir;
 extern cl::opt<std::string> CudaPath;
-extern cl::list<std::string> I;
-extern cl::list<std::string> D;
+extern cl::list<std::string> IncludeDirs;
+extern cl::list<std::string> MacroNames;
 extern cl::opt<bool> Inplace;
 extern cl::opt<bool> SaveTemps;
 extern cl::opt<bool> NoBackup;

hipify-clang/src/main.cpp

@@ -199,14 +199,14 @@ int main(int argc, const char **argv) {
 #if defined(HIPIFY_CLANG_RES)
     Tool.appendArgumentsAdjuster(ct::getInsertArgumentAdjuster("-resource-dir=" HIPIFY_CLANG_RES));
 #endif
-    if (!D.empty()) {
-      for (std::string s : D) {
+    if (!MacroNames.empty()) {
+      for (std::string s : MacroNames) {
         Tool.appendArgumentsAdjuster(ct::getInsertArgumentAdjuster("-D", ct::ArgumentInsertPosition::END));
         Tool.appendArgumentsAdjuster(ct::getInsertArgumentAdjuster(s.c_str(), ct::ArgumentInsertPosition::END));
       }
     }
-    if (!I.empty()) {
-      for (std::string s : I) {
+    if (!IncludeDirs.empty()) {
+      for (std::string s : IncludeDirs) {
         Tool.appendArgumentsAdjuster(ct::getInsertArgumentAdjuster("-I", ct::ArgumentInsertPosition::END));
         Tool.appendArgumentsAdjuster(ct::getInsertArgumentAdjuster(s.c_str(), ct::ArgumentInsertPosition::END));
       }