AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SWDEV-455444 - Fixed Unit_AtomicBuiltins_Negative_Parameters_RTC

Browse Source 
After compiler change atomic_compare_exchange{weak,strong} now checks the failure memory order
as well as the success memory order. As a result there is additional warnings from RTC compilation.
Modified Unit_AtomicBuiltins_Negative_Parameters_RTC unit test to reflect that.

Change-Id: I55f954f3a870b947d1df393207d19e5f7989ee80


[ROCm/hip-tests commit: d1dff962d7]
This commit is contained in:
Ioannis Assiouras
2024-04-11 15:06:34 +01:00
committed by Maneesh Gupta
parent 93cdac1e1a
commit e89d5c6a04
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/hip-tests/catch/hipTestMain/config/config_amd_linux
-1
View File
@@ -262,7 +262,6 @@
"Unit_unsafeAtomicMax_Positive_Multi_Kernel_Same_Address - float",
"Unit___hip_atomic_fetch_min_Positive_Wavefront_Adjacent_Addresses - double",
"Unit___hip_atomic_fetch_min_Positive_Wavefront_Scattered_Addresses - double",
"Unit_AtomicBuiltins_Negative_Parameters_RTC",
"SWDEV-446588 - Disable graph multi gpu testcases until graph has support for it",
"Unit_hipGraphExecUpdate_Negative_MultiDevice_Context_Changed",
"Unit_hipGraphMem_Alloc_Free_NodeGetParams_Functional_MultiDevice",
projects/hip-tests/catch/unit/atomics/atomic_builtins.cc
+2 -4
View File
@@ -83,10 +83,8 @@ void AtomicBuiltinsRTCWrapper(const char* program_source, int expected_errors_nu
TEST_CASE("Unit_AtomicBuiltins_Negative_Parameters_RTC") {
AtomicBuiltinsRTCWrapper(kBuiltinStore, 5, 5);
AtomicBuiltinsRTCWrapper(kBuiltinLoad, 4, 4);
/* Begin: Should be 5 errors, 6 warnings for both. See EXSWHTEC-309*/
AtomicBuiltinsRTCWrapper(kBuiltinCompExWeak, 5, 2);
AtomicBuiltinsRTCWrapper(kBuiltinCompExStrong, 5, 2);
/* End. */
AtomicBuiltinsRTCWrapper(kBuiltinCompExWeak, 5, 7);
AtomicBuiltinsRTCWrapper(kBuiltinCompExStrong, 5, 7);
AtomicBuiltinsRTCWrapper(kBuiltinExchange, 5, 2);
AtomicBuiltinsRTCWrapper(kBuiltinFetchAdd, 5, 2);
AtomicBuiltinsRTCWrapper(kBuiltinFetchAnd, 7, 2);