Change-Id: I90df287a3b0f501a5dcb4b37a2bd3b9d5695f582


[ROCm/roctracer commit: 15f65a4d27]
This commit is contained in:
Laurent Morichetti
2022-05-23 21:21:28 -07:00
zatwierdzone przez Laurent Morichetti
rodzic 338e3e1fab
commit fbcb14fc09
3 zmienionych plików z 7 dodań i 7 usunięć
+3 -3
Wyświetl plik
@@ -22,7 +22,7 @@
*
* \section introduction Introduction
*
* ROC-tracer library, Runtimes Generic Callback/Activity APIs.
* ROCtracer library, Runtimes Generic Callback/Activity APIs.
*
* The goal of the implementation is to provide a generic independent from
* specific runtime profiler to trace API and asynchronous activity.
@@ -33,7 +33,7 @@
/**
* \file
* ROC tracer API interface.
* ROCtracer API interface.
*/
#ifndef ROCTRACER_H_
@@ -499,7 +499,7 @@ typedef void (*roctracer_buffer_callback_t)(const char* begin, const char* end,
/**
* Memory pool properties.
*
* Defines the propertis when a tracer memory pool is created.
* Defines the properties when a tracer memory pool is created.
*/
typedef struct {
/**
@@ -97,7 +97,7 @@ template <class T> class BaseLoader : public T {
void* handle_;
};
// 'rocprofiler' library loader class
// ROCprofiler library loader class
class RocpApi {
public:
typedef BaseLoader<RocpApi> Loader;
@@ -118,7 +118,7 @@ bool trace_pcs = false;
// The below getter functions have been written intentionally to fix an issue
// with constructor ordering. Previously when hip_api_vec and hsa_api_vec
// were left as simple global variables, whenever the tool_load() function
// was called from "extern "C" CONSTRUCTOR_API void constructor()" of libtracer_tool.so
// was called from CONSTRUCTOR_API void constructor()" of libroctracer_tool.so
// the ordering of std::vector constructor becomes undefined. This meant that you could assign
// hip_api_vec and hsa_api_vec with a value in tool_load() and once the function returns, the
// std::vector default constructor would execute later, causing the values to be lost.
@@ -343,7 +343,7 @@ void hip_api_callback(uint32_t domain, uint32_t cid, const void* callback_data,
if (data->phase == ACTIVITY_API_PHASE_ENTER) {
hip_begin_timestamp = timestamp;
} else {
// Post onit of HIP APU args
// Post init of HIP APU args
hipApiArgsInit((hip_api_id_t)cid, const_cast<hip_api_data_t*>(data));
entry = hip_api_trace_buffer->GetEntry();
@@ -968,7 +968,7 @@ extern "C" ROCTRACER_TOOL_EXPORT bool OnLoad(HsaApiTable* table, uint64_t runtim
// Check for optimized stats
const bool is_stats_opt = (getenv("ROCP_STATS_OPT") != NULL);
// HIP kernel ma pinstantiation
// HIP kernel map instantiation
if (is_stats_opt) hip_kernel_map = new hip_kernel_map_t;
// Enable tracing