SWDEV-509213 - make cmake_minimum_required consistent across clr (#51)

Change-Id: Ib0b1df7af8984a37d6bf7ca68ec99597d5978821
2025-04-15 10:53:41 +01:00
parent 588cf0fc69
commit fcaefe97b8
15 changed files with 9 additions and 47 deletions
@@ -18,7 +18,7 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.

-cmake_minimum_required(VERSION 3.16.3)
+cmake_minimum_required(VERSION 3.16.8)
 project(clr)

 ##########
@@ -20,19 +20,20 @@ If you need to build static clr library, `rocm-llvm-dev` package should be insta
 ### Linux

 - Clone this repository
-```
-cd clr && mkdir build && cd build
-```
+
+- `cd clr && mkdir build && cd build`
+
 - For HIP:

-`cmake .. -DCLR_BUILD_HIP=ON -DHIP_COMMON_DIR=$HIP_COMMON_DIR`
+    - `cmake .. -DCLR_BUILD_HIP=ON -DHIP_COMMON_DIR=$HIP_COMMON_DIR -DHIPCC_BIN_DIR=$HIPCC_BIN_DIR`

+        - `HIP_COMMON_DIR` points to [HIP](https://github.com/ROCm/HIP)

-  `HIP_COMMON_DIR` points to [HIP](https://github.com/ROCm/HIP)
+        - `HIPCC_BIN_DIR` points to hipcc directory, if you have ROCm installed you can point it to `$ROCM_PATH/bin`

 - For OpenCL™:

-`cmake .. -DCLR_BUILD_OCL=ON`
+    - `cmake .. -DCLR_BUILD_OCL=ON`

 - Build and install

@@ -17,7 +17,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.

-cmake_minimum_required(VERSION 3.16.8)
 project(hip)

 include(GNUInstallDirs)
@@ -18,12 +18,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.

-cmake_minimum_required(VERSION 3.5.1)
-
-if (POLICY CMP0074)
-  cmake_policy(SET CMP0074 NEW)
-endif()
-
 include(GNUInstallDirs)

 set(VERSION_MAJOR_AMDHIP ${HIP_VERSION_MAJOR})
@@ -24,13 +24,8 @@
 # Depends on: rocclr, so find_package(rocclr) will be required
 # Building hip header requires hip include folders with hip_version.h

-cmake_minimum_required(VERSION 3.16.1)
 option(BUILD_SHARED_LIBS "Build the shared library" ON)

-if (POLICY CMP0074)
-  cmake_policy(SET CMP0074 NEW)
-endif()
-
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake")

 if(BUILD_SHARED_LIBS)
@@ -18,7 +18,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.

-cmake_minimum_required(VERSION 3.3)
@PACKAGE_INIT@
 include(CMakeFindDependencyMacro)
 set_and_check(hiprtc_INCLUDE_DIR "@PACKAGE_INCLUDE_INSTALL_DIR@")
@@ -1,10 +1,3 @@
-cmake_minimum_required(VERSION 3.5.1)
-
-if (POLICY CMP0048)
-  cmake_policy(SET CMP0048 NEW)
-  set(PROJ_VERSION VERSION 1.5.0)
-endif()
-
 project(opencl)

 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
@@ -18,8 +18,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.

-cmake_minimum_required(VERSION 3.5)
-
 project(amdocl)

 option(BUILD_SHARED_LIBS "Build the shared library" ON)
@@ -1,5 +1,4 @@
 cmake_minimum_required (VERSION 3.5)
-
 project(OpenCL_Headers_Tests)

 enable_testing()
@@ -1,5 +1,4 @@
 cmake_minimum_required (VERSION 3.5)
-
 project (OPENCL_ICD_LOADER)
 include (GNUInstallDirs)
 find_package (Threads REQUIRED)
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.5.1)
+cmake_minimum_required(VERSION 3.16.8)
 project(rocm-opencl)

 set(CPACK_COMPONENTS_ALL binary dev)
@@ -1,9 +1,3 @@
-cmake_minimum_required(VERSION 3.5.1)
-
-if (POLICY CMP0072)
-        cmake_policy(SET CMP0072 NEW)
-endif()
-
 set(OCLTST_DIR ${CMAKE_CURRENT_SOURCE_DIR})

 if (WIN32)
@@ -18,8 +18,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.

-cmake_minimum_required(VERSION 3.5)
-
 project(ROCclr)

 if (${CMAKE_SOURCE_DIR} STREQUAL ${CMAKE_CURRENT_SOURCE_DIR})
@@ -18,12 +18,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.

-cmake_minimum_required(VERSION 3.5)
-
-if (POLICY CMP0072)
-        cmake_policy(SET CMP0072 NEW)
-endif()
-
 # ROCclr abstracts the usage of multiple AMD compilers and runtimes.
 # It is possible to support multiple backends concurrently in the same binary.
 option(ROCCLR_ENABLE_HSAIL "Enable support for HSAIL compiler" OFF)
@@ -19,7 +19,6 @@
 # THE SOFTWARE.

 #-------------------------------------elf_test--------------------------------------#
-cmake_minimum_required(VERSION 3.5.1)
 # This is unit test for amd::Elf.
 # The test is on top of rocclr, so rocclr must be built and installed firstly.
 # This file is seperate from cmake file of rocclr to prevent interference.