108 Commity

Autor SHA1 Wiadomość Data
Victor Zhang aaecffa50b SWDEV-568847 - prevent UAF when registering callbacks on completed events (#2066)
* SWDEV-568847 - prevent UAF when registering callbacks on completed events

* cache the status() of event earlier

* Update command.cpp

* revert cl_event.cpp

* Update cl_event.cpp

---------

Co-authored-by: cadolphe-amd <chris.adolphe@amd.com>
2025-12-09 11:38:45 -05:00
raramakr eddd4c3601 SWDEV-505204 - Update libamdocl.so installation path to avoid exposing all ROCm libraries via ldconfig (#1914)
ldconfig is run during rocm-opencl package installation.
Installing libamdocl.so in /opt/rocm-xxx/lib exposes all ROCm libraries when /opt/rocm/lib is added to ldconfig.
To prevent this, libamdocl.so is now installed in /opt/rocm-xxx/lib/opencl.
ldconfig will use the updated path, limiting exposure to only libamdocl.so library.

Co-authored-by: raramakr <raramakr@amd.com>
2025-11-19 21:14:28 +05:30
Pengda Xie a4bbd73dc6 SWDEV-556684 - Remove HSAIL support (#1183) 2025-10-23 11:21:49 -07:00
cadolphe-amd 207a278d41 SWDEV-516307 - Clean up ICD references in HIP (#1019)
Moved default empty dispatch table and associated Platform initialization for HIP from fixme.cpp into the respective struct definitions.
2025-10-08 09:49:35 -04:00
Julia Jiang 1c10592be2 SWDEV-546376 - Fix CTS profiling failure (#976) 2025-09-19 13:38:28 -04:00
Danylo Lytovchenko 2ff2316227 Adjust clang format to the new versions, revert broken macro layout (#714) 2025-08-22 17:23:22 +02:00
Danylo Lytovchenko f7338717ae SWDEV-470698 - fix formatting, add format check workflow (#657) 2025-08-20 19:58:06 +05:30
Andryeyev, German 6df9a49437 SWDEV-465041 - Add support for user events with DD (#321)
* SWDEV-465041 - Add support for user events with DD

User events can be replaced with HSA signals. Add the interface
to allocate HSA signal for user events and update the status on
CL_COMPLETE.
Force pinned path with DD to avoid blocking calls. Pinned memory
can be released only when the command is complete.
Simplify device enqueue path to use generic kernel arg buffer and
signals

* Fix notifyCmdQueue() logic for OCL

* Avoid blocking calls in OCL with DD

* Add event  destruciton in a case of the failure.

[ROCm/clr commit: 2305f8ae56]
2025-08-12 19:04:36 -04:00
Lytovchenko, Danylo e8988efb74 SWDEV-123456 - use only specific lines (#573)
* SWDEV-123456 - use only specific lines

* SWDEV-123456 - only run clang on diff between PR target and current

[ROCm/clr commit: ccb31fdf9d]
2025-06-25 10:54:29 +02:00
Lytovchenko, Danylo 89b5c1d9bf SWDEV-123456 auto clang-format (#482)
* SWDEV-123456 - add clang-format script and pre-commit hook

[ROCm/clr commit: 580a8759dd]
2025-06-05 14:28:12 +02:00
Brzak, Branislav dc39d67017 SWDEV-508742 - Make clCreatePipe spec compliant (#80)
[ROCm/clr commit: 7698d799ce]
2025-05-16 15:18:35 +05:30
Sang, Tao 68deb3d10a SWDEV-520352 - Remove HostThread and legacy monitor (#230)
* SWDEV-520352 - Remove HostThread and legacy monitor

Remove HostThread, semaphore and  legacy monitor.
Make original logics of thread and command queue stricker.
Add more comments to make logics clearer.
Some other minor improvement.

Also part of SWDEV-458943.

[ROCm/clr commit: 96cadbc9e9]
2025-04-29 09:55:24 -04:00
Chaudhary, Jatin Jaikishan c72604a2af SWDEV-509213 - make cmake_minimum_required consistent across clr (#51)
Change-Id: Ib0b1df7af8984a37d6bf7ca68ec99597d5978821

[ROCm/clr commit: fcaefe97b8]
2025-04-15 15:23:41 +05:30
Marko Arandjelovic 12dc02b4f8 SWDEV-495609 - Change include path for rocclr/utils
- Header files inside rocclr/utils when included from hipamd or opencl should be included as #include "rocclr/utils/xxx.h" instead of "utils/xxx.h"

Change-Id: Ic0760c33b9d091f5620dec67e5482c9698d22093


[ROCm/clr commit: 78f62d3230]
2024-12-05 11:44:20 -05:00
Alex Xie 794f1cdbd5 SWDEV-491168 - expose one more API in glGetExtensionFuncionAddress
Change-Id: Ia78b6b9377d99298c68968ef0eddd87534e0f750


[ROCm/clr commit: b5aab7f6b4]
2024-11-07 10:15:05 -05:00
Julia Jiang 0692af90ad SWDEV-494501 - Fix CTS api negative sub-test failures
Change-Id: I0dd67467d977569fca45dcdad28a96c839bae33b


[ROCm/clr commit: 11a4cb3c34]
2024-11-05 14:58:01 -05:00
Tao Sang 2cce18fb38 SWDEV-492563 - Fix Ocl issues
1. Fix LDSSize type to be uint32_t.
2. Prevent clWaitForEvents running on complete events whose
   HostQueue have been destructed.

Change-Id: I829e915f56b37db2ba76bb876c9656166534f154


[ROCm/clr commit: 82dff9a67d]
2024-10-30 19:15:59 -04:00
Julia Jiang 493e9c7884 SWDEV-412099 - Fix CTS clFillImage sub-tests failures
Change-Id: I082476837c539e6ccf93cba6b1e97aae2509e65c


[ROCm/clr commit: 17c8b9f855]
2024-09-30 11:13:52 -04:00
cadolphe a82e0fe333 SWDEV-462404 - Fix num_mip_levels for 1D Buffer
Updating field num_mip_levels to better align with OpenCL specification that mip-mapped images can not be created for CL_MEM_OBJECT_IMAGE1D_BUFFER images. Added check for miplevels value used for ClCreateImage call.

Change-Id: I82a25b83ef0637a877409572b7976d9e4413dfac


[ROCm/clr commit: 21a1c9075a]
2024-07-23 11:16:38 -04:00
Julia Jiang 3623e54842 SWDEV-472908 - Fix oclConfWimpyfull test failure
Change-Id: I44fddb88353e86a2f37e3ac870ba84cf6cace197


[ROCm/clr commit: 1e0565cc01]
2024-07-12 13:40:48 -04:00
Gu, Wangfeng 28009e625b SWDEV-460019 - [OGLP][Nv2x] DaVinci Resolve Studio: Crash observed when editing in color tab
When CL-GL interop is used, a GL context are used by two or more threads at the same time, which causes race condition.

Solution:
Add lock when accessing GL functions during CL-GL interop.

Change-Id: I3a34da3cbdf74c401111cc4e3a04ad84cc52709e


[ROCm/clr commit: 0c6a952a90]
2024-06-04 16:35:44 -04:00
kjayapra-amd 5436ebf0b9 SWDEV-457529 - Fix to build dynamic OpenCL libs in Static build environment.
Change-Id: Iaa26ccf13df919e6180704650564d9b0633e59da


[ROCm/clr commit: 63ccbef0d8]
2024-05-28 06:31:10 +00:00
Ranjith Ramakrishnan 9e13336b47 SWDEV-405330 - Add version details to amdocl shared library
Change-Id: I517075790a48e0a85a2cbd00150b279f13d51ebe


[ROCm/clr commit: 0ef7e3a99c]
2024-05-28 06:31:10 +00:00
Alex Xie 0812cc34a6 SWDEV-451945 - Remove ShouldLoadPlatform function
Change-Id: Iabb4071bb77201576bc2c0488a04f4fa188815df


[ROCm/clr commit: 2eb30376ba]
2024-05-06 10:42:59 -04:00
Saleel Kudchadker f3aedfbec0 SWDEV-301667 - Create TS for each node recorded in graph
- Create a vector to allow multiple TS to be stored in Command.
- This would mean we dont wait for entire batch in Accumulate command
to finish when we exhaust signals.
- Reduce the number of signals created at init to 64. This min value
may still need to be tuned but the KFD allows max of 4094 interrupt
signals per device.
- Store kernel names whenever they are available and not just when
profiling. If we dynamically enable profiling like for Torch, a crash
can happen if hipGraphInstantiate wasnt included in Torch profile scope
beacuse we previously entered kernel names only when profiler is
attached.

Change-Id: I34e7881a25bbc763f82fdeb3408a8ea58e1ec006


[ROCm/clr commit: c157bfb202]
2024-03-26 14:47:24 -04:00
Ioannis Assiouras b97b245b0a SWDEV-443796 - Translate CL_INVALID_GL_OBJECT error for DX/CL interop
Change-Id: If87bb9d0fb275dd4d9a8a949f4016a082a300144


[ROCm/clr commit: 32d49d55ec]
2024-02-05 10:29:00 -05:00
Alex Xie b444ee5b3b SWDEV-423579 - Move header file to ROCclr
This header file is used by ROCclr and might be used by HIP too.
ROCclr folder is a right place for this header file.

Change-Id: Ie2307331f9bd445f3c295d2ccbfc4924b0fa9510


[ROCm/clr commit: 124de0c519]
2023-10-06 14:54:50 -04:00
Alex Xie c0bb71bd74 SWDEV-421710 - Remove unused GL function pointers
Change-Id: Ifd77314b51d4b1494428bf8b611051245dbc3feb


[ROCm/clr commit: 2804aa8e34]
2023-09-12 18:17:04 -04:00
jatang 34f68be605 SWDEV-373396 - OCLCreateBuffer: make the CPU checkResult() 4 times faster
Change-Id: If20cd6b509896a748f74ab5296cb85f2c4a9f04c


[ROCm/clr commit: a456182888]
2023-06-06 17:15:34 -04:00
Alex Xie e9b17e263a SWDEV-389541 - mipmap tests failed
Change-Id: I8dec8ff9515c55a3a6b16157f7d064b2b109d5f3


[ROCm/clr commit: 475f80ee0e]
2023-05-01 12:31:17 -04:00
German Andryeyev b2525dfb82 SWDEV-381627 - Move cl_vk_amd.hpp into rocclr
Rename VK interop to ExternalMemory object, since it should handle
DX interops also

Change-Id: I536ec46d3e53ece35234a2e29030393ad411b96d


[ROCm/clr commit: 3e5803c4c0]
2023-04-26 15:25:01 -04:00
victzhan 489f17c447 SWDEV-387117 - Support negative miplevel for clCreateFromGLTexture()
Change-Id: Ieaa340196e6844b2d18cdcc2278f913fc7c7bbb8


[ROCm/clr commit: 636983de49]
2023-04-19 12:46:45 -04:00
pghafari 82219d2fb1 SWDEV-366992 - adding handle type for vk interop
Change-Id: I79ee0d89b948c21b96709e9e607abe7901621a97


[ROCm/clr commit: 78de2ae692]
2023-04-18 16:59:25 -04:00
agunashe 8878a5db05 SWDEV-381627 - opencl refactor for interop files
moving the common files to vdi

Change-Id: Iab113e8bd93473553e64106f690496e6bf2bda03


[ROCm/clr commit: ccf4f5f849]
2023-04-05 16:40:03 +00:00
Maneesh Gupta dc41080660 SWDEV-361630 - Enable hip build
Change-Id: Icdeaeff555d46e495c3de954b614168995a82a9f


[ROCm/clr commit: 1bc186323f]
2023-03-26 15:42:33 +00:00
victzhan 33d3101cf6 SWDEV-345751 - Added parameter check for clEnqueueWriteImage
Change-Id: I9606ea1c3698d009f23b7da673c02fa05b009dbc


[ROCm/clr commit: 96cd9f7b76]
2023-01-26 16:49:56 -05:00
Victor Zhang 3a2d258194 Merge "SWDEV-110636 - added if statement so that output of clBuildProgram follows opencl specification" into amd-staging
[ROCm/clr commit: a1beaf54a6]
2023-01-26 16:25:11 -05:00
German a1371d6309 SWDEV-377991 - Remove liquidflash support
Change-Id: I928ed40f11461d5da07190e67bbec6a5363c42a6


[ROCm/clr commit: b9901144eb]
2023-01-19 11:15:46 -05:00
Victor Zhang c200479039 SWDEV-110636 - added if statement so that output of clBuildProgram follows opencl specification
Change-Id: I4ee000008c52a0bbdb47e94a8e1b5faf28c3bfe6


[ROCm/clr commit: 1fe9918576]
2023-01-17 00:52:04 -05:00
Todd tiantuo Li 8f2b881c3b SWDEV-354868 - return CL_INVALID_VALUE if number of RT CUs is less than its granularity when creating command queue
Change-Id: I31004e82589c3378dba5541095a1eff763d4579d


[ROCm/clr commit: 6d4e067302]
2022-12-13 04:59:33 -08:00
Ioannis Assiouras 48173fdcb5 SWDEV-369581 - Convey copy API metadata to ROCclr
Change-Id: I318636602cbb546a12bb339264153b9be4008b40


[ROCm/clr commit: 829843cdfe]
2022-12-09 00:27:55 -05:00
German 95bcc9655f SWDEV-368308 - Remove HW debug extension
Remove the header file, used in rocclr.

Change-Id: I1dfdbb05fdcbaf32708252071e8955d2ca94126d


[ROCm/clr commit: 92f0607f87]
2022-11-18 14:04:17 -05:00
German ba2941e57d SWDEV-368308 - Remove HW debug extension
The extension was devloped for AMDIL path only.
OCL runtime doesn't support AMDIL path  anymore.
The new debugger interfaces don't require any runtime calls either.

Change-Id: I6215545f9b6ae5c70b5f076c3cbfbfd3b5eef42b


[ROCm/clr commit: 0db20050bc]
2022-11-16 17:37:06 -05:00
Alex (Bin) Xie 757ad58402 SWDEV-329646 - MicroStation app crash upon closing
Change-Id: I0ca272be42934ee96f45300fa06847cd74170f13


[ROCm/clr commit: 10648c4d70]
2022-04-21 12:29:48 -04:00
sdashmiz f8355f5fb0 SWDEV-329349 - add display support for Opencl
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Icf5253ba87f3852153c620fb7b789bd6e90cb52e


[ROCm/clr commit: 9f5685ea0a]
2022-04-13 15:11:29 -04:00
Hao Yuan abc4522fa3 Merge "SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers" into amd-staging
[ROCm/clr commit: 4d300d1f8a]
2022-04-12 11:00:51 -04:00
haoyuan2 605958392b SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers
Change-Id: I89db993ba90783c53546c5290c00e13f5c24edf4


[ROCm/clr commit: fe173ed9fb]
2022-04-08 12:12:07 -07:00
Jeremy Newton 60d0d8444e SWDEV-321116 - Drop unnecessary ICD include
This looks unused. This should allow building rocm-opencl without any
dependency on any particular OCL ICD.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: Ib9229ede8400fd0e883275659ab99513b03952cb


[ROCm/clr commit: 86c9bb1946]
2022-04-07 14:45:43 -04:00
Maneesh Gupta ff659975f4 SWDEV-325869 - Update ASAN linker options
Change-Id: I9ef513ab647ec0866cdf0f70f759ab95d80081b9


[ROCm/clr commit: 94ed5262c6]
2022-03-03 11:45:06 +00:00
haoyuan2 73f1a43d97 SWDEV-298331 - Fix FreeLibrary throw exception issue on Windows
dummy function for OCL, release resource for HIP

Change-Id: Idda5047ab7393747d13a9231e0cca5953fc68a6a


[ROCm/clr commit: 5d65c0da88]
2022-02-25 20:02:41 -08:00