## Motivation
Resolved: SWDEV-566226
The current implementation of agents inside of rocprof-systems keeps just the minimal necessary set of information required for populating the `info_agent` table inside of rocpd database. There is a sufficient amount of data that is being left out from database, so this change should fix that and store the additional agent information as an `extdata` row inside of `info_agent` table.
## Technical Details
This PR introduces additional filed inside of `agent` structure inside which is representing the JSON formatted string of all the additional information we can acquire about particular agent. This data is processed and added during the initial fetching of agents, and afterwards pushed inside of the database.
---------
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
* SWDEV-557412 - Incorporate proper chunk offset when remapping virtual memory (#1848)
* SWDEV-557412 - Incorporate proper offset when remapping virtual memory
* Fix condition to check if VMHeap allocation address matches a chunk address
* Move offset calculation outside if/else block
---------
Co-authored-by: JeniferC99 <150404595+JeniferC99@users.noreply.github.com>
* SWDEV-567852 - Clean-up hip::init() (#1948)
* SWDEV-559267 - Use CLPrint to DevLogPrintf with Log Level - detail debug. (#1160)
* SWDEV-548892 - Stop using ocml isinf wrapper (#1854)
* SWDEV-562708 - change default maximum SVM size to 256GB (#1731)
* SWDEV-503089 - Fix and enable disabled HIP tests from math group (#1319)
* SWDEV-503089 - Fix and enable disabled HIP tests from math group
* SWDEV-503089 - Move single precision reduced run to a common function
* SWDEV-548892 - Stop using ockl steadyctr function (#1882)
Directly use the builtin
* Implement PTL support (#1957)
* Implement PTL support
Signed-off-by: adapryor <Adam.pryor@amd.com>
(cherry picked from commit 45bc31292e7940a3b8fca044ef7df22047b95733)
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
---------
Signed-off-by: adapryor <Adam.pryor@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Co-authored-by: Maisam Arif <Maisam.Arif@amd.com>
* SWDEV-558080 - Add recommended granularity (#1176)
* Add recommended granularity
* Improve granularity testing
* Update based on feedback
* Fix and enable VMM tests on cuda (#1855)
* Fix and enable VMM tests on cuda
* Minor syntax fixes
---------
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
* [rocprofiler-systems] Add support for ompt_callback_thread_begin (#1681)
* Add thread_begin callback
* Make OMPT callbacks that are instant have start_ts = end_ts
* SWDEV-567514: Remove default stream wait (#1977)
- when virtual map command is called
- can create deadlock
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
* Fix flaky test Unit_hipStreamAddCallback_StrmSyncTiming (#2022)
* Review comments
* skip the 3 failing tests to merge hip-tests rocm-systems PR
---------
Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
Signed-off-by: adapryor <Adam.pryor@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Co-authored-by: GunaShekar <agunashe@amd.com>
Co-authored-by: agunashe <ajay.gunashekar@amd.com>
Co-authored-by: Ethan Trinh <Ethan.Trinh@amd.com>
Co-authored-by: JeniferC99 <150404595+JeniferC99@users.noreply.github.com>
Co-authored-by: Victor Zhang <111778801+victzhan@users.noreply.github.com>
Co-authored-by: German Andryeyev <56892148+gandryey@users.noreply.github.com>
Co-authored-by: usrihari123 <srihari.u@amd.com>
Co-authored-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
Co-authored-by: anujshuk-amd <anujshuk@amd.com>
Co-authored-by: itrowbri <Ian.Trowbridge@amd.com>
Co-authored-by: marantic-amd <marantic@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: cadolphe-amd <chris.adolphe@amd.com>
Co-authored-by: Karthik Jayaprakash <54370791+kjayapra-amd@users.noreply.github.com>
Co-authored-by: Matt Arsenault <Matthew.Arsenault@amd.com>
Co-authored-by: Todd tiantuo Li <88386084+lttamd@users.noreply.github.com>
Co-authored-by: amilanov-amd <Aleksandar.Milanov@amd.com>
Co-authored-by: Adam Pryor <61172547+adam360x@users.noreply.github.com>
Co-authored-by: Maisam Arif <Maisam.Arif@amd.com>
Co-authored-by: AidanBeltonS <abeltons@amd.com>
Co-authored-by: Rahul Manocha <153310294+manocharahul@users.noreply.github.com>
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
Co-authored-by: Kian Cossettini <Kian.Cossettini@amd.com>
Co-authored-by: Shadi Dashmiz <94885391+shadidashmiz@users.noreply.github.com>
Co-authored-by: Ioannis Assiouras <38722728+iassiour@users.noreply.github.com>
Co-authored-by: Ajay GunaShekar <86270081+agunashe@users.noreply.github.com>
* SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api
* SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api
* SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api
* SWDEV-546351 : Added test cases for hipGetDriverEntryPoint api
* addressed review comments Added non-zero check
---------
Co-authored-by: Anavena Venkatesh <Anavena.Venkatesh@amd.com>
Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
* SWDEV-493276 - [catch2][dtest] Additional tests for Scratch limit change
* Removed the Kernel wait related scenarios
* Modified kernel operation
* Fixed PSDB NVIDIA build issue
* Restricted for Windows
* Used isSetScratchLimitSupported for all tests and modified isSetScratchLimitSupported
[ROCm/hip-tests commit: f7712bd5a8]
- This test causes build failure when custom HIP_PATH is used
- It doesn't add much value as it verifies hipDeviceAttributeFineGrainSupport against HSA APIs
- In rare case only it can fail, because internally HIP uses the same HSA APIs for hipDeviceAttributeFineGrainSupport.
Change-Id: If3b566d1c784a318e076b640cc2f063b84e25413
[ROCm/hip-tests commit: 569b088eb8]
- Recreation of github PR https://github.com/ROCm-Developer-Tools/hip-tests/pull/217
- For Unit_hipGetDeviceAttribute_CheckFineGrainSupport test, get segment information using HSA APIs instead of rocminfo
Change-Id: I20f4c8a6669684a2326a3ce61735c4fa10433f9d
[ROCm/hip-tests commit: f85b731a5c]
Ignore the iGPU when iterating rocminfo and correct the bounds check
when matching results with HIP API. Also do not compare bytes directly,
use string to do a string compare as it can go out of bounds.
Disabling this test on windows till I get hold of a working windows
machine.
Change-Id: Icf811e0310776567afecea92e1d54e8438b39235
[ROCm/hip-tests commit: af3ac29c40]
* SWDEV-359379 - catch2: Standalone single exe per file
-workaround for rsp file issue.
-Creates single exe per file
-tests detection is still during execution time and NOT compile time
Change-Id: Iddfb83d57b2d767212f3d9307a276b7d572da6cd
* SWDEV-359379 - Update CMakeList
* Update Catch.cmake
* Temporarily disable failing tests
[ROCm/hip-tests commit: 961245e9f4]
- Add simple positive and negative test for hipInit api
- Add simple positive and negative test for hipDriverGetVersion api
- Disable hipInit negative test on AMD
[ROCm/hip-tests commit: 90417c23d1]
- Verify that opening the same handle in different contexts on same device causes an error
- Verify that opening the handle in the process that created it causes an error
- Remove linux guard from test file and exclude test from windows build with cmake.
- Disable Unit_hipIpcOpenMemHandle_Negative_Open_In_Creating_Process for AMD.
[ROCm/hip-tests commit: f9aceabe26]
- Negative parameter tests
- Default return value test
- Multithreaded test
- Adjust hipDeviceSetGetSharedMemConfig tests according to new return value.
[ROCm/hip-tests commit: 03f847847e]
- Verify that unique handles are returned for consecutive calls
- Verify that unique handles are returned for separate allocations at same address
- Verify that freed memory causes an error
- Verify that out of bounds pointer will cause an error.
- Remove linux guard from test file and exclude test from windows build with cmake.
- Fix expected error in hipIpcGetMemHandle negative tests.
[ROCm/hip-tests commit: dca25f3ba4]
- Verify that memory stays mapped when reference count is non zero
- Verify that memory stays mapped if handle is closed in a second process
- Verify that attempting to close handle in the process that created it causes an error
- Correct header includes.
- Add additional pointer check to reference counting test.
- Disable Unit_hipIpcCloseMemHandle_Negative_Close_In_Originating_Process test for AMD.
[ROCm/hip-tests commit: 86fa9725c4]
- Implemented P2P Device Access positive and negative tests for the following functions:
- hipDeviceCanAccessPeer
- hipDeviceEnablePeerAccess
- hipDeviceDisablePeerAccess
- Expand P2P Device Access negative tests
- Add hipDeviceEnablePeerAccess negative test when flag is invalid and access is already enabled
- Add hipDeviceDisablePeerAccess negative test when access is not enabled and when it is disabled twice
[ROCm/hip-tests commit: 79162275d9]
- Test behaviour with valid arguments for both APIs
- Test with invalid parameters.
- Default return value test
- Multithreaded test
- Enable tests for nvidia platform.
[ROCm/hip-tests commit: 44a48a387e]
Changes contain Device files under "hip/tests/src/runtimeApi/device" migrated to Catch2 and some additional device tests.
Change-Id: Ie88adc3c32c2079456b14e029cfc6c319b48d8f6
[ROCm/hip-tests commit: c9ae0281ff]
Jatin Chaudhary
systems-assistant[bot]
Swargam, Rambabu
Ioannis Assiouras
SrinivasaRao
Michael Xie
kjayapra-amd
Mirza Halilcevic
Rakesh Roy
Jatin Chaudhary
vinay birur
taosang2
Rahul Garg
Mirza Halilčević
nives-vukovic
ROCm CI Service Account
Fábio
Jatin Chaudhary
Finlay
Satyanvesh Dittakavi
agunashe
sumanthtg