6425 Incheckningar

Upphovsman SHA1 Meddelande Datum
satyanveshd 33b5e15e9a hipMemcpy[To/From]Symbol(Async) fixes (#1774)
[ROCm/hip commit: 6b5ea15dfe]
2020-01-07 08:11:53 +05:30
Rick Ho 98a6bb683a Fix minor explainations in the kernel guide (#1775)
[ROCm/hip commit: 7d27247814]
2020-01-06 12:34:21 +05:30
Rahul Garg 327a45b18b Add hipBindTexture2D on NVCC path (#1773)
[ROCm/hip commit: a5d7e7d8d3]
2020-01-06 12:33:50 +05:30
Rahul Garg b6a3c3a95e Fix nested designator warnings (#1768)
[ROCm/hip commit: 785a4440c8]
2020-01-06 12:33:34 +05:30
Rahul Garg 86dbb13897 Fix hipcc warning related to hipVersion (#1767)
* Fix hipcc warning related to hipVersion
* Rename hipVersion.h to hip_version.h
* Remove HIP_VERSION splitting
* Update .gitignore
- Ignore generated include/hip/hip_version.h
- Removed some stale entries
- Added executables from samples/1_Utils/*/ for consistency with bin/ entries.

[ROCm/hip commit: f3cafd5855]
2020-01-06 12:33:23 +05:30
Yaxun (Sam) Liu 3dae7945ff Update HIP-Clang build instruction (#1764)
[ROCm/hip commit: af697eaefe]
2020-01-06 12:32:47 +05:30
Yaxun (Sam) Liu 2a70e452a5 Document FMA settings (#1717)
[ROCm/hip commit: 47525e72db]
2020-01-06 12:32:38 +05:30
foreman 31e4b7e893 P4 to Git Change 2052191 by skudchad@skudchad_test2_win_opencl on 2020/01/03 15:54:23
SWDEV-213000 - Backout change to notifyCmdQueue as the real issue has been identified

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#53 edit


[ROCm/hip commit: a42f6272f5]
2020-01-03 16:02:59 -05:00
foreman 73263137b4 P4 to Git Change 2051060 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/12/30 16:42:07
SWDEV-145570 - Clean up after `hipError_t` unification.

	- Replace deprecated `hipError_t` enums.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#94 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#52 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#27 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#5 edit


[ROCm/hip commit: 9386736b41]
2019-12-30 16:46:39 -05:00
Evgeny Mankov 6ac4d18753 Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/hip commit: 0dadb23327]
2019-12-30 19:21:09 +03:00
Sarbojit2019 6d2ec032fe Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.

[ROCm/hip commit: aa4aea0754]
2019-12-30 12:44:24 +05:30
Aryan Salmanpour ffea90f865 [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.

[ROCm/hip commit: 6968aeb841]
2019-12-30 12:42:17 +05:30
ansurya 8f0daf4019 Fix texture 3D & 2D layered with N components (#1746)
SWDEV-151670: Issue with 3D texture with 4 components
SWDEV-151671: Issue with 2D layered texture with 4 components

Fixed memcpy when memory is allocated with driver API's.

Github issues: #1755
Fixed 3D default case when array type is not set during memory allocation.

[ROCm/hip commit: 391e99cd12]
2019-12-30 12:41:42 +05:30
foreman 3966a475bd P4 to Git Change 2049729 by skudchad@skudchad_test2_win_opencl on 2019/12/23 12:36:57
SWDEV-203814 - Change the return type of the hiprtcGetTypeName to have compatibility across ABIs

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18392/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#9 edit


[ROCm/hip commit: 2989140f78]
2019-12-23 12:42:24 -05:00
Evgeny Mankov 6ebd0592da [HIPIFY][doc] LLVM 9.0.1 is the latest stable release now
+ Tested on Windows and Linux: no changes are needed


[ROCm/hip commit: 3254c3e2c1]
2019-12-23 20:00:33 +03:00
Evgeny Mankov abef353b5b [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/hip commit: 4921678b6c]
2019-12-23 17:01:35 +03:00
Yaxun (Sam) Liu d10837db9d Add macro __HIP_ENABLE_CUDA_WRAPPER_FOR_OPENMP__ (#1761)
This is to allow force enable cuda wrapper for OpenMP for flexibility

[ROCm/hip commit: 3c90d57072]
2019-12-23 19:24:54 +05:30
saleelk bb7fa73dcc Fix the return type of demangle function so that its compatible across ABIs (#1744)
[ROCm/hip commit: 080b0b9a68]
2019-12-23 19:11:40 +05:30
Alex Voicu 1f5ecc0f6a Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/hip commit: 75a11330aa]
2019-12-23 19:11:24 +05:30
Maneesh Gupta 91f82210fb replace array designator C99 (#1694)
* replace array designator C99

* Update texture_functions.h

Highlight valid and invalid values in texFormatToSize

Co-authored-by: Maneesh Gupta <maneesh.gupta@amd.com>


[ROCm/hip commit: 7d6634ce9d]
2019-12-23 19:10:24 +05:30
Alex Voicu b7803eb0c6 static inline in a header, just like excess sugar in a diet, causes bloat (#1692)
[ROCm/hip commit: be70b9f7e7]
2019-12-23 19:09:38 +05:30
Evgeny Mankov 97535f3e97 [HIP] Fix typo
[ROCm/hip commit: 9544682e2c]
2019-12-23 12:06:44 +03:00
Evgeny Mankov 30ae3942dc [HIP] Unify hipError_t (Step 2)
Step 2. Make a few hipError codes deprecated
Update hipify-clang, hipify-perl, docs and samples accordingly


[ROCm/hip commit: dbad4d9b7f]
2019-12-22 02:05:31 +03:00
Evgeny Mankov bf2f77846e Merge pull request #1734 from vsytch/win10-hipMemcpy-fixes
Fix OOM issues with hipMemcpy test on Windows

[ROCm/hip commit: 9c91632194]
2019-12-21 22:02:34 +03:00
Maneesh Gupta ddc169cf4e Update texture_functions.h
Highlight valid and invalid values in texFormatToSize

[ROCm/hip commit: d92169c05a]
2019-12-21 12:25:36 +05:30
Maneesh Gupta 78dc660cb6 bump version to 3.1 (#1756)
* Bump version to 3.1

* [ci] Enable tests on ROCm 3.0


[ROCm/hip commit: 18c1003469]
2019-12-20 12:10:25 -08:00
foreman a1e5fb0c3c P4 to Git Change 2049240 by lmoriche@lmoriche_opencl_dev2 on 2019/12/20 13:54:17
SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES

	Return an error instead of dereferencing a null pointer. This should address the issue described
	in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#59 edit


[ROCm/hip commit: 0c35aa5f1c]
2019-12-20 13:02:52 -06:00
Evgeny Mankov 19fd269632 [HIPIFY][doc] Update Readme.md: versioning
[ROCm/hip commit: dd0bf8c7ff]
2019-12-20 20:55:19 +03:00
Sarbojit2019 ef3ee5908f Fix for windows dtest build failure (#1742)
[ROCm/hip commit: e2fc00da65]
2019-12-19 13:10:43 -08:00
foreman 9d6cc4d642 P4 to Git Change 2048698 by jujiang@JJ-HIP on 2019/12/19 15:52:21
SWDEV-215536 - [HIP][Windows]Output mismatch with tex2DLayered()

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#93 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#31 edit


[ROCm/hip commit: f02b4ffd82]
2019-12-19 15:57:37 -05:00
mhbliao ded857e2b9 [hip] Add macro guarding the enum conversion for scalar accessor. (#1748)
- That's a high overhead part, which needs enabling ONLY if necessary.

[ROCm/hip commit: 99a3b66110]
2019-12-19 10:08:37 -08:00
Evgeny Mankov 4b6e343269 Merge pull request #1739 from emankov/hipify-clang
[HIP] Unify hipError_t (Step 1)

[ROCm/hip commit: 191808fe72]
2019-12-19 07:57:02 +03:00
foreman bd40deaccc P4 to Git Change 2047959 by skudchad@skudchad_test2_win_opencl on 2019/12/18 14:40:28
SWDEV-213000 - Add notifyCmdQueue in ihipModuleLaunchKernel. This torques timing and flushes the queue immediately. Investigation pending.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18408/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#51 edit


[ROCm/hip commit: 3beb70b72a]
2019-12-18 14:42:18 -05:00
foreman d5776751ca P4 to Git Change 2047424 by lmoriche@lmoriche_opencl_dev2 on 2019/12/17 20:13:01
SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES

	Return an error instead of dereferencing a null pointer. This should address the issue described
	in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#92 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#58 edit


[ROCm/hip commit: f6d38a725c]
2019-12-17 20:18:36 -05:00
Evgeny Mankov baf7e660a2 [HIPIFY] Revise HIP runtime
+ hipMemAllocHost is deprecated, use hipHostMalloc instead
+ hipMemAllocManaged -> hipMallocManaged
+ hipFreeHost -> hipHostFree
+ cudaMemset3D(Async) -> hipMemset3D(Async)
+ update docs and hipify-perl accordingly


[ROCm/hip commit: 3b00057922]
2019-12-16 20:09:55 +03:00
Vladislav Sytchenko 6015efe6f5 Add comments explaining choice on the cap for system memory on Windows.
[ROCm/hip commit: bf3df9d7c0]
2019-12-13 21:38:27 -05:00
Vladislav Sytchenko 29ca9f7d53 Add explicit cast when computing the available amount of system memory.
[ROCm/hip commit: 12634879e2]
2019-12-13 21:37:30 -05:00
Evgeny Mankov ca99107c7b [HIP] Unify hipError_t (Step 1)
Step 1. Set the same values for RT error codes as for analogous Driver's

[Reason] RT's and Driver's error codes unification in CUDA 10.2


[ROCm/hip commit: d8737ba50c]
2019-12-13 19:40:16 +03:00
Evgeny Mankov 1eeb648716 [HIPIFY][build] Fix building with LLVM trunk
[ROCm/hip commit: 96839c82ae]
2019-12-13 15:42:27 +03:00
foreman a81fb22bc7 P4 to Git Change 2045076 by skudchad@skudchad_test2_win_opencl on 2019/12/12 15:57:20
SWDEV-213031 - Check the functions_ map else interpret as a hip::Function for now. Function may not be a device function and may have been obtaiend via hipModuleGetFunction and thus not in the functions_ map

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18388/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#57 edit


[ROCm/hip commit: 455c3a91ef]
2019-12-12 16:01:14 -05:00
Evgeny Mankov 9827755cb5 [HIPIFY][BLAS] Sync with cuBlas/rocblas/hipBlas
[ROCm/hip commit: 396a8a7a00]
2019-12-12 19:52:18 +03:00
foreman 4a1d5b54e7 P4 to Git Change 2044900 by skudchad@skudchad_test2_win_opencl on 2019/12/12 11:42:43
SWDEV-203814 - Add cases to handle char* and char** for tracehelper

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18384/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#4 edit


[ROCm/hip commit: ec54afaa32]
2019-12-12 11:47:12 -05:00
Vladislav Sytchenko 9dade23425 Reduce the amount of free host memory to 40% of what is reported on Windows, otherwise we can run into OOM situations.
[ROCm/hip commit: b12c53cceb]
2019-12-11 20:21:12 -05:00
foreman b86804796d P4 to Git Change 2044310 by cpaquot@cpaquot-ocl-lc-lnx on 2019/12/11 19:20:38
SWDEV-213526 - [hip] OOM issue
	Clean up a bit from Laurent's comments.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#50 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#56 edit


[ROCm/hip commit: dac5ef4e22]
2019-12-11 19:31:20 -05:00
foreman 41e7be0fa6 P4 to Git Change 2044309 by cpaquot@cpaquot-ocl-lc-lnx on 2019/12/11 19:19:15
SWDEV-145570 - [hip] special case const char* for logs in case it's a null pointer.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#3 edit


[ROCm/hip commit: de46a0e205]
2019-12-11 19:26:50 -05:00
foreman ab8b693e4a P4 to Git Change 2044223 by jujiang@JJ-HIP on 2019/12/11 16:16:37
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
	-Update hipCreateTextureObject

	http://ocltc.amd.com/reviews/r/18382/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#91 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#30 edit


[ROCm/hip commit: eaef4a97b5]
2019-12-11 16:30:48 -05:00
foreman b3807a8ab7 P4 to Git Change 2043802 by cpaquot@cpaquot-ocl-lc-lnx on 2019/12/11 03:06:02
SWDEV-213526 - [hip] OOM issue
	Delay any access to device layers till HIP API is called by app.
	This allows the app to fork the process first and then call HIP which is legal.
	Doing hip calls then fork isn't legal nor supported by ROCm.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#49 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#55 edit


[ROCm/hip commit: 921fa13d81]
2019-12-11 03:11:19 -05:00
mhbliao e1f55b0cee Only add hipExtLaunchMultiKernelMultiDevice for non-HCC compilers. (#1729)
[ROCm/hip commit: 444c931641]
2019-12-10 10:32:25 -08:00
jglaser 65f80f80a1 fix linking of vector types with gcc (#1690)
* fix linking of vector types when linking hipcc objects with gcc

* use __atribute__((vector_size)) with both clang and gcc

and reinstate nonaligned n=3 vector type

* use implicit conversion to value and ext_vector_type when available

* Alternate formulation for GCC compatibility

* Built-in arrays don't mix well with placement new

* Fix typo

* Add conversions to enum

* Fix Scalar_accessor assignment.

* Update hip_vector_types.h

* stir up the underlying_type hideous mess

This fixes the HIP build issue "error: only enumeration types have underlying types".


[ROCm/hip commit: 00d735cdc9]
2019-12-10 09:40:15 +05:30
foreman bc52bfaeb8 P4 to Git Change 2042612 by eshcherb@evgeny-hip on 2019/12/09 11:11:38
SWDEV-197289 - HIP-VDI tracing
	activity suppressing of type is zero;
	fixing callbacks table recursive mutex;

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#101 edit


[ROCm/hip commit: 0705efa384]
2019-12-09 11:22:57 -05:00