6425 Commits

Author SHA1 Message Date
Evgeny Mankov 69ac658878 [HIPIFY] Add cleanupHipifyOptions functionality
Needed for sorting input files to avoid clang errors on unsupported options


[ROCm/hip commit: 40bac6b144]
2019-12-08 15:13:28 +03:00
Evgeny Mankov 92401a01c2 [HIPIFY] main source file refactoring
[ROCm/hip commit: b472f41896]
2019-12-07 13:50:13 +03:00
Evgeny Mankov 8ba707b016 [HIPIFY][fix][#1246][#1655] Sort input files based on their dependency graph
+ Implemented by using clang Driver infrastructure

[ToDo] Add tests for in-place hipification of multiple files


[ROCm/hip commit: 6868b38d1b]
2019-12-07 11:20:17 +03:00
foreman 77f32e82e4 P4 to Git Change 2042093 by jujiang@JJ-HIP on 2019/12/06 14:44:16
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
	-Update hipTexRefSetArray

	http://ocltc.amd.com/reviews/r/18356/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#29 edit


[ROCm/hip commit: f4df28905e]
2019-12-06 14:53:41 -05:00
mhbliao 7703031d33 Fix hipExtLaunchMultiKernelMultiDevice refactoring. (#1714)
- Use the correct condition for HIP VDI runtime.

[ROCm/hip commit: e9da934ac6]
2019-12-06 09:49:17 -08:00
foreman ba2909e860 P4 to Git Change 2041756 by cpaquot@cpaquot-ocl-lc-lnx on 2019/12/06 00:27:07
SWDEV-213526 - [hip] OOM issue
	Restore lazy kernel uploads for 2.10 release.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#54 edit


[ROCm/hip commit: c1d63fbdbb]
2019-12-06 00:33:55 -05:00
Rahul Garg ebdd811632 Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.

[ROCm/hip commit: e53fc316f1]
2019-12-06 09:51:53 +05:30
foreman cac41c4251 P4 to Git Change 2040890 by skudchad@skudchad_test2_win_opencl on 2019/12/04 14:16:51
SWDEV-203814 - HIPRTC Inprocess runtime changes(part2)

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18342/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#37 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#35 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#50 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#73 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#38 edit


[ROCm/hip commit: 65fd472364]
2019-12-04 14:22:03 -05:00
foreman 764b1c6e2f P4 to Git Change 2040884 by jujiang@JJ-HIP on 2019/12/04 13:59:15
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
	-Update hipMemcpy3D function
	http://ocltc.amd.com/reviews/r/18346/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#90 edit


[ROCm/hip commit: 188a357527]
2019-12-04 14:06:53 -05:00
foreman 695236d0e7 P4 to Git Change 2040867 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/12/04 13:32:27
SWDEV-145570 - Adding back the lazy kernel changes because the OOM issue is because of KFD/RocR.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#53 edit


[ROCm/hip commit: a077140ae2]
2019-12-04 13:34:03 -05:00
Evgeny Mankov 90d5c25f69 Merge pull request #1712 from emankov/hipify
[HIPIFY] CUDA 10.2 (functions only)

[ROCm/hip commit: 496f0c53b3]
2019-12-04 18:39:10 +03:00
Evgeny Mankov 970724661d [HIPIFY] CUDA 10.2 (functions only)
+ Both Driver API and RT API are supported and synced with each other
+ Update *.md docs and hipify-perl accordingly
+ Add new conversion type "virtual_memory", introduced in Dirver API


[ROCm/hip commit: ec9b6a95a3]
2019-12-04 18:37:31 +03:00
Evgeny Mankov 8e620bc59b Merge pull request #1710 from emankov/hipify
[HIPIFY] CUDA 10.2 fp_16 support

[ROCm/hip commit: c518929fbc]
2019-12-04 13:28:43 +03:00
Evgeny Mankov c9d68c898f [HIPIFY] CUDA 10.2 fp_16 support
[ROCm/hip commit: e3c3c6d86e]
2019-12-04 13:27:46 +03:00
Maneesh Gupta 261b0a6f50 [packaging] Rename hip packages to conform to debian package renaming rules (#1708)
[ROCm/hip commit: 1f6b3e2aa5]
2019-12-04 15:55:37 +05:30
Evgeny Mankov 6a6aa3226d [HIPIFY] CUDA 10.2 support (data types only)
+ Both Driver API and RT API are supported and synced with each other
+ Update *.md docs and hipify-perl accordingly


[ROCm/hip commit: 5a03e8ccb9]
2019-12-04 12:25:20 +03:00
Rahul Garg fa87abd58a Fix hipMemcpyWithStream (#1707)
* Fix hipMemcpyWithStream
* Add a dtest for the same.


[ROCm/hip commit: 892d2a562e]
2019-12-04 11:56:23 +05:30
Aryan Salmanpour abe7531676 [hip] refactoring hipExtLaunchMultiKernelMultiDevice API (#1698)
[Background] it was found that if lazy linking used for a library that calls hipExtLaunchMultiKernelMultiDevice API then this API can get the wrong program_state object for looking up device kernels leading to a "No device code available" error in this API.

To fix this issue, the API was refactored to be inline and get and pass the correct program_state to an internal hip API to request a multi-device kernel launch.

[ROCm/hip commit: 68cc787781]
2019-12-04 11:50:51 +05:30
foreman 2fb6170da1 P4 to Git Change 2039536 by jujiang@JJ-HIP on 2019/12/02 14:31:13
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
	-Update ihipBindTexture

	http://ocltc.amd.com/reviews/r/18333/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#89 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#28 edit


[ROCm/hip commit: 69dcd2b862]
2019-12-02 13:37:35 -06:00
Maneesh Gupta ee44fffd35 Revert "[packaging] Conform to debian package naming rules (#1647)" (#1688)
This reverts commit 8016fa32df.

[ROCm/hip commit: 4585b7f6f3]
2019-12-01 14:47:43 +05:30
Evgeny Mankov 389263471e [HIPIFY] Sync cudaError/CUresult between CUDA Driver API/CUDA RT API/HIP
+ Update *.md docs and hipify-perl accordingly

[Reason]
Starting with CUDA 10.1 all error codes are merged between Driver and RT APIs

[ToDo]
Do the same merge in HIP API as there is no need in distinguishing return codes by API


[ROCm/hip commit: d33dd71ed3]
2019-11-29 19:29:11 +03:00
foreman b3e62f6283 P4 to Git Change 2038688 by jujiang@JJ-HIP on 2019/11/29 10:14:49
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
	- Update function hipMemcpy3D for Texture Array
	- Add  hipArrayCubemap support in hipMalloc3DArray

	http://ocltc.amd.com/reviews/r/18328/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#88 edit


[ROCm/hip commit: 5349bd8036]
2019-11-29 10:17:28 -05:00
Maneesh Gupta 4e564f783e Revert changes for atomic FADD support when address is in LDS (#1701)
This reverts PR #1591 and follow-on PR #1695

[ROCm/hip commit: 32442c6506]
2019-11-29 11:58:12 +05:30
Siu Chi Chan 7aee8f9803 add error checking for code object loading
[ROCm/hip commit: 6ecd303d94]
2019-11-28 14:00:48 -05:00
Alex Voicu dc9bc8ee86 Uniform is_shared query. (#1695)
[ROCm/hip commit: b6514fffb9]
2019-11-28 13:39:05 +05:30
foreman 3c4fa4941d P4 to Git Change 2037147 by kjayapra@1_HIPWS_LNX1_PAL on 2019/11/26 16:58:07
SWDEV-144570 - Adding hipMemcpyWithStream API

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#36 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#34 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#87 edit


[ROCm/hip commit: 601b88ad18]
2019-11-26 17:03:41 -05:00
Jeff Daily f1544b621d fix hipMempcy precondition, test for zero size first (#1697)
[ROCm/hip commit: 299bbe2325]
2019-11-25 19:03:03 -08:00
Anusha Godavarthy Surya 023ee64ecf replace array designator C99
[ROCm/hip commit: edf29b8673]
2019-11-25 16:51:49 +05:30
foreman 452d58f4c6 P4 to Git Change 2035631 by cpaquot@cpaquot-ocl-lc-lnx on 2019/11/22 17:52:20
SWDEV-213526 - pytorch tests fail with hipErrorOutofMemory
	There's a bug in ROCr when loading a lot of kernels and not syncing
	So for now, if an allocation fails, sync devices and retry before
	returning hipErrorOutOfMemory error.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#86 edit


[ROCm/hip commit: 5c5588bf20]
2019-11-22 17:56:07 -05:00
foreman a5b93415e5 P4 to Git Change 2035286 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/11/22 11:19:57
SWDEV-145570 - Revering CL 2033170

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#52 edit


[ROCm/hip commit: 90546b742e]
2019-11-22 11:29:49 -05:00
Alex Voicu f220a7592e Unary operators were too restrictive in the type of their argument. (#1683)
[ROCm/hip commit: aaf31b6b96]
2019-11-22 07:54:53 +05:30
Shyam Saladi c8c265891a [HIPIFY] fix typo (#1681)
[ROCm/hip commit: 70f457d7ea]
2019-11-22 07:54:37 +05:30
ansurya 92837d4b4d Fix rocBLAS compilation failure (#1677)
SWDEV-212749:
o Recent changes to “add support for extended launch” require hip_runtime.h to be include in hip_ext.h
o Order in which external applications include hip_hcc.h/hip_runtime.h causes compilation failure

[ROCm/hip commit: e60dec51da]
2019-11-22 07:54:17 +05:30
Alex Voicu fd08d068c7 Use native support for atomic FADD when address is in LDS (#1591)
[ROCm/hip commit: d597e7ca20]
2019-11-22 07:53:48 +05:30
foreman 428a92ad85 P4 to Git Change 2034910 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/11/21 19:28:10
SWDEV-145570 - Revering CL#2033779 for now.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#48 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#49 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#51 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#70 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#36 edit


[ROCm/hip commit: de09e11c0a]
2019-11-21 19:33:05 -05:00
satyanveshd 3848cd97ea fixed directed tests fail when hcc bumped to 3.0 (#1678)
Handled the HCC version check appropriately as few of the directed tests (SWDEV-212161) were failing when hcc was bumped to 3.0.

[ROCm/hip commit: 6b06911ef1]
2019-11-20 21:37:52 +05:30
Alex Voicu 1baa84eae4 General sync memcpy improvements. Add hipMemcpyWithStream (#1673)
* General sync memcpy improvements. Add `hipMemcpyWithStream`

* Update hip_memory.cpp


[ROCm/hip commit: 5a1f823739]
2019-11-20 21:36:37 +05:30
Rahul Garg 7e75cf12df Update error codes for hipGetDevice for doxygen and move up null check (#1668)
* [docs] Update error codes for hipGetDevice

* Move up out ptr check


[ROCm/hip commit: b3161e9fa0]
2019-11-20 21:35:27 +05:30
Paul Fultz II 27112bbdf0 Fix helper header when using c++17 (#1666)
This will fix issue #1621. It also adds tests for is_callable with c++11, c++14, and c++17.

The fallback implementation was completely broken so I rewrote it so it pass the tests as well. This should be used instead of PR #1631.

[ROCm/hip commit: 8519a1411c]
2019-11-20 21:33:42 +05:30
Alex Voicu 4ec70a7e03 Extend vector type capabilities and add tests to reflect it. (#1656)
[ROCm/hip commit: b5b3d1bbaa]
2019-11-20 21:32:32 +05:30
foreman 1c1f389beb P4 to Git Change 2033779 by kjayapra@0_HIPWS_LNX1_ROCM on 2019/11/20 07:17:56
SWDEV-144570 - Update function global during hipModuleLoad.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#47 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#48 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#50 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#69 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.hpp#35 edit


[ROCm/hip commit: 3705a045f0]
2019-11-20 07:24:20 -05:00
Sarbojit2019 6679cd3998 Revert [HIP] Fixed hipStreamAddCallback (#1674)
This reverts commit fa1e44aa0e.
Addresses SWDEV#212675.

[ROCm/hip commit: 153a959280]
2019-11-20 11:55:46 +05:30
foreman 0532eabcd1 P4 to Git Change 2033170 by cpaquot@cpaquot-ocl-lc-lnx on 2019/11/19 13:26:16
SWDEV-212215 - HIP-VDI runtime should not lazy load device code objects
	Temporarly disable lazy load of code objects for debugger.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#49 edit


[ROCm/hip commit: 02f8c57eb5]
2019-11-19 13:34:00 -05:00
Jeff Daily 492248ef12 hipStreamSynchronize can skip marker if stream is empty (#1667)
[ROCm/hip commit: 3a7eb694f5]
2019-11-19 09:42:43 -08:00
Rahul Garg f55b1cd6a4 [dtest] Rename hipExtLaunchMultiKernelMultiDevice dtest (#1671)
[ROCm/hip commit: 188752b2cb]
2019-11-19 09:41:13 -08:00
Sameer Sahasrabuddhe cfaf04a467 hostcall: add tests that are only used by the VDI build (#1664)
[ROCm/hip commit: 363caf29c6]
2019-11-18 19:52:40 -08:00
mhbliao 97646b52f1 Fix mathlib and app builds with hip-clang. (#1665)
[ROCm/hip commit: ebe0c56f4f]
2019-11-18 08:18:20 -08:00
Rahul Garg ecdba45d29 Fix gcc build on NVCC path (#1661)
* Fix gcc build on NVCC path

* Fix CI build errors

* [dtest] Fix texture and surface obj2D tests


[ROCm/hip commit: e39d7497ec]
2019-11-18 12:19:22 +05:30
Nick Curtis 05ef9bd386 fix complex conjugate for double-complex (#1659)
The sign in the y component returned from hipConj incorrect for double-complex. Fix to match as in hipConjf above.

[ROCm/hip commit: 3f2316086f]
2019-11-18 12:19:12 +05:30
Sarbojit2019 a4f2c7717f Added null check in hipEventSynchronize (#1627)
* Added missing null check in hipEventSynchronize
* Minor correction in the Event API description


[ROCm/hip commit: b865a50e44]
2019-11-18 12:18:55 +05:30