AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update error codes for hipGetDevice for doxygen and move up null check (#1668)

Browse Source 
* [docs] Update error codes for hipGetDevice

* Move up out ptr check


[ROCm/hip commit: b3161e9fa0]
This commit is contained in:
Rahul Garg
2019-11-20 08:05:27 -08:00
committed by Maneesh Gupta
parent 27112bbdf0
commit 7e75cf12df
2 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/hip/include/hip/hcc_detail/hip_runtime_api.h
+1 -1
View File
@@ -391,7 +391,7 @@ hipError_t hipSetDevice(int deviceId);
* This device is used implicitly for HIP runtime APIs called by this thread.
* hipGetDevice returns in * @p device the default device for the calling host thread.
*
* @returns #hipSuccess
* @returns #hipSuccess, #hipErrorInvalidDevice, #hipErrorInvalidValue
*
* @see hipSetDevice, hipGetDevicesizeBytes
*/
projects/hip/src/hip_device.cpp
+6 -8
View File
@@ -33,18 +33,16 @@ hipError_t hipGetDevice(int* deviceId) {
HIP_INIT_API(hipGetDevice, deviceId);
hipError_t e = hipSuccess;
if (deviceId == nullptr)
return ihipLogStatus(hipErrorInvalidValue);
auto ctx = ihipGetTlsDefaultCtx();
if (deviceId != nullptr) {
if (ctx == nullptr) {
e = hipErrorInvalidDevice; // TODO, check error code.
*deviceId = -1;
} else {
*deviceId = ctx->getDevice()->_deviceId;
}
if (ctx == nullptr) {
e = hipErrorInvalidDevice; // TODO, check error code.
*deviceId = -1;
} else {
e = hipErrorInvalidValue;
*deviceId = ctx->getDevice()->_deviceId;
}
return ihipLogStatus(e);