There's a typo in RegisterApiCallback, roctx::cb_table.Get should be
roctx::cb_table.Set.
Change-Id: I47ec8ac666f783ff4e03f35d13e375e645899900
[ROCm/roctracer commit: 0d7d56eea5]
The proxy queue implements packet interception to enable timestamps
collection. As it is, the roctracer is not intercepting packets, and
instead relies on the rocprofiler tool to collect the timestamps for
kernel dispatches.
This is an issue as the roctracer API does not implement HSA_OPS
activities for kernel dispatches. This will be addressed in a future
commit.
Change-Id: Ib6a778a513410bec4579f223a9d9e9fd9b6054df
[ROCm/roctracer commit: 6b06322578]
Building with -DLIBRARY_TYPE=STATIC fails with 3 undefined symbols.
Add weak symbols to satisfy the linker (mirror what is done for the
other Loader symbols).
Change-Id: I8a2878def21d5f500b0764ceacb4e5255e1111c5
[ROCm/roctracer commit: b352eedac6]
Backward comaptibility for components that search for contents in roctracer.h
Improvements: Removed redundant code for setting and unsetting variables
Added header template file in source code instead of generating it on build time
Change-Id: I96aeb7f2a6d53d45eb5aeb5300024cd22dad1324
[ROCm/roctracer commit: 8ca752ce2c]
Removing DEBUG_TRACES and the unnecessary use of roctracer_op_string, made the MS app reporting 78 to 81 stable samples per second, depending on the type of the trace, while the main app without rocprof reports 100 to 106. More detailed numbers will be posted in the ticket.
Change-Id: Ifbc529278cea54dd23e6086aa9b9ea2df952d5dd
[ROCm/roctracer commit: e4569c41fe]
Before this change, when a producer was blocked by a flush operation,
no other producer could write to the memory pool. This change allows
other producer threads to continue to write by releasing the producer
lock before waiting on the consumer condition variable.
Change-Id: Idc1c07173d2edb18fbe1a61961f10c02e7ca8c20
[ROCm/roctracer commit: dc8717a6b5]
HCC_EXC_RAISING and HIP_EXC_RAISING don't add much value, so to
simplify, only keep EXC_RAISING and EXC_ABORT.
Change-Id: Ifdc54981bb682fe68b418cdc95ecebe668e3dcf6
[ROCm/roctracer commit: 121a84b449]
The HCC runtime is no longer used, so move all the remaining
activities in the HipApi loader and remove the HccLoader.
Change-Id: I845c04ca275a474526840315bae0ad1a4ce02257
[ROCm/roctracer commit: 85552ea3a0]
roctracer_hip.h now contains the definitions for the HCC_OPS domain.
Change-Id: I132c993110254050aaa68828f3ca80f368ad24bc
[ROCm/roctracer commit: d3b166cf01]
It only defines one class (hip_act_cb_tracker_t) that is only used
by roctracer.cpp.
Change-Id: I375a25bd363770d70a7b3b713223484a498cc3d1
[ROCm/roctracer commit: c009df3327]
Use the standard concurrent support library (std::thread, std::mutex,
st::condition_variable) instead of pthread.
Fix a mismatched memory allocation/deallocation when a custom allocator
is provided. The MemoryPool destructor was always using the default
allocator (using malloc/realloc/free) even if the pool memory was
allocated with the custom allocator.
Fix various thread safety issues and inefficiencies (spin loops).
Change-Id: I97592caa947f63463041bf43e00af9ebb5ff5886
[ROCm/roctracer commit: 9d728f74a1]
Move roctracer_cb_table.h to the src/core directory, as it should not
be exposed as a public header, and rename it callback_table.h
Change-Id: Ib448cbd32a275df0268d53bd8d1da0bdc9201470
[ROCm/roctracer commit: cd62d841fa]
This reverts commit 35ea06abd0.
Reason for revert: Merged by mistake
Change-Id: I8c39c823d92cc20a238ca6120dde4b2fa9121e85
[ROCm/roctracer commit: 57add1a6fa]
Removing DEBUG_TRACES and the unnecessary use of roctracer_op_string, made the MS app reporting 78 to 81 stable samples per second, depending on the type of the trace, while the main app without rocprof reports 100 to 106. More detailed numbers will be posted in the ticket.
Change-Id: Ida25d3bfc72047afaa27326d697be76d97564334
[ROCm/roctracer commit: e7327aaac7]
Exchanging the git clone of the hsa-class to a local downloaded version pushed to the roctracer repo
Change-Id: Id45a38b2d355102c2e0dee1e4bfde50398369047
[ROCm/roctracer commit: 7ee4f87b73]
Include the upgrade operation check in the prerm script
in package.
Signed-off-by: Saravanan Solaiyappan <saravanan.solaiyappan@amd.com>
Change-Id: I1504ce96a27d21d9c3d9bafc0dea8055398adc99
[ROCm/roctracer commit: bfea525ff3]
Changing pthread_yield() to sched_yield() as pthread_yield() is deprecated in CentOS 9
Change-Id: I2961b61374e36995d0835f0e65b26c35f5eb8715
[ROCm/roctracer commit: 43a36f8dd5]
Removing the RPATH skip & Removing the install path that was defined CMakelist
Change-Id: Icf374b9548fc7b24e99a1b5ab9720ce6d775abf8
[ROCm/roctracer commit: 8098ec6acf]
To fix the issue we modified CMakeLists.txt as described in Sparry Icarus comment
Change-Id: Ie9ca16cfcfb7b7a9a858f0fb1f5071923c787313
[ROCm/roctracer commit: 554011e767]
Making the new License file, Adding support in the CMakeLists.txt
Change-Id: I43862b8b7f3025ae6200aeb442ea70c7993a7349
[ROCm/roctracer commit: b721e3209e]
The manually written Makefiles in the test directory are not safe to
use by more than one job. For example we see things like
all: clean $(EXECUTABLE)
which says that the 'all' target depends on the 'clean' and
'$(EXECUTABLE)' targets. If make is invoked with -j2 then the clean
and '${EXECUTABLE}' can be built in parallel, so the clean can delete
things whilst they are being built!
Change-Id: I9c56db4c629081b8d812dad45dfd4afde10e481f
Signed-off-by: Icarus Sparry <icarus.sparry@amd.com>
[ROCm/roctracer commit: 8ea268b3f4]
on_exit() registered exit_handler function, but in the case of OpenMP applications the registered exit func exit_handler was called after the dlclose of the library. So we removed exit_handler from roctracer as it is already handled in both rocprofiler and rocprof script.
Change-Id: I7c3d42e6ccc282e713b48b4a7faec4935e7a2600
[ROCm/roctracer commit: aa41554130]
Changing correlation_id_map to static instance instead of being a pointer and fixing the corresponding references
Change-Id: Id8a481a90b46831f91985a7e0523fd2869991aeb
[ROCm/roctracer commit: 1e3ed06a9a]
Laurent Morichetti
Ranjith Ramakrishnan
Ammar ELWazir
Tony Tye
Saravanan Solaiyappan
Saurabh Verma
Kiumars Sabeti
Icarus Sparry
Christophe Paquot