AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Address review comments from previous commit

Browse Source 
Change-Id: I6629dd911de0d7fd08d7a863c172ec73f35fa3d1


[ROCm/roctracer commit: dc22139977]
This commit is contained in:
Laurent Morichetti
2022-04-19 14:09:20 -07:00
committed by Laurent Morichetti
parent 23528f51e0
commit 2a2852048f
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/roctracer/src/core/roctracer.cpp
-1
View File
@@ -763,7 +763,6 @@ static inline uint32_t get_op_end(uint32_t domain) {
return HIP_OP_ID_NUMBER;
case ACTIVITY_DOMAIN_HIP_API:
return HIP_API_ID_LAST + 1;
;
case ACTIVITY_DOMAIN_EXT_API:
return 0;
case ACTIVITY_DOMAIN_ROCTX:
projects/roctracer/src/proxy/simple_proxy_queue.h
+1 -1
View File
@@ -124,7 +124,7 @@ class SimpleProxyQueue : public ProxyQueue {
// Compute the write index of queue
const uint64_t que_idx = hsa_queue_load_write_index_relaxed_fn(queue_);
// Waiting untill there is a free space in the queue
// Waiting until there is a free space in the queue
while (que_idx >= (hsa_queue_load_read_index_relaxed_fn(queue_) + size_))
;
projects/roctracer/src/util/logger.h
+3 -3
View File
@@ -190,9 +190,9 @@ class Logger {
#define DBG_LOGGING(stream) \
do { \
roctracer::util::Logger::Instance() \
<< roctracer::util::Logger::begm << "debug: \"" << stream << "\"" < < < < \
" in " << __FUNCTION__ << " at " << __FILE__ << " line " << __LINE__ \
<< roctracer::util::Logger::endl; \
<< roctracer::util::Logger::begm << "debug: \"" << stream << "\"" \
<< " in " << __FUNCTION__ << " at " << __FILE__ << " line " << __LINE__ \
<< roctracer::util::Logger::endl; \
} while (0)
#endif