SWDEV-2 - Change OpenCL version number from 2364 to 2365.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2111 edit
[ROCm/clr commit: 7a69d56c1f]
SWDEV-2 - Change OpenCL version number from 2364 to 2365.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2111 edit
commit 931d3de6c1c903cfd47842bc5026a9294ac492b4
Author: Siu Chi Chan <siuchi.chan@amd.com>
Date: Mon Feb 13 10:54:06 2017 -0500
only force to libstdc++ if the g++ is older than version 5 since hcc already defaults to libstdc++ with newer g++
commit 1ef8d71aa788de7b9eead4906fe56186f06d7d3f
Author: scchan <siuchi.chan@amd.com>
Date: Sun Feb 12 14:44:11 2017 -0500
remove hardcoded -lc++ in tests
commit 5d99ef338eb3a66523cc9ddd139e86c6fd707b9c
Author: scchan <siuchi.chan@amd.com>
Date: Sun Feb 12 14:35:46 2017 -0500
force include libstdc++ headers and stdc++ only if g++ version < 5 since hcc uses libstdc++ by default if g++ > 5 is present
commit a2bc21b24d100feefe91cd3cb2271238bda0738a
Author: scchan <siuchi.chan@amd.com>
Date: Fri Feb 10 04:36:27 2017 -0500
use hcc-config to generate compiler and linker flags
Change-Id: I13a79629c0adfd75439a47d0488ff4fd619c55ba
(cherry picked from commit 866e744e40cf1378af8a679b54959bf5226c340f)
[ROCm/clr commit: ca8045e6e4]
commit 931d3de6c1c903cfd47842bc5026a9294ac492b4
Author: Siu Chi Chan <siuchi.chan@amd.com>
Date: Mon Feb 13 10:54:06 2017 -0500
only force to libstdc++ if the g++ is older than version 5 since hcc already defaults to libstdc++ with newer g++
commit 1ef8d71aa788de7b9eead4906fe56186f06d7d3f
Author: scchan <siuchi.chan@amd.com>
Date: Sun Feb 12 14:44:11 2017 -0500
remove hardcoded -lc++ in tests
commit 5d99ef338eb3a66523cc9ddd139e86c6fd707b9c
Author: scchan <siuchi.chan@amd.com>
Date: Sun Feb 12 14:35:46 2017 -0500
force include libstdc++ headers and stdc++ only if g++ version < 5 since hcc uses libstdc++ by default if g++ > 5 is present
commit a2bc21b24d100feefe91cd3cb2271238bda0738a
Author: scchan <siuchi.chan@amd.com>
Date: Fri Feb 10 04:36:27 2017 -0500
use hcc-config to generate compiler and linker flags
Change-Id: I13a79629c0adfd75439a47d0488ff4fd619c55ba
(cherry picked from commit 866e744e40cf1378af8a679b54959bf5226c340f)
commit 931d3de6c1c903cfd47842bc5026a9294ac492b4
Author: Siu Chi Chan <siuchi.chan@amd.com>
Date: Mon Feb 13 10:54:06 2017 -0500
only force to libstdc++ if the g++ is older than version 5 since hcc already defaults to libstdc++ with newer g++
commit 1ef8d71aa788de7b9eead4906fe56186f06d7d3f
Author: scchan <siuchi.chan@amd.com>
Date: Sun Feb 12 14:44:11 2017 -0500
remove hardcoded -lc++ in tests
commit 5d99ef338eb3a66523cc9ddd139e86c6fd707b9c
Author: scchan <siuchi.chan@amd.com>
Date: Sun Feb 12 14:35:46 2017 -0500
force include libstdc++ headers and stdc++ only if g++ version < 5 since hcc uses libstdc++ by default if g++ > 5 is present
commit a2bc21b24d100feefe91cd3cb2271238bda0738a
Author: scchan <siuchi.chan@amd.com>
Date: Fri Feb 10 04:36:27 2017 -0500
use hcc-config to generate compiler and linker flags
Change-Id: I13a79629c0adfd75439a47d0488ff4fd619c55ba
(cherry picked from commit 866e744e40cf1378af8a679b54959bf5226c340f)
[ROCm/hip commit: 806deeb476]
commit 931d3de6c1c903cfd47842bc5026a9294ac492b4
Author: Siu Chi Chan <siuchi.chan@amd.com>
Date: Mon Feb 13 10:54:06 2017 -0500
only force to libstdc++ if the g++ is older than version 5 since hcc already defaults to libstdc++ with newer g++
commit 1ef8d71aa788de7b9eead4906fe56186f06d7d3f
Author: scchan <siuchi.chan@amd.com>
Date: Sun Feb 12 14:44:11 2017 -0500
remove hardcoded -lc++ in tests
commit 5d99ef338eb3a66523cc9ddd139e86c6fd707b9c
Author: scchan <siuchi.chan@amd.com>
Date: Sun Feb 12 14:35:46 2017 -0500
force include libstdc++ headers and stdc++ only if g++ version < 5 since hcc uses libstdc++ by default if g++ > 5 is present
commit a2bc21b24d100feefe91cd3cb2271238bda0738a
Author: scchan <siuchi.chan@amd.com>
Date: Fri Feb 10 04:36:27 2017 -0500
use hcc-config to generate compiler and linker flags
Change-Id: I13a79629c0adfd75439a47d0488ff4fd619c55ba
(cherry picked from commit 866e744e40cf1378af8a679b54959bf5226c340f)
https://github.com/GPUOpen-ProfessionalCompute-Tools/HIP/issues/65
[Bug]
Access violation in cudaStructVar matcher.
StringRef name = structVar->getType()
->getAsStructureType()
->getDecl() // <--- Access Violation
->getNameAsString();
[Solution]
Add isStructureType() check before getting type as Struct.
[ToDo]
Find case-studies for that StructVar matcher with types other than Struct.
[ROCm/clr commit: 7c1deb6140]
https://github.com/GPUOpen-ProfessionalCompute-Tools/HIP/issues/65
[Bug]
Access violation in cudaStructVar matcher.
StringRef name = structVar->getType()
->getAsStructureType()
->getDecl() // <--- Access Violation
->getNameAsString();
[Solution]
Add isStructureType() check before getting type as Struct.
[ToDo]
Find case-studies for that StructVar matcher with types other than Struct.
https://github.com/GPUOpen-ProfessionalCompute-Tools/HIP/issues/65
[Bug]
Access violation in cudaStructVar matcher.
StringRef name = structVar->getType()
->getAsStructureType()
->getDecl() // <--- Access Violation
->getNameAsString();
[Solution]
Add isStructureType() check before getting type as Struct.
[ToDo]
Find case-studies for that StructVar matcher with types other than Struct.
[ROCm/hip commit: 950434f4af]
https://github.com/GPUOpen-ProfessionalCompute-Tools/HIP/issues/65
[Bug]
Access violation in cudaStructVar matcher.
StringRef name = structVar->getType()
->getAsStructureType()
->getDecl() // <--- Access Violation
->getNameAsString();
[Solution]
Add isStructureType() check before getting type as Struct.
[ToDo]
Find case-studies for that StructVar matcher with types other than Struct.
SWDEV-112401 - [OCLonROCm vs LinuxPro][Fiji][Perf] Around ~ 70% performance drop observed with OCL SDK - BlackScholes test
- Switch persistent emulation to device memory instead of system memory, since ROCr doesn't support visible heap without large bar. It's a potential tradeoff of persistent usage in the applications between an upload buffer or directly in a kernel.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#11 edit
[ROCm/clr commit: faf83743d8]
SWDEV-112401 - [OCLonROCm vs LinuxPro][Fiji][Perf] Around ~ 70% performance drop observed with OCL SDK - BlackScholes test
- Switch persistent emulation to device memory instead of system memory, since ROCr doesn't support visible heap without large bar. It's a potential tradeoff of persistent usage in the applications between an upload buffer or directly in a kernel.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocmemory.cpp#11 edit
CUstream_st -> hipStream_t *
CUevent_st -> hipEvent_t * (fixed, was -> hipEvent_t)
Warning:
[HIPIFY] warning: the following reference is not handled: 'CUstream_st' [struct var ptr]. (thrust/examples/cuda/async_reduce.cu)
[ROCm/clr commit: ce2daa53fb]
CUstream_st -> hipStream_t *
CUevent_st -> hipEvent_t * (fixed, was -> hipEvent_t)
Warning:
[HIPIFY] warning: the following reference is not handled: 'CUstream_st' [struct var ptr]. (thrust/examples/cuda/async_reduce.cu)
CUstream_st -> hipStream_t *
CUevent_st -> hipEvent_t * (fixed, was -> hipEvent_t)
Warning:
[HIPIFY] warning: the following reference is not handled: 'CUstream_st' [struct var ptr]. (thrust/examples/cuda/async_reduce.cu)
[ROCm/hip commit: a6db38c337]
CUstream_st -> hipStream_t *
CUevent_st -> hipEvent_t * (fixed, was -> hipEvent_t)
Warning:
[HIPIFY] warning: the following reference is not handled: 'CUstream_st' [struct var ptr]. (thrust/examples/cuda/async_reduce.cu)
[Explanation]
Narrow cudaKernelCallExpr matcher to isExpansionInMainFile() - to the file being actually converted (without system includes).
But as for Thrust, there are *.inl files, which are nevertheless being expanded in main file.
These files contain cuda kernel launches, which are not converted successfully by hipify, for instance:
thrust/system/cuda/detail/detail/launch_closure.inl:98:23.
[ToDo]
File a bug on cudaKernelCallExpr matcher for conversion error (thrust\examples\cuda\<any cu example>).
[ROCm/clr commit: afe6073d3f]
[Explanation]
Narrow cudaKernelCallExpr matcher to isExpansionInMainFile() - to the file being actually converted (without system includes).
But as for Thrust, there are *.inl files, which are nevertheless being expanded in main file.
These files contain cuda kernel launches, which are not converted successfully by hipify, for instance:
thrust/system/cuda/detail/detail/launch_closure.inl:98:23.
[ToDo]
File a bug on cudaKernelCallExpr matcher for conversion error (thrust\examples\cuda\<any cu example>).
[Explanation]
Narrow cudaKernelCallExpr matcher to isExpansionInMainFile() - to the file being actually converted (without system includes).
But as for Thrust, there are *.inl files, which are nevertheless being expanded in main file.
These files contain cuda kernel launches, which are not converted successfully by hipify, for instance:
thrust/system/cuda/detail/detail/launch_closure.inl:98:23.
[ToDo]
File a bug on cudaKernelCallExpr matcher for conversion error (thrust\examples\cuda\<any cu example>).
[ROCm/hip commit: d1cfcf55f1]
Evgeny Mankov
foreman
Siu Chi Chan
Ramesh Errabolu
James Edwards