76333 Commity

Autor SHA1 Wiadomość Data
Giovanni LB 637abbf8d7 SWDEV-474615: Adding barrier bit to read and stop packets
Change-Id: I895dc7389d870ed111ac3b9c400e6946023ffe97
2024-07-19 12:45:52 -03:00
Giovanni LB 6fd4edbd29 SWDEV-474615: Adding barrier bit to read and stop packets
Change-Id: I895dc7389d870ed111ac3b9c400e6946023ffe97


[ROCm/rocprofiler commit: 637abbf8d7]
2024-07-19 12:45:52 -03:00
Maisam Arif 3a9c93bfa6 Updated Changelog with Mutex Fix
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I0aee284ce7600efc66b0ad5392c11bb6a502a929
2024-07-19 11:18:09 -04:00
Maisam Arif 49e4e8f234 Updated Changelog with Mutex Fix
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I0aee284ce7600efc66b0ad5392c11bb6a502a929


[ROCm/amdsmi commit: 3a9c93bfa6]
2024-07-19 11:18:09 -04:00
Wenkai Du 54e4899607 Template unroll for RCCL kernels (#1250)
* Template unroll for RCCL kernels

* Adding unroll template arg during CMake hipification

* Reduce linking parallel jobs to avoid OOM in CI

* Workaround issues with UT tests

SWDEV-469533: register spill fix is needed for mainline build
LWPCOMMLIBS-369: cannot enable 112 channels with 80 CUs
Use -parallel-jobs=8 for linking

* CI: do not use -j 16 when building

* CI: use -j 8 when building

* Only reduce parallel linking job for CI extended

* Restore original jenkins command. Change parallel linking jobs in cmake

* Disable MSCCLPP

---------

Co-authored-by: gilbertlee-amd <gilbert.lee@amd.com>

[ROCm/rccl commit: 89349f2ce4]
2024-07-19 08:15:59 -07:00
Wenkai Du 89349f2ce4 Template unroll for RCCL kernels (#1250)
* Template unroll for RCCL kernels

* Adding unroll template arg during CMake hipification

* Reduce linking parallel jobs to avoid OOM in CI

* Workaround issues with UT tests

SWDEV-469533: register spill fix is needed for mainline build
LWPCOMMLIBS-369: cannot enable 112 channels with 80 CUs
Use -parallel-jobs=8 for linking

* CI: do not use -j 16 when building

* CI: use -j 8 when building

* Only reduce parallel linking job for CI extended

* Restore original jenkins command. Change parallel linking jobs in cmake

* Disable MSCCLPP

---------

Co-authored-by: gilbertlee-amd <gilbert.lee@amd.com>
2024-07-19 08:15:59 -07:00
kjayapra-amd cf28e2b27a SWDEV-439234 - Implement Set/Get Access APIs in PAL/Windows.
Change-Id: I997c330880da70c5128b187e1ef4d9c449218880


[ROCm/clr commit: 11817b4405]
2024-07-19 10:42:41 -04:00
kjayapra-amd 11817b4405 SWDEV-439234 - Implement Set/Get Access APIs in PAL/Windows.
Change-Id: I997c330880da70c5128b187e1ef4d9c449218880
2024-07-19 10:42:41 -04:00
Joseph Macaranas a4ca86d266 External CI: Add triggers for mainline branch (#388)
[ROCm/rocdecode commit: 59ec12d012]
2024-07-19 09:15:24 -04:00
Joseph Macaranas 59ec12d012 External CI: Add triggers for mainline branch (#388) 2024-07-19 09:15:24 -04:00
Galantsev, Dmitrii baaa1cc4b6 [SWDEV-471523] - Replace lspci and lscpu with sysfs reads
Change-Id: Ia5a12c04d3064787a0f36a961e68533b79e17ed0
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-07-19 00:29:36 -05:00
Galantsev, Dmitrii 12143a4ec8 [SWDEV-471523] - Replace lspci and lscpu with sysfs reads
Change-Id: Ia5a12c04d3064787a0f36a961e68533b79e17ed0
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: baaa1cc4b6]
2024-07-19 00:29:36 -05:00
Galantsev, Dmitrii 0f6224cbe6 Merge branch 'dgalants/fix_mutex' into amd-dev
This change imports changes done to shared_mutex in rocm_smi_lib repo

Change-Id: I1412440b52a3419127b03003df3cc36fa71875d4
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-07-18 21:14:34 -05:00
Galantsev, Dmitrii 8f04a0f91e Merge branch 'dgalants/fix_mutex' into amd-dev
This change imports changes done to shared_mutex in rocm_smi_lib repo

Change-Id: I1412440b52a3419127b03003df3cc36fa71875d4
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 0f6224cbe6]
2024-07-18 21:14:34 -05:00
Bill(Shuzhou) Liu 78ee3f5e5a Remove thread safe only mutex warning message
In multiple GPUs environment, too many warning messages generated,
and then need to be removed.

Change-Id: I275de2397eb0e6b189e2e17e94335cb1e8f97815
2024-07-18 20:43:57 -05:00
Bill(Shuzhou) Liu 39f37c5d33 Remove thread safe only mutex warning message
In multiple GPUs environment, too many warning messages generated,
and then need to be removed.

Change-Id: I275de2397eb0e6b189e2e17e94335cb1e8f97815


[ROCm/amdsmi commit: 78ee3f5e5a]
2024-07-18 20:43:57 -05:00
Bill(Shuzhou) Liu dbba33d3f5 Support thread only mutex
The environment variable RSMI_MUTEX_THREAD_ONLY=1 to enable thread only mutex.
The RSMI_INIT_FLAG_THRAD_ONLY_MUTEX can also be pass to rsmi_init()
to enable thread only mutex.

Change-Id: I2d9844039b774e386f03bb9bb130d8c342504ea6
2024-07-18 20:43:38 -05:00
Bill(Shuzhou) Liu a1aec9c971 Support thread only mutex
The environment variable RSMI_MUTEX_THREAD_ONLY=1 to enable thread only mutex.
The RSMI_INIT_FLAG_THRAD_ONLY_MUTEX can also be pass to rsmi_init()
to enable thread only mutex.

Change-Id: I2d9844039b774e386f03bb9bb130d8c342504ea6


[ROCm/amdsmi commit: dbba33d3f5]
2024-07-18 20:43:38 -05:00
Bill(Shuzhou) Liu 06b9232a56 Unlock the mutex when process is dead
After the dead process is detected, pthread_mutex_consistent() will
be called. After that, the pthread_mutex_unlock() should also be
called to unlock it: "It is the responsibility of the application to
recover the state so it can be reused."

Change-Id: I45d3e2e68c3b06779f3acb1e908dbec0c6a39297
2024-07-18 20:43:21 -05:00
Bill(Shuzhou) Liu eb04dbc1c9 Unlock the mutex when process is dead
After the dead process is detected, pthread_mutex_consistent() will
be called. After that, the pthread_mutex_unlock() should also be
called to unlock it: "It is the responsibility of the application to
recover the state so it can be reused."

Change-Id: I45d3e2e68c3b06779f3acb1e908dbec0c6a39297


[ROCm/amdsmi commit: 06b9232a56]
2024-07-18 20:43:21 -05:00
Bill(Shuzhou) Liu 33dab0c232 Remove const to avoid compile error
Fix the compile error

Change-Id: I422b606b2b969b418c2e77b47a3afad0cfc732a1
2024-07-18 18:15:43 -04:00
Bill(Shuzhou) Liu 3fc94657d9 Remove const to avoid compile error
Fix the compile error

Change-Id: I422b606b2b969b418c2e77b47a3afad0cfc732a1


[ROCm/amdsmi commit: 33dab0c232]
2024-07-18 18:15:43 -04:00
Maisam Arif 8f15c22606 Fix amd-smi event from reading NONE event type
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I7acf91eb682b3f0873ca34a98191eafd3925a344
2024-07-18 17:54:08 -04:00
Maisam Arif df6b8386cf Fix amd-smi event from reading NONE event type
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I7acf91eb682b3f0873ca34a98191eafd3925a344


[ROCm/amdsmi commit: 8f15c22606]
2024-07-18 17:54:08 -04:00
Maisam Arif b5f9e6a91d Corrected passthrough platform logic
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: Ibbc4f5dd6300efd16f26efe17bc68eb8c22ed8be
2024-07-18 17:54:02 -04:00
Maisam Arif 244587525a Corrected passthrough platform logic
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: Ibbc4f5dd6300efd16f26efe17bc68eb8c22ed8be


[ROCm/amdsmi commit: b5f9e6a91d]
2024-07-18 17:54:02 -04:00
Maisam Arif 5b7be3bf99 [SWDEV-474474] - Changed Monitor PCIE_REPLAY count to use gpu_metrics
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I4351a23e8412875bb4b23b30747ac6d0bf3d3c56
2024-07-18 17:53:49 -04:00
Maisam Arif ad3ba88ba5 [SWDEV-474474] - Changed Monitor PCIE_REPLAY count to use gpu_metrics
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I4351a23e8412875bb4b23b30747ac6d0bf3d3c56


[ROCm/amdsmi commit: 5b7be3bf99]
2024-07-18 17:53:49 -04:00
Maisam Arif 0fc779b14f [SWDEV-439701] Add missing parameter CLI error cases
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I8a6623ccdd7b16be320ea0f6f48b7b6cb3511983
2024-07-18 14:24:00 -04:00
Maisam Arif a7ea536524 [SWDEV-439701] Add missing parameter CLI error cases
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I8a6623ccdd7b16be320ea0f6f48b7b6cb3511983


[ROCm/amdsmi commit: 0fc779b14f]
2024-07-18 14:24:00 -04:00
Alex Sierra 626eb4bfaf src/fmm.c: fallback to old userptr reg if SVM fails
Fallback to old userptr registration in case SVM method fails.

Signed-off-by: Alex Sierra <alex.sierra@amd.com>
Change-Id: I70c3ec74a8b4f762713e6a0619453642f3fca8e5
Signed-off-by: Chris Freehill <cfreehil@amd.com>
2024-07-18 10:20:05 -05:00
Alex Sierra 006d1d4dc7 src/fmm.c: fallback to old userptr reg if SVM fails
Fallback to old userptr registration in case SVM method fails.

Signed-off-by: Alex Sierra <alex.sierra@amd.com>
Change-Id: I70c3ec74a8b4f762713e6a0619453642f3fca8e5
Signed-off-by: Chris Freehill <cfreehil@amd.com>


[ROCm/ROCR-Runtime commit: 626eb4bfaf]
2024-07-18 10:20:05 -05:00
Adam Niederer 84567b6416 Allow overriding gfx version per-node
This lets you run two unsupported-but-really-supported cards of different architecture together in the same program. Works great w/ llama.cpp on my 7900XT + 6600.

Example usage (device 0 is RDNA3, device 1 is RDNA2):

HSA_OVERRIDE_GFX_VERSION_1="11.0.0" HSA_OVERRIDE_GFX_VERSION_2="10.3.0" ollama serve

Change-Id: Ic63ef462f698dee722d360f7fc3ef72789c277b7
Signed-off-by: AdamNiederer
Signed-off-by: Kent Russell <kent.russell@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>
2024-07-18 10:20:05 -05:00
Adam Niederer ffafd46406 Allow overriding gfx version per-node
This lets you run two unsupported-but-really-supported cards of different architecture together in the same program. Works great w/ llama.cpp on my 7900XT + 6600.

Example usage (device 0 is RDNA3, device 1 is RDNA2):

HSA_OVERRIDE_GFX_VERSION_1="11.0.0" HSA_OVERRIDE_GFX_VERSION_2="10.3.0" ollama serve

Change-Id: Ic63ef462f698dee722d360f7fc3ef72789c277b7
Signed-off-by: AdamNiederer
Signed-off-by: Kent Russell <kent.russell@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>


[ROCm/ROCR-Runtime commit: 84567b6416]
2024-07-18 10:20:05 -05:00
Tim Huang 06242b70e7 kfdtest: add blacklist for gfx1152
Change-Id: I74c957539c138160ed379aea7e1fa253d7648175
Signed-off-by: Tim Huang <tim.huang@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>
2024-07-18 10:20:05 -05:00
Tim Huang 516199b400 kfdtest: add blacklist for gfx1152
Change-Id: I74c957539c138160ed379aea7e1fa253d7648175
Signed-off-by: Tim Huang <tim.huang@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>


[ROCm/ROCR-Runtime commit: 06242b70e7]
2024-07-18 10:20:05 -05:00
David Belanger 611911020c kfdtest: Fix DeviceHdpFlush on GFX12
Fix register COMPUTE_PGM_RSRC2 in Dispatch code.
Bit 6 (called TRAP_PRESENT on pre-GFX12) should not be set on GFX12
as it has a different meaning (DYNAMIC_VGPR).

Minor instructions changes for CopyOnSignalIsa and WriteAndSignalIsa
shaders.

Change-Id: Ib4e75e3c92f220210bc45778738d81b91efb9d5e
Signed-off-by: David Belanger <david.belanger@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>
2024-07-18 10:20:05 -05:00
David Belanger b2d09b7e8d kfdtest: Fix DeviceHdpFlush on GFX12
Fix register COMPUTE_PGM_RSRC2 in Dispatch code.
Bit 6 (called TRAP_PRESENT on pre-GFX12) should not be set on GFX12
as it has a different meaning (DYNAMIC_VGPR).

Minor instructions changes for CopyOnSignalIsa and WriteAndSignalIsa
shaders.

Change-Id: Ib4e75e3c92f220210bc45778738d81b91efb9d5e
Signed-off-by: David Belanger <david.belanger@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>


[ROCm/ROCR-Runtime commit: 611911020c]
2024-07-18 10:20:05 -05:00
Kent Russell bd2d9770f7 kfdtest: Add required LLVM header
A function call was refactored out of CommandLine.h, so add the header
to include it

Change-Id: If5594e3abc2fdfdd59f108c4379802cedab127ee
Signed-off-by: Kent Russell <kent.russell@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>
2024-07-18 10:20:05 -05:00
Kent Russell 856c8d3e10 kfdtest: Add required LLVM header
A function call was refactored out of CommandLine.h, so add the header
to include it

Change-Id: If5594e3abc2fdfdd59f108c4379802cedab127ee
Signed-off-by: Kent Russell <kent.russell@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>


[ROCm/ROCR-Runtime commit: bd2d9770f7]
2024-07-18 10:20:05 -05:00
Philip Yang 42df8b2b34 kfdtest: Skip ContiguousVRAMAllocation if no enough VRAM
RDMATest.ContiguousVRAMAllocation test uses 4GB buffer, skip the test if
total VRAM size is less than 5GB, considering page table and other
reserved VRAM usage.

Change-Id: I0342417501cdd3477c2bf1b2f7d1e6bef61d1871
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>
2024-07-18 10:20:05 -05:00
Philip Yang b6e18ceeae kfdtest: Skip ContiguousVRAMAllocation if no enough VRAM
RDMATest.ContiguousVRAMAllocation test uses 4GB buffer, skip the test if
total VRAM size is less than 5GB, considering page table and other
reserved VRAM usage.

Change-Id: I0342417501cdd3477c2bf1b2f7d1e6bef61d1871
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
Signed-off-by: Chris Freehill <cfreehil@amd.com>


[ROCm/ROCR-Runtime commit: 42df8b2b34]
2024-07-18 10:20:05 -05:00
Chris Freehill 9e8477e1c9 Use static drm and drm_amdgpu for static builds
This commit was ported from old repo.
Original author: Ranjith Ramakrishnan <Ranjith.Ramakrishnan@amd.com>

For static builds use drm and drm_amdgpu static libraries for linking.

Created a separate cmake target file and static library for static use case

The config file will include the respective target file based on
BUILD_SHARED_LIBS.

Default target file will be the one where drm and libdrm_amdgpu shaed libraries
are linked.

Applications using statically linked cmake targets of hsakmt should install the
required static libraries before building.

Change-Id: Idf4e1a2b5f18b344f5a9927803756d50c2b33702
2024-07-18 10:19:49 -05:00
Chris Freehill 405b60af73 Use static drm and drm_amdgpu for static builds
This commit was ported from old repo.
Original author: Ranjith Ramakrishnan <Ranjith.Ramakrishnan@amd.com>

For static builds use drm and drm_amdgpu static libraries for linking.

Created a separate cmake target file and static library for static use case

The config file will include the respective target file based on
BUILD_SHARED_LIBS.

Default target file will be the one where drm and libdrm_amdgpu shaed libraries
are linked.

Applications using statically linked cmake targets of hsakmt should install the
required static libraries before building.

Change-Id: Idf4e1a2b5f18b344f5a9927803756d50c2b33702


[ROCm/ROCR-Runtime commit: 9e8477e1c9]
2024-07-18 10:19:49 -05:00
Nilesh M Negi 73e17b3e70 Consistent channel shuffling for MI300X multi-node (#1255)
* Revert "[GRAPH] Use channel shuffling only for IB systems (#1228)"

This reverts commit 8a7dd0e590.

* Revert "Revert "Changing channel stride for MI300X multinode (#1196)" (#1224)"

This reverts commit bb6fab3d8e.

[ROCm/rccl commit: a1ef217b32]
2024-07-18 10:18:09 -05:00
Nilesh M Negi a1ef217b32 Consistent channel shuffling for MI300X multi-node (#1255)
* Revert "[GRAPH] Use channel shuffling only for IB systems (#1228)"

This reverts commit 5be3b713ef.

* Revert "Revert "Changing channel stride for MI300X multinode (#1196)" (#1224)"

This reverts commit ad31d93f3d.
2024-07-18 10:18:09 -05:00
Ammar ELWazir 79257d82f2 Open Source Contributions (#750)
* Create CONTRIBUTING.md 

Adding ROCm needed files for Open source development.

* Create CODEOWNERS

* Adding issue templates

* Addressing review comments

---------

Co-authored-by: Ammar ELWazir <aelwazir@hpe6u-21.amd.com>
Co-authored-by: gobhardw <gopesh.bhardwaj@amd.com>

[ROCm/rocprofiler-sdk commit: b8a22e6ebd]
2024-07-18 15:04:23 +05:30
Ammar ELWazir b8a22e6ebd Open Source Contributions (#750)
* Create CONTRIBUTING.md 

Adding ROCm needed files for Open source development.

* Create CODEOWNERS

* Adding issue templates

* Addressing review comments

---------

Co-authored-by: Ammar ELWazir <aelwazir@hpe6u-21.amd.com>
Co-authored-by: gobhardw <gopesh.bhardwaj@amd.com>
2024-07-18 15:04:23 +05:30
Gopesh Bhardwaj c798a92f36 gobhardw/docs refactor (#975)
* refactor docs

* Fixing docs build

* merging 967

* Improving readability with table usage

* review changes

* compilation fix

* README links

---------

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: 785cc39c16]
2024-07-18 12:58:20 +05:30
Gopesh Bhardwaj 785cc39c16 gobhardw/docs refactor (#975)
* refactor docs

* Fixing docs build

* merging 967

* Improving readability with table usage

* review changes

* compilation fix

* README links

---------

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>
2024-07-18 12:58:20 +05:30