Previously, we used the following approach and Comgr actions
for device lib linking:
AMD_COMGR_COMPILE_SOURCE_TO_BC (compile with clang driver)
AMD_COMGR_ADD_DEVICE_LIBRARIES (link in device libs with
llvm-link API)
However, the clang driver can link in device libraries as part
of compilation, assuming a --rocm-path is set. In this context,
this is accomplished by using the following Comgr action instead:
AMD_COMGR_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC (compile and
link in device libs with clang driver)
Change-Id: Ie0bbee7d9a12672536b6d751056a941128ed58be
[ROCm/clr commit: 6311ed8a8e]
Previously, we used the following approach and Comgr actions
for device lib linking:
AMD_COMGR_COMPILE_SOURCE_TO_BC (compile with clang driver)
AMD_COMGR_ADD_DEVICE_LIBRARIES (link in device libs with
llvm-link API)
However, the clang driver can link in device libraries as part
of compilation, assuming a --rocm-path is set. In this context,
this is accomplished by using the following Comgr action instead:
AMD_COMGR_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC (compile and
link in device libs with clang driver)
Change-Id: Ie0bbee7d9a12672536b6d751056a941128ed58be
The CLI helper compares the hex vendor id string with the number
and never match it as AMD GPU.
Change-Id: I1ababdce3a3694a5e26e5b0feef4d3d8cd40df7a
[ROCm/amdsmi commit: b2690fdf1e]
Recent compiler patch https://github.com/llvm/llvm-project/pull/81700/
introduced changes to certain hip external symbols clang emits. This patch
makes the tests "16_assembly_to_executable" and "17_llvm_ir_to_executable"
follow these changes. I expect comments on whether this is an unintended
compiler behaviour that needs fix in compiler or this is the proper fix.
Change-Id: I3943f5365600f683a65c98c6d17c14a5e4192351
[ROCm/hip-tests commit: fba826fc3c]
Recent compiler patch https://github.com/llvm/llvm-project/pull/81700/
introduced changes to certain hip external symbols clang emits. This patch
makes the tests "16_assembly_to_executable" and "17_llvm_ir_to_executable"
follow these changes. I expect comments on whether this is an unintended
compiler behaviour that needs fix in compiler or this is the proper fix.
Change-Id: I3943f5365600f683a65c98c6d17c14a5e4192351
Was failing to link on AlmaLinux8.
Change-Id: Id7df245f1063c2bebd0f07efc352f1b9017eda0e
Signed-off-by: Stella Laurenzo <stellaraccident@gmail.com>
Signed-off-by: Kent Russell <kent.russell@amd.com>
Was failing to link on AlmaLinux8.
Change-Id: Id7df245f1063c2bebd0f07efc352f1b9017eda0e
Signed-off-by: Stella Laurenzo <stellaraccident@gmail.com>
Signed-off-by: Kent Russell <kent.russell@amd.com>
[ROCm/ROCR-Runtime commit: 7c10e1e4f5]
* Use small_vector for API iterate_args
- replace dim3 value arguments with rocprofiler_dim3_t
- dim3 has a non-trivial destructor
- common::mpl::unqualified_type
- common::stringified_argument_array_t<N> alias
- assert_public_data_type_properties()
- common::container::small_vector<T>::at function
- stringize returns small_vector<stringified_argument>
- stack allocated vector
- remove has_pc_sampling condition (HSA, HIP)
- this will be handled in queue interception
* Misc tweaks
[ROCm/rocprofiler-sdk commit: 8591ed1c96]
* Use small_vector for API iterate_args
- replace dim3 value arguments with rocprofiler_dim3_t
- dim3 has a non-trivial destructor
- common::mpl::unqualified_type
- common::stringified_argument_array_t<N> alias
- assert_public_data_type_properties()
- common::container::small_vector<T>::at function
- stringize returns small_vector<stringified_argument>
- stack allocated vector
- remove has_pc_sampling condition (HSA, HIP)
- this will be handled in queue interception
* Misc tweaks
config_amd_wsl.json file disabled some cases trigger TDR or not support
on WSL.
Change-Id: I3227aefe9dc0dc06e6d061a1e24814ec8b62a062
Signed-off-by: Feifei Xu <Feifei.Xu@amd.com>
[ROCm/hip-tests commit: ad3137f8d6]
config_amd_wsl.json file disabled some cases trigger TDR or not support
on WSL.
Change-Id: I3227aefe9dc0dc06e6d061a1e24814ec8b62a062
Signed-off-by: Feifei Xu <Feifei.Xu@amd.com>
- Sometimes we want to mask out kernel names, use right level for kernel
logging
Change-Id: Ideae9647c57b86ae390ff2f4131f6d8c6df5c086
[ROCm/clr commit: f1adecd186]