Fix vulkan_interop build issue on CMake so that
it can be integrated into catch2 batch build.
Fix some test failures.
Update some code format.
Change-Id: I32c9bed861ddf4fe0d7bba21dce9bd720168c397
[ROCm/hip-tests commit: 8cc7ed5a03]
Fix vulkan_interop build issue on CMake so that
it can be integrated into catch2 batch build.
Fix some test failures.
Update some code format.
Change-Id: I32c9bed861ddf4fe0d7bba21dce9bd720168c397
* EvaluateAST and validation of RawAST
* Adding MetricDimension class and concepts
* set_dimensions() and improved ValidateRawAST()
* source formatting (clang-format v11) (#124)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* Addressing 1st round of review comments
* Modified the parser production rules to support the right syntax for REDUCE and SELECT derived metric expressions
* changes to raw_ast.hpp and fmt::format()
* Parser tests updated to support corrected REDUCE and SELECT syntax
* changes to EvaluateAST::set_dimensions() and other dimension related code changes
* Added a test for EvaluateAST::evaluate() to test basic arithmetic on EvaluateAST
* Format source code (via clang-format v11) on sauverma/evaluate-ast (#146)
* source formatting (clang-format v11)
* Add dimension information to counter record
Restructures counter records to have the following design:
rocprofiler_record_id_t which is an int64_t that encodes
both the counter id and dimension information for the
record. The first 16 bits are reserved for the counter id while
the last 48 are split among the dimensions specified in
rocprofiler_dimension_t (currently 8 bits per dimension).
Each of the 8 bits for the dimension stores the dimension
value for that dimension for this record (i.e. a value of 8
on dimension XCC would denote XCC[8] for the counter). The
split among the dimensions will automatically adjust as
dimensions are added or removed.
The record also contains a union of {int64_t hw_counter, double
derived_counter} to specify the value of the record at
rocprofiler_record_id_t. int64_t denotes a physical hardware
counter that has integer types while the double is used for derived
counters (which type this counters values are needs to be queried
separately).
* Integration of new id type + other fixes
---------
Co-authored-by: sauverma93 <sauverma93@users.noreply.github.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com>
* Fixed sissues with reduce() implementation and added a test for reduce()
* Updated parser syntax for reduce() and updated the parser test. Disabled the test for select()
* Build warning fixes
* Modifications to support fetching xcc/etc info from agent
* Initial plumbing working for single counters, cleanup+tests still needed
* Remove string comparison from reduce ops
* source formatting (clang-format v11) (#163)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* cmake formatting (cmake-format) (#164)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* source formatting (clang-format v11) (#171)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* Merged with master
* source formatting (clang-format v11) (#172)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* source formatting (clang-format v11) (#173)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* Test fix
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
Co-authored-by: sauverma93 <sauverma93@users.noreply.github.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com>
[ROCm/rocprofiler-sdk commit: 63775f241a]
* EvaluateAST and validation of RawAST
* Adding MetricDimension class and concepts
* set_dimensions() and improved ValidateRawAST()
* source formatting (clang-format v11) (#124)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* Addressing 1st round of review comments
* Modified the parser production rules to support the right syntax for REDUCE and SELECT derived metric expressions
* changes to raw_ast.hpp and fmt::format()
* Parser tests updated to support corrected REDUCE and SELECT syntax
* changes to EvaluateAST::set_dimensions() and other dimension related code changes
* Added a test for EvaluateAST::evaluate() to test basic arithmetic on EvaluateAST
* Format source code (via clang-format v11) on sauverma/evaluate-ast (#146)
* source formatting (clang-format v11)
* Add dimension information to counter record
Restructures counter records to have the following design:
rocprofiler_record_id_t which is an int64_t that encodes
both the counter id and dimension information for the
record. The first 16 bits are reserved for the counter id while
the last 48 are split among the dimensions specified in
rocprofiler_dimension_t (currently 8 bits per dimension).
Each of the 8 bits for the dimension stores the dimension
value for that dimension for this record (i.e. a value of 8
on dimension XCC would denote XCC[8] for the counter). The
split among the dimensions will automatically adjust as
dimensions are added or removed.
The record also contains a union of {int64_t hw_counter, double
derived_counter} to specify the value of the record at
rocprofiler_record_id_t. int64_t denotes a physical hardware
counter that has integer types while the double is used for derived
counters (which type this counters values are needs to be queried
separately).
* Integration of new id type + other fixes
---------
Co-authored-by: sauverma93 <sauverma93@users.noreply.github.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com>
* Fixed sissues with reduce() implementation and added a test for reduce()
* Updated parser syntax for reduce() and updated the parser test. Disabled the test for select()
* Build warning fixes
* Modifications to support fetching xcc/etc info from agent
* Initial plumbing working for single counters, cleanup+tests still needed
* Remove string comparison from reduce ops
* source formatting (clang-format v11) (#163)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* cmake formatting (cmake-format) (#164)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* source formatting (clang-format v11) (#171)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* Merged with master
* source formatting (clang-format v11) (#172)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* source formatting (clang-format v11) (#173)
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
* Test fix
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com>
Co-authored-by: sauverma93 <sauverma93@users.noreply.github.com>
Co-authored-by: Benjamin Welton <bewelton@amd.com>
* Use parallel init of LDS and adjust P2P channels for gfx94x
* Move another init to parallel
* Fix NCCL_NCHANNELS_PER_PEER setting
[ROCm/rccl commit: dbcba2923b]
- std=c++.. is not required because CMAKE_CXX_STANDARD is set
- nullptr check breaks the test because we rely on nullptr as an api for
checking feature availability.
- enum number setting is unnecessary
Change-Id: I393e6dd3f292b7fa4198302f140c0443ba5e50f5
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
[ROCm/rocm_smi_lib commit: a099f0682a]
- std=c++.. is not required because CMAKE_CXX_STANDARD is set
- nullptr check breaks the test because we rely on nullptr as an api for
checking feature availability.
- enum number setting is unnecessary
Change-Id: I393e6dd3f292b7fa4198302f140c0443ba5e50f5
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
Aryan
Kiriti Gowda
Todd tiantuo Li
Julia Jiang
Lakshmi Kumar
mbhiutra
Rupam Chetia
taosang2
Satyanvesh Dittakavi
Jaydeep Patel
jeffqjiangNew
Ioannis Assiouras
Nusrat Islam
Saurabh Verma
Bertan Dogancay
Wenkai Du
Galantsev, Dmitrii