Commit Graph

10773 Commits

Author SHA1 Message Date
Saurabh Verma 437d39de9e RDC metrics in v1
Change-Id: Iaa8cd0a37da37729df76362f10a0bb63c317a498


[ROCm/rocprofiler commit: a63b6fcbd2]
2024-06-11 17:00:39 -05:00
Saurabh Verma 2047bf4b8b Fixing occupancy metrics for MI300
Adding changes for v1 xml which was missed in change 604738fd8d

Change-Id: I338f2736ee61e316522f1ce42cee74abec201499
2024-06-11 11:47:57 -05:00
Saurabh Verma 25eda9f856 Fixing occupancy metrics for MI300
Adding changes for v1 xml which was missed in change 6cf9df4ff0

Change-Id: I338f2736ee61e316522f1ce42cee74abec201499


[ROCm/rocprofiler commit: 2047bf4b8b]
2024-06-11 11:47:57 -05:00
Galantsev, Dmitrii d4bb33d100 Use correct rocprofiler metrics
Change-Id: I26603de7425abb6588f770ed68c22e14d6d20d56
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-06-11 11:15:18 -05:00
Galantsev, Dmitrii 3514225b83 Rewrite rocprofiler plugin
Change-Id: Ic7dd967cc60cacd2b16a465180505ea2a342fccf
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-06-11 03:11:15 -05:00
Ammar ELWazir a50d5ce4ae Fixing the force of using cmake python3 interpreter
Change-Id: I5d87dfa78052611856652fc887cdfa6764c51028
2024-06-10 16:00:09 -04:00
Ammar ELWazir bb40910abe Fixing the force of using cmake python3 interpreter
Change-Id: I5d87dfa78052611856652fc887cdfa6764c51028


[ROCm/rocprofiler commit: a50d5ce4ae]
2024-06-10 16:00:09 -04:00
Saurabh Verma 056156135d SWDEV-457922: Temporary fix to prevent multiple instances of either rocprofiler v1 or v2 to be running, whether it's interception or standalone mode.
The fix works by using a pid file and a lock file, similar to how firefox prevents multiple instances.

Change-Id: I4974a80bf920eaf0376a53410573c1cc74ec17ac
2024-06-10 12:49:29 -04:00
Saurabh Verma c41bbe21d0 SWDEV-457922: Temporary fix to prevent multiple instances of either rocprofiler v1 or v2 to be running, whether it's interception or standalone mode.
The fix works by using a pid file and a lock file, similar to how firefox prevents multiple instances.

Change-Id: I4974a80bf920eaf0376a53410573c1cc74ec17ac


[ROCm/rocprofiler commit: 056156135d]
2024-06-10 12:49:29 -04:00
Vladimir Indic b4f7154716 The NULL value of an internal correlation ID defined (#901) 2024-06-10 16:12:01 +02:00
Vladimir Indic 211ee219c4 Disable PC sampling service if counter collection service is configured (#899) 2024-06-10 15:13:49 +02:00
AravindanC 59230206a3 SWDEV-460492 Update permissions, install target types of executables
Change-Id: I23828d4938ce35f2c27d86654f4e122f8886ec1d
2024-06-07 17:42:32 -04:00
AravindanC d7c2fa8867 SWDEV-460492 Update permissions, install target types of executables
Change-Id: I23828d4938ce35f2c27d86654f4e122f8886ec1d


[ROCm/rocprofiler commit: 59230206a3]
2024-06-07 17:42:32 -04:00
Benjamin Welton f5753d3ae3 Add dimension query to counter collection sample (#918)
Co-authored-by: Benjamin Welton <ben@amd.com>
2024-06-07 14:30:01 -07:00
Benjamin Welton 10fdba985f Added error log for query counter info (#903)
* Added error log for query counter info
2024-06-07 13:27:14 -07:00
Benjamin Welton 3d9a448797 Small change to sample for clarity (#913)
Co-authored-by: Benjamin Welton <ben@amd.com>
2024-06-07 13:05:46 -07:00
Benjamin Welton 45e165b256 Add calls to stop and wait for a debugger (#916)
Co-authored-by: Benjamin Welton <ben@amd.com>
2024-06-07 13:04:52 -07:00
ajanicijamd f0bd9126a5 Patch for omnitrace-sample crash with HIP API. (#344)
Fix HIP-API CTest failure

Check if stack is empty before popping data off of it.

Signed-off-by: Aleksandar Janicijevic <Aleksandar.Janicijevic@amd.com>
2024-06-07 15:23:18 -04:00
Ammar ELWazir db82c5ef62 General fixes for CI
Change-Id: I16e4d1fbc71a378eba6738c6953760e8e4de525e
2024-06-07 11:22:07 -05:00
Ammar ELWazir 31bc8c5fde General fixes for CI
Change-Id: I16e4d1fbc71a378eba6738c6953760e8e4de525e


[ROCm/rocprofiler commit: db82c5ef62]
2024-06-07 11:22:07 -05:00
David Galiffi 129580b416 Enable features to generate dependency list and fix RPM installation. (#343)
* CPACK: Enable features to generate dependency lists

For DEBIAN, enable CPACK_DEBIAN_PACKAGE_SHLIBDEPS to generate a package
dependency list.

For RPM, enable CPACK_RPM_PACKAGE_AUTOREQPROV to automatically generate
lists of shared libraries that this package requires and provides.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Manually derive RPM provides list for libunwind.

[Why]
`dnf install` fails dependency resolution

[How]
Auto-generation did not add it to the "provides" list, despite it being
included in the package when OMNITRACE_BUILD_LIBUNWIND is enabled. So,
manually include these in the "CPACK_RPM_PACKAGE_PROVIDES" parameter.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Fix cmake-format linting

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-06-07 10:34:35 -05:00
Benjamin Welton 680448c444 Small doc update to remove restrictions no longer present (#917)
* Small doc update to remove restrictions no longer present
2024-06-06 16:30:48 -07:00
Ammar ELWazir c312e9b0f1 Fixing rocsys includes
Change-Id: Ia19030a5ad4caebe7b6703721702a1776e97455b
2024-06-06 15:00:48 -05:00
Ammar ELWazir 5d572c9bcb Fixing rocsys includes
Change-Id: Ia19030a5ad4caebe7b6703721702a1776e97455b


[ROCm/rocprofiler commit: c312e9b0f1]
2024-06-06 15:00:48 -05:00
guanyu12 e7e8b59cba Merge amd-staging into amd-master 20240606
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: I06c0f47701f580cd7440dc9fb5d394fad97d06aa
2024-06-06 16:48:50 +08:00
Galantsev, Dmitrii 20ca2ce574 Fix rocprofiler plugin
- Replace non-working fields with working ones
    - remove CU_OCCUPANCY completely as it isn't well supported
- Fix rocprofiler initialization with shared_ptr and rdc_module_init
- Replace env var ROCPROFILER_METRICS_PATH with ROCP_METRICS
    - ROCPROFILER_METRICS_PATH is only relevant for rocprofv2
    - ROCP_METRICS is only relevant for rocprofv1 (which we are using)

Change-Id: I21e6fa3f0e1694c38f44ca0e5659d672559f7380
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-06-06 01:51:39 -05:00
gobhardw 1e69b3e2f6 SWDEV-465520: RHEL9 toolchain doesnt seem to support experimental filesystem
Change-Id: I6b1e7f42c49b1c7af412c0b68851724861c9970a
2024-06-05 12:50:48 -04:00
gobhardw a67f4fdd93 SWDEV-465520: RHEL9 toolchain doesnt seem to support experimental filesystem
Change-Id: I6b1e7f42c49b1c7af412c0b68851724861c9970a


[ROCm/rocprofiler commit: 1e69b3e2f6]
2024-06-05 12:50:48 -04:00
Giovanni LB 140f658820 SWDEV-464906: Swap read and stop packets in queue.cpp
Change-Id: I2dd33a71c0cbe69fe6c2cfaf523b9f8c6500093f
2024-06-05 09:11:59 -04:00
Giovanni LB 607cfb9ee1 SWDEV-464906: Swap read and stop packets in queue.cpp
Change-Id: I2dd33a71c0cbe69fe6c2cfaf523b9f8c6500093f


[ROCm/rocprofiler commit: 140f658820]
2024-06-05 09:11:59 -04:00
Benjamin Welton 2f3a8b05b3 Use fixed size array for serialization (#906)
Co-authored-by: Benjamin Welton <ben@amd.com>
2024-06-05 02:02:01 -07:00
amd-jmacaran 2bd32b0daf External CI: change supported branches
Change-Id: I3c3db1243d067720fd141eeb204d9b0b3e7a9fd6
2024-06-05 01:51:43 -04:00
gobhardw 341b7b1f21 removing --kernel-trace from --sys-trace help
Change-Id: I14afd42d12bc3c2462040d5ba1f16765565fd662
2024-06-05 11:18:58 +05:30
gobhardw a95064a9a5 removing --kernel-trace from --sys-trace help
Change-Id: I14afd42d12bc3c2462040d5ba1f16765565fd662


[ROCm/rocprofiler commit: 341b7b1f21]
2024-06-05 11:18:58 +05:30
Galantsev, Dmitrii 07c414af5e Finalize the rocprofiler fields
Change-Id: I4ed1c4309f21bdcc7281d911663036caf5947182
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-06-04 19:49:06 -05:00
Vladimir Indic b0c41827c3 PC sampling client: using raw pointers (#902)
* PC sampling client: using raw pointers to prevent premature destruction of buffers

* PCS client: freeing buffer_ids
2024-06-04 13:16:26 -05:00
Ammar ELWazir 0e43a30de0 Update client.cpp (#900) 2024-06-04 13:16:26 -05:00
Vladimir Indic 1c5bf63dbc PC sampling: CID manager unit test (#898) 2024-06-04 13:16:26 -05:00
Ammar ELWazir 5347c124c5 DRM Issue Fix for SLES 15 (#897)
* DRM Issue Fix

* Formatting Fix
2024-06-04 13:16:26 -05:00
Galantsev, Dmitrii e11afbf60f Add GPU indexing and fix check for fields in rocprof
- Fix RUNPATH for tests

Change-Id: I79517592b49d27080a010a2e41e5878adf24a157
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-06-04 12:56:22 -05:00
coleramos425 6d24a074b4 Upgrade docs package
Signed-off-by: coleramos425 <colramos@amd.com>
2024-06-04 00:33:18 +00:00
coleramos425 d100173739 Update VERSION, CHANGELOG, and citation for next release
Signed-off-by: coleramos425 <colramos@amd.com>
2024-06-04 00:03:43 +00:00
Karl W Schulz 18f96b6b23 set CMAKE_HIP_ARCHITECTURES at configure time so that build matches
desired execution environment

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 17:41:19 -05:00
Karl W Schulz c31ecf2a90 include ENABLE_TESTS=ON for profile tests
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 17:08:48 -05:00
Karl W Schulz 90ff4bf575 wrap up test compilation with an ENABLE_TESTS option
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 16:20:14 -05:00
Karl W Schulz 5077f9e24f update CI to build necessary vcopy binary via new additions to build
system (a la, just run make)

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 16:20:14 -05:00
Karl W Schulz c54d3b34ea change project language to HIP; identify tests as cmake subdir
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 16:20:14 -05:00
Karl W Schulz 382a83f48b adding build-collateral for test subdir
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-06-03 16:20:14 -05:00
coleramos425 7046ea15bd Comply to formatting
Signed-off-by: coleramos425 <colramos@amd.com>
2024-06-03 13:47:45 -05:00
coleramos425 1d19ae9483 Detection of MI308X and hardcode mclk to address bug in rocm-smi
Signed-off-by: coleramos425 <colramos@amd.com>
2024-06-03 13:47:45 -05:00