AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
10,773 Commits 3 Branches 0 Tags
00a09fbf21c0ec3886a9972c212b9c7dda796617
Commit Graph

10773 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Roopa Malavally 2fd36e33ad ROCm SMI Documentation Reorg 
Change-Id: I3e4db2c50a43a51eeea4d3e06ba4811ad1859368
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
 2024-05-31 16:25:35 -05:00
coleramos425 9ff90edc10 Comply to Python formatting 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
coleramos425 fef13818f9 Remove outdated CTest case from CMakeLists 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
coleramos425 0315ed4458 Update gpu-id on MI300 CI workloads and update test case 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
coleramos425 73f18d20f5 Remove old workloads 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
JoseSantosAMD 91f635e3e6 Updated test_analyze_commands to include mi300 directories 
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
 2024-05-31 16:09:58 -05:00
coleramos425 c079f1330b Add vcopy workloads for MI300A and MI300X 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
JoseSantosAMD db7d77ca3f updating expected exit codes for pytest 
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
 2024-05-31 16:09:58 -05:00
JoseSantosAMD 6d98a1eb5e update test analyze scripts 
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
 2024-05-31 16:09:58 -05:00
coleramos425 618c064571 Remove debug print statements from profile_general 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
coleramos425 cdccd93afa Remove invalid test from workload generation script 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
coleramos425 b8af814467 Add CI workloads for MI300A_A1 and MI300X_A1 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
coleramos425 7d79fcc276 Remove redundant code in PyTest 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
coleramos425 09264591f3 Support MI300 in PyTest profile tests 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
coleramos425 49371cacec Create dedicated subdirectory in perfmon configs for archs supporting roofline 
Separate subdirs allows us to target different roofline counters for different archs (i.e. MI300 vs MI200)

Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-31 16:09:58 -05:00
Maisam Arif 7c6bd4dc1c Updated RDC to use AMD-SMI 24.6.0 structs 
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I9ef0f3cb786c1238e53cf21df5c6afafac829175
 2024-05-31 10:37:39 -05:00
Galantsev, Dmitrii 10f3c2325c SWDEV-464886 - Fix ASAN REGEX error in cmake 
Change-Id: Iaa5deed3ac833ebf1a010b98cfd4493359653ffe
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
 2024-05-30 16:42:00 -05:00
Galantsev, Dmitrii 2096c8225c SWDEV-464886 - Fix REGEX error in cmake 
Simplify rocm-core dependency handling

Change-Id: I07de1d40e4a3c90481c2de3abe9aac3dbfdd6d93
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
 2024-05-30 14:54:44 -05:00
Ammar ELWazir 2be8f71790 Temp: Disabling Perfetto Test 
Change-Id: I602e3e752d508a45d42bf22e40b78d53a8e436d0
 2024-05-30 12:49:15 -05:00
Ammar ELWazir 4a716c8a66 Temp: Disabling Perfetto Test 
Change-Id: I602e3e752d508a45d42bf22e40b78d53a8e436d0


[ROCm/rocprofiler commit: 2be8f71790]
 2024-05-30 12:49:15 -05:00
Ammar ELWazir 1bda31993f Update pc_sampling.md (#896) 
* Update pc_sampling.md

* Update pc_sampling.md
 2024-05-30 00:42:09 -05:00
guanyu12 96b2ccde76 Merge amd-staging into amd-master 20240530 
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: Ia5eb36449a72cbfd579942b62d1168dc7598ef65
 2024-05-30 11:34:52 +08:00
Jonathan R. Madsen a76f61a0a3 Migrate to rocprofiler-sdk:: namespace in CMake everywhere (#892) 
- remove all usage/support for rocprofiler:: namespace
 2024-05-29 22:28:43 -05:00
Jonathan R. Madsen 5525b400c3 Miscellanous AFAR 5 Updates (#891) 
* Dispatch table copy/update uses ROCP_TRACE instead of ROCP_INFO

* Update rocprofiler-sdk CMake config

- rocprofiler::rocprofiler is alias to rocprofiler-sdk::rocprofiler-sdk instead of other way around

* Prefer rocprofiler-sdk::rocprofiler-sdk over rocprofiler::rocprofiler

* Fix WITH_UNWIND for glog

- requires a value of "none" instead of boolean now

* Update include/rocprofiler-sdk/registration.h

- explicit struct names to permit forward decl

* Update include/rocprofiler-sdk/cxx/serialization.hpp

- ROCPROFILER_SDK_CEREAL_NAMESPACE_BEGIN and ROCPROFILER_SDK_CEREAL_NAMESPACE_END to enable customized namespace
 2024-05-29 16:45:56 -05:00
Saurabh Verma 665fd567eb Adding AID dimension for UMC support (#886) 
* Adding AID dimension for UMC support

* fix for parser.reduction test
 2024-05-29 15:09:56 -05:00
Gopesh Bhardwaj c0542cbfb2 Update README.md (#888) 
Updating ill formatted README
 2024-05-29 12:36:13 -05:00
Gopesh Bhardwaj 6c41b8d73a Doc updates for AFAR V (#875) 
* Doc updates for AFAR V

* doc updates

* Updating All AFAR history

* updating table with --output-format

* updating doc for yaml and json support

* Update source/docs/pc_sampling.md

* Update README.md

* Update source/docs/pc_sampling.md

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update pc_sampling.md

---------

Co-authored-by: Ammar ELWazir <ammar.elwazir@amd.com>
Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>
 2024-05-29 12:01:02 -05:00
Giovanni Lenzi Baraldi 1b95089c28 Enable ATT continuous mode and code object tracing registration (#850) 
* Adding ATT continuous mode and ATT code object tracking

* Fixing aql_packet.cpp

* Updating to aqlprofile codeobj changes

* Removing kernel packet from ATT dispatch callback

* Changing getSymbolMap() to return relative vaddr

* Tidy fixes

* Formatting

* Fix shadowing

* Fixing packet test

* Updating tests

* Simplifying multi-agent traces

* Adding dynamic codeobj tracking

* leftover book-keeping for codeobj markers

* Formatting

* Formatting

* Temporary removing codeobj marker

* Formatting

* Re-enabling codeobj tracking

* Making copy of coreapi table

* Fixing issues with toolData lifetile

* Formatting

* Fixing issues with ASAN

* Improving memory profile

* Removing misplaced annotation

* Fixing queue type and allowing shared_locks in globalThreadTracer

* Update logging

* Changing ATT formats to be more in line with the SDk (#883)

* Fixing some merge conflicts

* Fixing cmakelists

* Fixing merge conflicts

* Formatting
 2024-05-29 11:09:28 -05:00
Benjamin Welton 2225153c23 Test fix for AQLProfile changes (#882) 
* Test fix for AQLProfile changes

AQL profile recently changed where the ordering
of packets now needs to be read then stop (instead
of stop and read previously). This change supports
the newer model.

* Update source/lib/rocprofiler-sdk/counters/dispatch_handlers.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* test barrier

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
 2024-05-29 10:35:49 -05:00
Kiran Thumma ba14e748ca adding keyword scan (#874) 
* adding keyword scan

* update

* update

* update

* checking on fix

* check

* check

* check

* check

* update
 2024-05-29 09:41:59 -05:00
Giovanni Lenzi Baraldi 385980e279 Moving ATT to amd_detail (#885) 
* Moving ATT to amd_detail

* Formatting
 2024-05-29 11:28:01 -03:00
Jonathan R. Madsen fbf0b49e22 Updates to compilation without HSA PC sampling support (#887) 
- move ROCPROFILER_SDK_HSA_PC_SAMPLING define from lib/rocprofiler-sdk/hsa/hsa.hpp to lib/rocprofiler-sdk/pc_sampling/defines.hpp
- Update lib/rocprofiler-sdk/pc_sampling/CMakeLists.txt to return if HSA version is < 1.14.0
- update various includes for "lib/rocprofiler-sdk/pc_sampling/defines.hpp"
 2024-05-29 13:40:26 +02:00
Vladimir Indic c45bf712d1 PC Sampling - blit kernels handling (#878) 
* correlation id 0 for blit kernels' samples

* rocprofiler_pc_sampling_snapshot_v1_t docs update (for future use)

* ROCPROFILER_CORRELATION_ID_VALUE_NONE introduced

* Simplifying ROCPROFILER_CORRELATION_ID_VALUE_NONE

* Apply suggestions from code review

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

---------

Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
 2024-05-29 12:55:47 +02:00
Gopesh Bhardwaj dc054eea76 Adding python script for rocprofv3 (#849) 
* Adding python script for rocprofv3

* script update

* updating script

* Fixing script for counter collection tests

* Fixing Sanitizer issues

* Adding YAML input file support

* Fixing counter validation tests

* script modifications

* Adding missing LD_PRELOAD

* doc updates

* Adding test for yaml input

* updated yaml extension support in doc

* backward compatibility

* updating scripts

* Fixing git history rocprofv3- part1

* Fixing git history rocprofv3- part2

* Fixing rocprofv3 history final

* Rebasing PR 860 for json support

* Review comments: Parser updates

* Removed color encoding and rebasing again

* Addressing review comments

* removing globals

* Update rocprofv3.py

- update tests to conform to new argparse requirements
- added support for JSON

* Slight tweak to update_env for ROCP_OUTPUT_FORMAT

* Update rocprofv3.py

- Handle ROCPROF_PRELOAD
- Add --preload option
- Add --kernel-names option

* Update rocprofv3.py

- Fix update_env handling of prepend/append
- Tweak --preload argument

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
 2024-05-29 05:05:10 -05:00
Jonathan R. Madsen 69c381246f Bump version to 0.4.0 for AFAR release (#879) 2024-05-29 03:38:38 -05:00
gobhardw 48374bf453 Fixes multiple issues with tool 
Change-Id: Ib465caa9029edc737df2c419d2ef763ec24165e1
 2024-05-29 01:30:09 -04:00
gobhardw 8f765d2a1e Fixes multiple issues with tool 
Change-Id: Ib465caa9029edc737df2c419d2ef763ec24165e1


[ROCm/rocprofiler commit: 48374bf453]
 2024-05-29 01:30:09 -04:00
Ammar ELWazir b8726a6225 Adding JSON & Major fixes 
Adding Chrome Tracing JSON for V2
Some fixes for the Kernel Dispatch tracing
Changes related to the HIP Runtime Destruction fix

Change-Id: I2fe1f1ef66b415df17c503a4a9fadcfa107d8c49
 2024-05-29 01:21:52 -04:00
Ammar ELWazir d0dfb4f3e2 Adding JSON & Major fixes 
Adding Chrome Tracing JSON for V2
Some fixes for the Kernel Dispatch tracing
Changes related to the HIP Runtime Destruction fix

Change-Id: I2fe1f1ef66b415df17c503a4a9fadcfa107d8c49


[ROCm/rocprofiler commit: b8726a6225]
 2024-05-29 01:21:52 -04:00
Giovanni Lenzi Baraldi a84c9fa7d4 Removing code object static library (#865) 
* Removing static library build for codeobj library

* Moving codeobj library to amd_detail

* Formatting

* Formatting

* Adding findDW

* Adding libdw to common samples cmake
 2024-05-28 23:15:11 -03:00
Vladimir Indic 7201aa321e (IMPORTANT: AFAR V ) Hide PC sampling if HSA does not support it. (#881) 
* Hide PC sampling if HSA does not support it.

* missing hsa.hpp include
 2024-05-29 03:02:14 +02:00
Benjamin Welton 00f31e593c Build fixes for clang-18 (#880) 
Fixes unnecessary inline and ambiguous conditional return.
 2024-05-28 17:01:50 -07:00
Benjamin Welton 705a791553 Added static construct to topology (#868) 
* Added static construct to topology
 2024-05-28 15:06:54 -07:00
Karl W. Schulz 7a01f499d7 remove use of distutils package entirely to avoid future deprecation 
issues

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
 2024-05-28 15:34:00 -05:00
Karl W. Schulz aca084f41c updated approach for runtime dependency check that does use "pkg_resources" 
which will reportedly be deprecated at some point in the future.

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
 2024-05-28 15:34:00 -05:00
coleramos425 c6cfa9cc26 Wrap text displayed in 'Top Dispatch' table for neatness 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-05-28 15:34:00 -05:00
Nicholas Curtis 047d7771f3 Add fix for case where we pass a single 'nan' value to to_avg 
This is triggered by doing e.g., analyze -p <whatever> -k <kernel> -n per_kernel -b 17 18
Manifests as e.g.:

```
  ERROR [analysis] 'float' object has no attribute 'empty'
```

because of:

https://github.com/ROCm/omniperf/blob/d1ee2ec8709b21f2e72536cc14dba8ac2f8621ab/src/utils/parser.py#L135

Instead, we first check whether numpy thinks the whole array is nan's, and bail early if so

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-05-28 15:34:00 -05:00
Nicholas Curtis 1f584c1612 handle unspecified case 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-05-28 15:34:00 -05:00
Nick Curtis 5579beeed5 fix formatting 
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com>
 2024-05-28 15:34:00 -05:00
Nick Curtis 989dd3b7ae Add ability to overide arch when name missing in rocminfo 
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com>
 2024-05-28 15:34:00 -05:00