Commit Graph

5296 Commitit

Tekijä SHA1 Viesti Päivämäärä
Alex Xie 044a7e55ad SWDEV-221166 - Detect support for large bar access through HIP runtime API
Change-Id: Iaa9756c1b5e40c1ab5afb38e44a6699fa5f6c13f
2020-05-01 20:39:52 -04:00
Michael Hong Bin Liao a94de6d463 Merge "Fix more typos from 53dd6b7a669e78035dffcd138053f7413d48d736." into amd-master-next 2020-05-01 19:35:53 -04:00
Matt Arsenault 80bc98afee Fix installing generated header to include/include
This isn't the ideal solution, but a lot more cleanups are needed for
how install is used.

Change-Id: I63a9c1a46d0da13ee4373038ece228005207271a
2020-05-01 12:43:49 -04:00
Michael LIAO 6bfedf1a1d Fix more typos from 53dd6b7a66.
Change-Id: I75ed28a5862daffc0778910d7ba3b97f51a87949
2020-05-01 12:19:30 -04:00
Matt Arsenault 36432be962 Don't directly link pthreads
This was already searching for the right threads library, but ignoring
the result.

Change-Id: I10d898245696135c1ef928c7715efce8ec6b939f
2020-05-01 08:28:36 -04:00
Matt Arsenault b618939e2e Don't emit generated hip_prof_str.h to source directory
The build should never touch the source directory, and only write
generated files to the output directory.

Also track the dependency with a custom command and target, as is the
normal method for dependencies on generated files.

Change-Id: I9d835256c643aeef241d26ca05ab390ebba65111
2020-05-01 08:24:56 -04:00
Matt Arsenault bd4ec781f2 Find python to generate prof API headers.
Don't rely on shell commands. On Ubuntu 20.04, /usr/bin/python no
longer exists, so I'm seeing some failures from somewhere assuming the
path.

The top level CMakeLists also repeats exactly this, which should be
fixed.

Change-Id: I56b26742920f0dc40b363b409892bd41cfa485ef
2020-04-30 18:21:03 -04:00
Aaron En Ye Shi c1d5ba1d0a Merge "Update hipcc to use HIP_COMPILER variable" into amd-master-next 2020-04-30 17:31:33 -04:00
Michael Hong Bin Liao 977efb14c6 Merge "[vdi] Skip null texture object in hipDestroyTextureObject." into amd-master-next 2020-04-30 16:07:58 -04:00
Aaron Enye Shi c729d52681 Update hipcc to use HIP_COMPILER variable
This will update the hipcc script so that it will use HIP_PLATFORM, HIP_COMPILER, and HIP_RUNTIME variables correctly based on updated hipconfig file.

Removing HIP_PLATFORM=clang, only use hcc and nvcc for now. HIP_PLATFORM should eventually switch to amd or nvcc.

Change-Id: Ie527d07a1add974cc3aab8e9f61b0518147d7602
2020-04-30 15:31:20 -04:00
Payam Ghafari aa950adc73 Merge "renaming vdi to rocclr, part 1" into amd-master-next 2020-04-29 19:42:20 -04:00
Laurent Morichetti 4591b7469e Don't make a copy of the embedded device binaries
Embedded device binaries should not be cloned if we want the ROCR's
code object URI for this binary to point to the container (host
executable or shared library) instead of a memory location.

Depends-On: I7973bb0243f5a2d1b639b8a88445cfe6af919dd7
Change-Id: Id3afc981e027e5371114d011f2caaa6414f5fc58
2020-04-29 18:40:18 -04:00
Payam cb7d3227e8 renaming vdi to rocclr, part 1
Change-Id: Idec9be2b6174217abcebaa1776e59168670740b1
2020-04-29 17:54:37 -04:00
Saleel Kudchadker f52b2d4504 Fix error code when hipEventRecord is not called
Change-Id: I6672d4320280fd87fd2786bc54214d40944da845
2020-04-29 13:13:52 -04:00
Michael LIAO db4bcda1bf [vdi] Skip null texture object in hipDestroyTextureObject.
- To match both CUDA and HCC runtime behavior.

Change-Id: I072b006dd554e17f8341f391d33bf6224a125a7e
2020-04-29 12:20:42 -04:00
German Andryeyev bc65ca64fc Clean-up the list of blocking streams
- Insert the stream into the list on the host queue creation,
instead of stream creation

Change-Id: Ib25053019f7df97e5bc786922a6587b9514852d3
2020-04-29 11:37:43 -04:00
Vlad Sytchenko 89b9befe42 Fix order initialization warning
Change-Id: I77ddf1dbec2d11c273163efae6526d3deca92dbf
2020-04-28 20:07:51 -04:00
Payam bff03ec833 updating package name to hip-rocclr instead of hip-vdi
Change-Id: Ife8810d4dd224ce29c2e2a827b221a618c9f1b3d
2020-04-28 13:36:33 -04:00
Vlad Sytchenko 518be44661 Handle copy cases where the uses pases a bad ptr
Change-Id: I4490b8519e4d0dde25b845f9ca7e81c1d80d4f28
2020-04-28 11:04:29 -04:00
Freddy Paul 2a271dc418 hip-on-vdi: Enable RUNPATH and versioning
1. Enable versioning for HIP libraries
2. Enable RUNPATH on HIP libraries to find ROCm dependencies
3. Control HIP package install using CPACK_INSTALL_PREFIX

Change-Id: I9096da56592e9c78cdba329011f6e1bae99adaa2
2020-04-27 19:48:44 -04:00
Aaron Enye Shi 2df5d92240 Update hipconfig to support HIP-Clang
Add support for hipconfig to display details on HIP-Clang compiler and update HIP_COMPILER and HIP_RUNTIME to include clang and rocclr. Also, add hipcc flags --cxxflags and --ldflags to support HCC users who used hccconfig flags.

Change-Id: Ib12d81a4ff59d34fb000626836b1adb10be3ac61
2020-04-27 11:44:53 -04:00
Yaxun (Sam) Liu 4e7b1cdbd2 Let hipcc treats .cpp files as C++ files for HIP-Clang
This change is required by rocBLAS and rocFFT for OpenMP issue
since cmake needs to treat .cpp file as C++ program to detect
OpenMP support.

This is to match nvcc behavior, speed up compilation of C++
programs, and fix some compilation issue where C++ programs
are compiled as HIP programs.

Currently it is controlled by an environment variable
HIP_COMPILE_CXX_AS_HIP. By default it is 1, where
hipcc treats .cpp files as HIP programs. If it is
set to 0, hipcc will treat .cpp files as C++ programs.
This is because some math libraries are still not
ready for the change, however rocBLAS and rocFFT
require this feature for OpenMP, therefore put it
under an environment variable so that rocBLAS
and rocFFT can use it.

Change-Id: I56a51e27079df850ee39d4217fb647c22d79f612
2020-04-27 11:43:05 -04:00
kjayapra-amd 19c654e794 SWDEV-232008 - Handle cases where Memcpy size is less than Symbol Size.
Change-Id: I046bc70445dfd4f6fdfd06415f53d1fc06f425b4
2020-04-27 10:47:28 -04:00
root b5031f39b1 Merge master into amd-master-next
Change-Id: I3fc1dc0c860d627053537581e75561e8a7efe327
2020-04-26 22:19:37 +00:00
Michael LIAO f8062c6fbd [vdi] Revise the symbol management.
- As different modules may have symbols with the same name, each symbol
  needs identifying with a pair of the module handle and the symbol
  name.

Change-Id: I85650a787d9a424545154cc40ebd59e706fa358f
2020-04-24 22:28:31 -04:00
Yaxun (Sam) Liu 29549ce4dc Enable template max and min for HIP-Clang (#2028)
It was for HCC only. HIP-Clang also needs it for __fp16 since AMDMIGraphX uses it.

Change-Id: Id49322b7b89ef799accdf6b47627a6fce51d1ab5
2020-04-24 12:30:28 -07:00
German Andryeyev 5a7c094729 SWDEV-232918
hipEventRecord is much slower in hipclang/vdi

- Make sure default streams don't sync each other.
- Add null stream into the list of default streams.
- Code clean-up to simplify queue look-up.

Change-Id: I36e1fc8d86a600e3dce806694d95d146ed8afd03
2020-04-24 14:40:43 -04:00
Christophe Paquot cf6df62b3a Merge "cherrypick from master branch" into amd-master-next 2020-04-24 11:48:18 -04:00
Yaxun Liu 040ca11925 Merge "Enable template max and min for HIP-Clang" into amd-master-next 2020-04-24 11:44:49 -04:00
Tao Sang cf6345d7c7 Merge "Add Performance/memory/hipPerfMemMallocCpyFree" into amd-master-next 2020-04-24 11:32:47 -04:00
Michael Hong Bin Liao 17e9c63708 Merge "[vdi] Fix texture reference sample." into amd-master-next 2020-04-24 10:30:38 -04:00
Michael Hong Bin Liao 2e61683b33 Merge "[vdi] Fix hang due to recursive locking." into amd-master-next 2020-04-24 10:30:26 -04:00
Yaxun (Sam) Liu 1013e4eca8 Enable template max and min for HIP-Clang
This change is required by AMDMIGraphX.

It was for HCC only. HIP-Clang also needs it for __fp16 since AMDMIGraphX uses it.

Change-Id: Id49322b7b89ef799accdf6b47627a6fce51d1ab5
2020-04-24 09:51:17 -04:00
Paul Fultz II 9227b08458 cherrypick from master branch
75a5088446
727c9f77d8

These are needed by MIOpen and rocBLAS.

Add __HIP_PLATFORM_HCC__ to hip::host target (#2029)

Fix hip-config.cmake for CMAKE_CXX_COMPILER=g++ (#2035)

* Fix hip-config.cmake for CMAKE_CXX_COMPILER=g++

* Add inlineall option to hip::device in hip-config.cmake

Change-Id: Ib51f82d0b9e38d2137df65c940592413e22ba07a
2020-04-24 09:32:02 -04:00
Tao Sang 33d7005b10 Add Performance/memory/hipPerfMemMallocCpyFree
Change-Id: Id1ac415f85028da3e9517c2226764bcb4acec1b1
2020-04-23 23:49:56 -04:00
Michael LIAO b469e5c573 [vdi] Fix texture reference sample.
- The driver code should not re-define `tex` again as it's already
  defined in the kernel code. Eventually, the driver code should be as
  regular C++ code instad of HIP code.

Change-Id: I8c7cab204b98990619d6e7109b990d7089ea9261
2020-04-23 23:41:56 -04:00
Michael LIAO c56a3ca63e [vdi] Fix hang due to recursive locking.
- Declare recursive lock for global function map.

Change-Id: I3e792e21688c980343c4fd1c61dcad97f7a890cd
2020-04-23 23:32:56 -04:00
kjayapra-amd 92c63384cb SWDEV - 231874 - Do Dword aligned memset if the total size aligns.
Change-Id: Id05db4cfd9c43b2cffa3cec8b02f1cd07f340dd6
2020-04-23 21:08:50 -04:00
Vlad Sytchenko bfa363d00c Make sure to zero out all the unset texture fields
These might contain garbage causing the runtime to incorrectly parse the state of the texture references.

Change-Id: I93c726fa30b580b3e14c50ac939f3c71b0d1c8d9
2020-04-23 16:38:52 -04:00
Michael Hong Bin Liao b70dac2557 Merge "[hip] Fix typos." into amd-master-next 2020-04-23 13:32:09 -04:00
eshcherb 6cb57ee64a fix pointers format (#2037)
* fix pointers format

* fix pointers format - cleanup

* fix pointers format - fix
2020-04-23 21:54:51 +05:30
Yaxun (Sam) Liu 5abcda3ab7 Fix hip-config.cmake for CMAKE_CXX_COMPILER=g++ (#2035)
* Fix hip-config.cmake for CMAKE_CXX_COMPILER=g++

Change-Id: I84ae83a5d223853706dd36834b7962ffe9573c1f

* Fix HIP_CXX_COMPILER

Change-Id: I4e2523b560113420af1ab877a0bc48ca2e9e957a

* Fix hip-config.cmake

Change-Id: Ida4ef8f40fed83d5f659a9a9835b1f521cb6a374

* Add inlineall option to hip::device in hip-config.cmake

Change-Id: Ib51f82d0b9e38d2137df65c940592413e22ba07a
2020-04-23 21:51:54 +05:30
Aaron Enye Shi 17e439e572 extractkernel obj dump args to use double dashes (#2034)
More recent llvm-objdump has changed disassemble and mcpu arguments to require double dashes.
2020-04-23 21:51:33 +05:30
Paul Fultz II 445953aa94 Add __HIP_PLATFORM_HCC__ to hip::host target (#2029) 2020-04-23 21:51:02 +05:30
Maneesh Gupta f2e1118d7a Merge in the rocclr based hip runtime (#2032)
* Merge master-next changes in master (include vdi development in master branch)
2020-04-23 09:12:06 -07:00
Evgeny Shcherbakov e8d64b509e Merge "cleanup" into amd-master-next 2020-04-22 23:28:22 -04:00
Michael LIAO a353df6b36 [hip] Fix typos.
Change-Id: I9d85d0e70033d144dbd4d61cb434ffbe023af8c0
2020-04-22 16:44:54 -04:00
Tao Sang 85abd8f028 Fix hip_get_devices failure in lammps
Support hipDeviceAttributeIntegrated in hipDeviceGetAttribute() with hip-vdi rt

Change-Id: Ie5ba81222af3554a843c184ae75af7f369a3c24b
2020-04-22 15:16:59 -04:00
Evgeny b05e54bf84 cleanup
Change-Id: Ia0ee0e4cab2ee8eaa9931024681d0db5b2802594
2020-04-22 13:42:45 -05:00
Michael LIAO 2c1933e0f3 [hip] Generate assertion message in assertion.
Change-Id: Ie66f6563e8728fd0e21cf22dcc6619e4a0e5c28d
2020-04-21 16:44:40 -04:00