Commit Graph

13402 Commits

Author SHA1 Message Date
Rahul Garg 1e78733f53 Add hipBindTexture2D on NVCC path (#1773)
[ROCm/clr commit: 534376cb41]
2020-01-06 12:33:50 +05:30
Rahul Garg 83b9cc743c Fix nested designator warnings (#1768)
[ROCm/clr commit: 178d432b90]
2020-01-06 12:33:34 +05:30
Rahul Garg 32139b7465 Fix hipcc warning related to hipVersion (#1767)
* Fix hipcc warning related to hipVersion
* Rename hipVersion.h to hip_version.h
* Remove HIP_VERSION splitting
* Update .gitignore
- Ignore generated include/hip/hip_version.h
- Removed some stale entries
- Added executables from samples/1_Utils/*/ for consistency with bin/ entries.

[ROCm/clr commit: 3fe1695c3a]
2020-01-06 12:33:23 +05:30
Yaxun (Sam) Liu 382e5716d3 Update HIP-Clang build instruction (#1764)
[ROCm/clr commit: c80c2bf234]
2020-01-06 12:32:47 +05:30
Yaxun (Sam) Liu 024c7d51ea Document FMA settings (#1717)
[ROCm/clr commit: 7dcd5f6329]
2020-01-06 12:32:38 +05:30
foreman 164041b6c8 P4 to Git Change 2052260 by chui@ocl-promo-incrementor on 2020/01/04 03:00:14
SWDEV-2 - Change OpenCL version number from 3072 to 3073.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2820 edit


[ROCm/clr commit: 93afda79fd]
2020-01-04 03:06:46 -05:00
foreman 12927b7741 P4 to Git Change 2052191 by skudchad@skudchad_test2_win_opencl on 2020/01/03 15:54:23
SWDEV-213000 - Backout change to notifyCmdQueue as the real issue has been identified

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#53 edit


[ROCm/clr commit: a941903848]
2020-01-03 16:02:59 -05:00
foreman 6332be2a21 P4 to Git Change 2051988 by chui@ocl-promo-incrementor on 2020/01/03 03:00:13
SWDEV-2 - Change OpenCL version number from 3071 to 3072.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2819 edit


[ROCm/clr commit: 375e16b00d]
2020-01-03 03:08:30 -05:00
foreman d2f651bfe5 P4 to Git Change 2051379 by chui@ocl-promo-incrementor on 2020/01/01 03:00:13
SWDEV-2 - Change OpenCL version number from 3070 to 3071.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2818 edit


[ROCm/clr commit: 0117e25aee]
2020-01-01 03:08:24 -05:00
foreman f4968a048a P4 to Git Change 2051215 by chui@ocl-promo-incrementor on 2019/12/31 03:00:12
SWDEV-2 - Change OpenCL version number from 3069 to 3070.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2817 edit


[ROCm/clr commit: 4e2333f7d8]
2019-12-31 03:05:52 -05:00
foreman aa2c3a7b66 P4 to Git Change 2051060 by michliao@hliao-dev-00-hip.rocm-workspace on 2019/12/30 16:42:07
SWDEV-145570 - Clean up after `hipError_t` unification.

	- Replace deprecated `hipError_t` enums.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#24 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#94 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#52 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#27 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#5 edit


[ROCm/clr commit: 955b224ea0]
2019-12-30 16:46:39 -05:00
Evgeny Mankov 8c58286a9b Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/clr commit: ed43699a3a]
2019-12-30 19:21:09 +03:00
Sarbojit2019 4d2ee146e1 Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.

[ROCm/clr commit: 4fd77f8336]
2019-12-30 12:44:24 +05:30
Aryan Salmanpour ed2609b880 [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.

[ROCm/clr commit: 857052be1e]
2019-12-30 12:42:17 +05:30
ansurya 56d51a3dc7 Fix texture 3D & 2D layered with N components (#1746)
SWDEV-151670: Issue with 3D texture with 4 components
SWDEV-151671: Issue with 2D layered texture with 4 components

Fixed memcpy when memory is allocated with driver API's.

Github issues: #1755
Fixed 3D default case when array type is not set during memory allocation.

[ROCm/clr commit: 651c7a8e27]
2019-12-30 12:41:42 +05:30
foreman 7de9ef7fcf P4 to Git Change 2049940 by chui@ocl-promo-incrementor on 2019/12/24 03:00:09
SWDEV-2 - Change OpenCL version number from 3068 to 3069.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2816 edit


[ROCm/clr commit: c04203fc4d]
2019-12-24 03:08:17 -05:00
foreman deaa52db30 P4 to Git Change 2049729 by skudchad@skudchad_test2_win_opencl on 2019/12/23 12:36:57
SWDEV-203814 - Change the return type of the hiprtcGetTypeName to have compatibility across ABIs

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18392/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#9 edit


[ROCm/clr commit: 4185d21347]
2019-12-23 12:42:24 -05:00
Evgeny Mankov dc6cb8d032 Merge pull request #1762 from emankov/hipify-clang
[HIPIFY][doc] LLVM 9.0.1 is the latest stable release now

[ROCm/clr commit: 006e6844c1]
2019-12-23 20:02:32 +03:00
Evgeny Mankov f60903178d [HIPIFY][doc] LLVM 9.0.1 is the latest stable release now
+ Tested on Windows and Linux: no changes are needed


[ROCm/clr commit: 2d7e766cc7]
2019-12-23 20:00:33 +03:00
Evgeny Mankov d191980c6a [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/clr commit: 4aaa2336a8]
2019-12-23 17:01:35 +03:00
Yaxun (Sam) Liu 1224fa6da5 Add macro __HIP_ENABLE_CUDA_WRAPPER_FOR_OPENMP__ (#1761)
This is to allow force enable cuda wrapper for OpenMP for flexibility

[ROCm/clr commit: 35988729f3]
2019-12-23 19:24:54 +05:30
saleelk 60437b9d64 Fix the return type of demangle function so that its compatible across ABIs (#1744)
[ROCm/clr commit: 1ca75e5f6d]
2019-12-23 19:11:40 +05:30
Alex Voicu 1f762e3970 Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/clr commit: 150e690a3a]
2019-12-23 19:11:24 +05:30
Maneesh Gupta 36b23663e0 replace array designator C99 (#1694)
* replace array designator C99

* Update texture_functions.h

Highlight valid and invalid values in texFormatToSize

Co-authored-by: Maneesh Gupta <maneesh.gupta@amd.com>


[ROCm/clr commit: 32625638da]
2019-12-23 19:10:24 +05:30
Alex Voicu 47725baf8c static inline in a header, just like excess sugar in a diet, causes bloat (#1692)
[ROCm/clr commit: cf526f5484]
2019-12-23 19:09:38 +05:30
Evgeny Mankov 07db042750 [HIP] Fix typo
[ROCm/clr commit: 4d29423705]
2019-12-23 12:06:44 +03:00
foreman 6ca4dcecd0 P4 to Git Change 2049418 by chui@ocl-promo-incrementor on 2019/12/22 03:00:09
SWDEV-2 - Change OpenCL version number from 3067 to 3068.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2815 edit


[ROCm/clr commit: e866011a92]
2019-12-22 09:25:11 -05:00
Evgeny Mankov e25a6a39a3 [HIP] Unify hipError_t (Step 2)
Step 2. Make a few hipError codes deprecated
Update hipify-clang, hipify-perl, docs and samples accordingly


[ROCm/clr commit: 9ae76609a1]
2019-12-22 02:05:31 +03:00
Evgeny Mankov 4bb4b5e291 Merge pull request #1734 from vsytch/win10-hipMemcpy-fixes
Fix OOM issues with hipMemcpy test on Windows

[ROCm/clr commit: 3c6203c814]
2019-12-21 22:02:34 +03:00
foreman 9700257417 P4 to Git Change 2049382 by chui@ocl-promo-incrementor on 2019/12/21 03:00:08
SWDEV-2 - Change OpenCL version number from 3066 to 3067.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2814 edit


[ROCm/clr commit: 3190f82d6c]
2019-12-21 03:05:45 -05:00
Maneesh Gupta 35e4141eab Update texture_functions.h
Highlight valid and invalid values in texFormatToSize

[ROCm/clr commit: 6c7ce07577]
2019-12-21 12:25:36 +05:30
Maneesh Gupta 57b69adc8b bump version to 3.1 (#1756)
* Bump version to 3.1

* [ci] Enable tests on ROCm 3.0


[ROCm/clr commit: 86e590ad62]
2019-12-20 12:10:25 -08:00
foreman 113aa8bb48 P4 to Git Change 2049240 by lmoriche@lmoriche_opencl_dev2 on 2019/12/20 13:54:17
SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES

	Return an error instead of dereferencing a null pointer. This should address the issue described
	in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#59 edit


[ROCm/clr commit: ba3da9b3ec]
2019-12-20 13:02:52 -06:00
Evgeny Mankov b41f6ad42f Merge pull request #1757 from emankov/master
[HIPIFY][doc] Update Readme.md: versioning

[ROCm/clr commit: 4a8b87a96c]
2019-12-20 20:57:48 +03:00
Evgeny Mankov 919ef62fde [HIPIFY][doc] Update Readme.md: versioning
[ROCm/clr commit: 65dd13c677]
2019-12-20 20:55:19 +03:00
foreman c10d16fa10 P4 to Git Change 2049201 by skudchad@skudchad_test2_win_opencl on 2019/12/20 11:44:13
SWDEV-216708 - [hipclang-vdi-rocm][FBA-77]hipGetDeviceCount() query should not trigger any queue creation.
	- KFD queues get created when we call hsa_executable_load_agent_code_object when creating a blitProgram at init. Delay blit creation until when needed
	- Queue also gets created when we init a xferQueue. Delay that too until when needed.

	If we want to have a lite init, there are multiple changes needed in both OpenCL and HIP. Thats rather a feature to work on later.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18416/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocblit.cpp#34 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#148 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#47 edit


[ROCm/clr commit: 1384e82e60]
2019-12-20 11:50:41 -05:00
foreman 6322668c99 P4 to Git Change 2049013 by chui@ocl-promo-incrementor on 2019/12/20 03:00:07
SWDEV-2 - Change OpenCL version number from 3065 to 3066.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2813 edit


[ROCm/clr commit: 30ba6b114c]
2019-12-20 03:07:16 -05:00
Sarbojit2019 2916c02f7b Fix for windows dtest build failure (#1742)
[ROCm/clr commit: 911d406bf1]
2019-12-19 13:10:43 -08:00
foreman 3495fd6c12 P4 to Git Change 2048698 by jujiang@JJ-HIP on 2019/12/19 15:52:21
SWDEV-215536 - [HIP][Windows]Output mismatch with tex2DLayered()

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#93 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#31 edit


[ROCm/clr commit: 62f9114fd4]
2019-12-19 15:57:37 -05:00
mhbliao 313ab97c35 [hip] Add macro guarding the enum conversion for scalar accessor. (#1748)
- That's a high overhead part, which needs enabling ONLY if necessary.

[ROCm/clr commit: a0a50ac601]
2019-12-19 10:08:37 -08:00
foreman 1c99ab7f9d P4 to Git Change 2048585 by kjayapra@2_HIPWS_P2P_ROCM2 on 2019/12/19 12:15:48
SWDEV-215976 - Map IPC pointers to all devices by default, since Peer is enabled @ roc::init anyway.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#147 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#46 edit


[ROCm/clr commit: fc003e8db5]
2019-12-19 12:20:17 -05:00
foreman 68bdc7ce77 P4 to Git Change 2048321 by chui@ocl-promo-incrementor on 2019/12/19 03:00:07
SWDEV-2 - Change OpenCL version number from 3064 to 3065.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2812 edit


[ROCm/clr commit: c1c755e7ea]
2019-12-19 03:06:46 -05:00
Evgeny Mankov 0bd42da319 Merge pull request #1739 from emankov/hipify-clang
[HIP] Unify hipError_t (Step 1)

[ROCm/clr commit: 08f1c8edf3]
2019-12-19 07:57:02 +03:00
foreman 68d6989725 P4 to Git Change 2047959 by skudchad@skudchad_test2_win_opencl on 2019/12/18 14:40:28
SWDEV-213000 - Add notifyCmdQueue in ihipModuleLaunchKernel. This torques timing and flushes the queue immediately. Investigation pending.

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18408/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#51 edit


[ROCm/clr commit: 75df64737f]
2019-12-18 14:42:18 -05:00
foreman 49c805ab06 P4 to Git Change 2047634 by chui@ocl-promo-incrementor on 2019/12/18 03:00:06
SWDEV-2 - Change OpenCL version number from 3063 to 3064.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2811 edit


[ROCm/clr commit: 393e342fce]
2019-12-18 03:13:00 -05:00
foreman 4ab8c60043 P4 to Git Change 2047424 by lmoriche@lmoriche_opencl_dev2 on 2019/12/17 20:13:01
SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES

	Return an error instead of dereferencing a null pointer. This should address the issue described
	in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#92 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#58 edit


[ROCm/clr commit: 8d32b426dd]
2019-12-17 20:18:36 -05:00
foreman 8db83dd7d4 P4 to Git Change 2047300 by vsytchen@vsytchen-ocl-win10-2 on 2019/12/17 15:29:33
SWDEV-79445 - OCL generic changes and code clean-up

	Update Gfx9PlusSubDeviceInfo with Navi14Lite entry to match PAL's AsicRevision enum

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/18399/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#67 edit


[ROCm/clr commit: b4f2598005]
2019-12-17 15:32:30 -05:00
Evgeny Mankov ad045983bd Merge pull request #1743 from emankov/master
[HIPIFY] Revise HIP runtime

[ROCm/clr commit: b1aa111446]
2019-12-16 20:11:19 +03:00
Evgeny Mankov abcc1db917 [HIPIFY] Revise HIP runtime
+ hipMemAllocHost is deprecated, use hipHostMalloc instead
+ hipMemAllocManaged -> hipMallocManaged
+ hipFreeHost -> hipHostFree
+ cudaMemset3D(Async) -> hipMemset3D(Async)
+ update docs and hipify-perl accordingly


[ROCm/clr commit: 1108ef06e1]
2019-12-16 20:09:55 +03:00
foreman eede834682 P4 to Git Change 2045971 by chui@ocl-promo-incrementor on 2019/12/14 03:00:05
SWDEV-2 - Change OpenCL version number from 3062 to 3063.

Affected files ...

... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2810 edit


[ROCm/clr commit: d98ea91003]
2019-12-14 03:07:53 -05:00